With 36lts End of Life, we can remove compatibility code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because it's only used once, so let's inline it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

With 36lts End of Life, we can remove compatibility code.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Which makes data comparison predictable and stable across Python
versions and encodings.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Before the external runner had this name, it was named "inner runner",
and the sentence logged made sense like this:

"Running test with the inner level test runner /bin/foobar"

With the name change to "external" using "level" here doesn't sound
right anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is similar to the xunit unittest changes in 353fed04, but now
applied to the functional tests which happen to use the same features.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This is similar to the change in 418bf92a, but now applied to the
functional tests that deal with xunit.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Automatically chosen on Python 3.  This mimmics the (proposed)
behavior in `avocado/core/runner.py`.

Reference: https://github.com/avocado-framework/avocado/pull/2451Signed-off-by: NCleber Rosa <crosa@redhat.com>

base64.encodestring() requires bytes on Python 3, and the whiteboard,
on the other hand, requires a string.

The default encodings will be used for encoding, and for encoding,
we want to be safe and use ascii which can be represented in the
various result formats.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It was noticed during a review that, even though the SimpleQueue
requires a context on Python 3, the multiprocessing module can choose
one itself.

Since I originally had no intention to force the `spawn` type of
context, let's use that instead.  Also, since we're using different
names for a helper function and the class, one of the inspekt/pylint
exceptions is not needed anymore.

Kudos to Amador Pahim for suggesting that.

Reference: https://github.com/avocado-framework/avocado/pull/2441#discussion_r167850053Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

There's a better maintained trinity test at:

   https://github.com/avocado-framework-tests/avocado-misc-tests/blob/master/fuzz/trinity.py

Let's drop this outdated example.

Reference: https://github.com/avocado-framework/avocado/issues/2285
Reference: https://trello.com/c/uCcng8dN/1168-drop-trinity-example-testSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  fix avocado:utils:distro
  Fixed issue in avocado:utils:distro

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The "--rawurl" is not supported on later "fpaste" versions as it outputs
everything else to stderr. Anyway to keep compatibility with older
fpaste let's explicitly use `tail -n 1` to get only the last line.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

fixed pep8 issue on line no 319
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

In SUSE distro distro.detect() is failing as undefined variable

log:
START 1-generic/sosreport.py:sosreport_test.test;run-cd82
Test metadata:
  filename: /root/avocado-fvt-wrapper/tests/avocado-misc-tests/generic/sosreport.py
DATA (filename=output.expected) => NOT FOUND (data sources: variant, test, file)

Reproduced traceback from: /usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/core/test.py:814
Traceback (most recent call last):
  File "/root/avocado-fvt-wrapper/tests/avocado-misc-tests/generic/sosreport.py", line 42, in setUp
    dist = distro.detect()
  File "/usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/utils/distro.py", line 416, in detect
    distro_result = probe_instance.get_distro()
  File "/usr/lib/python2.7/site-packages/avocado_framework-58.0-py2.7.egg/avocado/utils/distro.py", line 370, in get_distro
    with open(self.check_file) as check_file:
AttributeError: 'SUSEProbe' object has no attribute 'check_file'
Signed-off-by: NPraveen K Pandey <praveen@linux.vnet.ibm.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Currently almost each "Dispatcher" implements it's own "map_method",
some allow to log tracebacks, some doesn't... Let's implement 2 main
variants, one simple without reporting the results, the other with
support for deepcopying of the arguments and returning the list of
results and use them in all dispatchers.

The main difference against previous version is that all dispatchers
will log the traceback (to avocado.debug) and that instead of individual
arguments it supports *args.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Server infrastructure: switch default URLs to HTTPS

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Test statuses: do not rely on varianter_yaml_to_mux plugin

HTTPS has been enabled on the avocado-project.org server, so let's use
it by default on docs and when downloading images from it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That's specific to Python 3, but works fine on Python 2.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which includes the module name, and the different treatment of
exceptions that do not inherit from BaseExcpetion.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Which gives predictable and stable results across Python versions.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Avocado used to provide support for "test aliases", that is, one could
call "avocado run synctest" when the file containing the test was
named "synctest.py".  See e65ff614 for an example.

Since this "feature" has been long removed, let's remove the tests
also.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Remove variable assigments that are used just once and never actually
used.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

And not a directory.  Tests were being always skipped becaused of that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The directory check is being performed, but without value to the test.
Let's turn it into an assertion.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  SIMPLE tests: improve status API

Currently simple tests have a limited status API, being able to set only
the WARN status by generating an output string in a very specific and
hard-coded format.

This patch, while respects the current behaviour, creates configuration
keys, allowing users to provide regular expressions to search for in the
test outputs, aiming to set the final test status to either WARN or SKIP
when the test finishes with exit code 0.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Which is an optional plugin, and the test statuses feature is at the
innermost core of Avocado.  While the original test indeed saved a lot
of duplicated code, it's code that serves a specific testing purpose,
and it's better to be simpler and more verbose and with the right (no)
dependencies.

This issue came up during the Python 3 port work.  Now that all the
unittests (selftests/unit/*) were passing (locally, there's one other
PR pending to be accepted), the next logical step is getting the
"core" functional (selftests/functional/*) tests passing.  Because
the 'varianter_yaml_to_mux' optional plugins port is not done, the
"core" functional tests fail and the current work flow is broken.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>