Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The skip_location is suppose to use "skip_location" and not
"warn_location".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The built-in regexp requires re.MULTILINE to work the same way as before
(allowing the match to be everywhere and not just in the first line).

As for the existing ones I believe users would benefit from allowing
MULTILINE as well, but there might be slight change in behavior.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Lint: enable unreachable code (W0101) check
  Lint: enable reimported (W0404) check
  Lint: add check for warnings also on CI
  Lint: W0622 fixes

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Pylint describes this warning as:

   Used when a module is reimported multiple times.

Let's enable it and fix the one occurrence it finds.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The following two issues come up on the CI environment:

    ************* Module avocado_runner_remote
    W0622: 51,0: ConnectionError: Redefining built-in 'ConnectionError'
    ************* Module tests.test_mux
    W0622:130,8: TestMuxTree.test_basic_functions: Redefining built-in 'ascii'

And are fixed here.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Update process.run, process.system, process.system_output
docstring for new allow_output_check
Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Each Job creates several dirs/files and uses certain handlers to setup
the environment, let's be explicit and instead of preparing everything
magically on __init__ and cleaning most of it after "run" let users to
"setup" and "cleanup" the Job handlers explicitly and to simplify the
usage also support __enter__ and __exit__ methods to be able to simply
use:

    # No job
    with Job(...) as job:
        # do your stuff with temporary handlers set
    # Job temporary handlers cleaned
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently we use global "avocado.core.data_dir.get_tmp_dir" temporary
directory for Job execution, which does not allow coexistence of
multiple jobs. Let's only use that location as base_tmpdir and create a
per-job dir there.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `srcdir` is always executed during `_setup_environment_variables`,
initializing it lazily only consumes more mem and power. As a benefit
having it initialized we can directly access `self.__srcdir` internally
and remove the hack to not-log-warning-on-internal-access.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Lint: enable W0612 and W0622 checks
  Result Upload plugin: use rsync binary as found
  selftests/.data/test_statuses.py: avoid redefining Exceptions
  avocado/utils/memory.py: do not mask builtin MemoryError

These warnings are described as:

 W0612: Used when a variable is defined but not used.
 W0622: Used when a variable or function override a built-in.

After a suggestion from Andrei Stepanov, we decided to immediately
enable these.

Rerefence: https://pagure.io/standard-test-roles/pull-request/144
Reference: https://trello.com/c/Ohh7Q6qj/1183-enable-w-in-travis-make-checkSigned-off-by: NCleber Rosa <crosa@redhat.com>

The results *should* be the same without this change, but it
can lead to a different binary being used from the one that
was found previously.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

That is, to fix this pylint condition:

   W0622:263,0: Exception: Redefining built-in 'Exception'

We need to rename the Exception test.  To make things consistent,
let's rename all of the tests accordingly.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python already has a builtin MemoryError exception.  The description
of such an exception is different from the goal here, so let's just
use a different name.

Reference: https://docs.python.org/3/library/exceptions.html#MemoryErrorSigned-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Test: initialize workdir early in non-lazy mode
  Test: rely on TestId.str_filesystem for the workdir
  Test: provide more metadata information
  Test: use more appropriate exceptions on invalid input
  Test: log test init before other messages

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

This should allow easier integration with children that override
"self.params". Such classes should simply use custom "self.params" and
report their "self.custom_params" while in "get_state" the stock Avocado
params would be used.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The "self.params" should be Avocado params, but tests might override
them (and Avocado-vt does). Let's be lenient to failures and simply
report None.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

This adds Python 3 packages for Avocado and for all plugins that have
its dependencies fulfilled by Python 3 versions of their requirements.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And favor a system wide path for `avocado exec-path`, in the same way
we prefer the `/etc/avocado` files.  If not running from packages, the
Python version specific location will be used.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

With content that is common to both Python 2 and Python 3 versions of
the Avocado packages.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Commit 24f3b936 removed compatibility with package name "avocado", but
missed that for plugins.  Let's remove those too.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The last change in meminfo object to use the new DataSize object
introduced a wrong behaviour. Currently meminfo is not returning updated
values. This patch fixes it.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The latest jobs have been failing because of the following issues:

    ************* Module raise
    E1130: 48,30: Raise.test: bad operand type for unary -: NoneType
    ************* Module selftests.functional.test_basic
    I1101:1191,24: PluginsXunitTest.run_and_check: Module 'lxml.etree'
    has not 'XMLSchema' member, but source is unavailable. Consider
    adding this module to extension-pkg-whitelist if you want to
    perform analysis based on run-time introspection of living
    objects.
    I1101:1191,40: PluginsXunitTest.run_and_check: Module 'lxml.etree'
    has not 'parse' member, but source is unavailable. Consider adding
    this module to extension-pkg-whitelist if you want to perform
    analysis based on run-time introspection of living objects.
    I1101:1193,43: PluginsXunitTest.run_and_check: Module 'lxml.etree'
    has not 'parse' member, but source is unavailable. Consider adding
    this module to extension-pkg-whitelist if you want to perform
    analysis based on run-time introspection of living objects.
    ************* Module selftests.unit.test_xunit
    I1101: 91,24: xUnitSucceedTest.test_add_success: Module
    'lxml.etree' has not 'XMLSchema' member, but source is
    unavailable. Consider adding this module to
    extension-pkg-whitelist if you want to perform analysis based on
    run-time introspection of living objects.
    I1101: 91,40: xUnitSucceedTest.test_add_success: Module
    'lxml.etree' has not 'parse' member, but source is
    unavailable. Consider adding this module to
    extension-pkg-whitelist if you want to perform analysis based on
    run-time introspection of living objects.
    I1101: 92,43: xUnitSucceedTest.test_add_success: Module
    'lxml.etree' has not 'parse' member, but source is
    unavailable. Consider adding this module to
    extension-pkg-whitelist if you want to perform analysis based on
    run-time introspection of living objects.

We can't whitelist the `lxml.etree` module at this time (inspekt doesn't
have such an option) and the raise failure is a false positive.  Let's
ignore those issues then.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>