Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  vmimage: adjust the 64bits arch on Debian/Ubuntu

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  avocado/core/job.py: make GIT optional when getting Avocado version

An Avocado job execution will log the GIT information when it's run
from a GIT repo.  But, let's make having GIT optional, so that we
don't introduce yet another depedency.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Spelling fixes

Just the usual spelling fixes and additions to the ignore list.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Debian and Ubuntu use 'amd64' to refer to 64bits arch. Let's use 'amd64'
when the specified arch (auto-discovered or not) is 'x86_64'.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Loader: be clear about the meaning of NOT_A_TEST

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  selftests/unit/test_test.py: fix typo in test name
  Test ID: make the format friendlier for Windows FS

Signed-off-by: NCleber Rosa <crosa@redhat.com>

NOT_A_TEST is a test resolution result that currently only applies to
INSTRUMENTED, PyUNITTEST and SIMPLE tests.  The message given on the
command line, though, doesn't make that completely clear because it
omits the PyUNITTEST and SIMPLE test types.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

The extra category for plugins looks confusing to me. This patch
slightly changes the wording and moves the links to optional plugins
directly into the PIP installation section.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

It's possible that some daemons spawn other processes. Theoretically
killing the main process should clean everything, but to be certain
let's kill the full process tree (still it's possible the process
creates double-forked daemons which won't be killed, though).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The daemons has to be also stopped in end_test_hook, otherwise they
would be preserved after Avocado is finished.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The use of shell in subprocess should not be needed and might bring some
security issues. Let's disable it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Let's update the command to install the packages dependencies to
the latest fedora. In this commit:

- Switch from 'yum' to 'dnf'.
- Add python2: latest Fedora does not ship python2 package in minimal
installation.
- Add libffi-devel and openssl-devel: not shipped in latest Fedora
minimal installation.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The _create_from_yaml contains many branches, let's extract the usable
chunks into methods to improve readability.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Few style fixes, there is slight modification to behavior of `loader`
constructors, which now accept *args instead of 2 hardcoded arguments,
but they don't actually use the values so it does not matter much.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The loader import is a leftover from when the yaml_to_mux_loader was
part of this plugin, which was separated and this import does not serve
any purpose.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Don't create nodes directly, but first attempt to use OrderedDict. If
advanced features (tags, ...) are detected, declare the current mapping
TreeNode and follow as before. In the end create mapping which should
turn the directly connected OrderedDicts into TreeNodes while keep the
hidden user dicts as OrderedDicts.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The keys are not smart-converted into detected types, but always used as
they are. Let's mention this in our documentation.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Avocado supports running python unittests directly without the need to
discover them via script, let's use it in our selftests script.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The python unittests should be executable even now as a simple tests or
via external runner + contrib script. Let's create a new type and
discover python unittests as first-class test types in Avocado.

As Avocado tests are in fact python unittests, we need to manually skip
these by ignoring tests that are discovered as Avocado tests, but are
marked as not-to-be-executed, which required the additional change to
_find_avocado_tests method.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The filelock test heavily depends on the storage speed. Worse this
dependency is not linear as we issue 1000 attemps in parallel which is
quite a lot simultaneous writes. On my laptop with ssd vs. in-mem
location formula (time of 100 iterations) + 2e-5*no_players worked the
best.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The basedir was mainly set correctly, but sometimes not used in some of
the tests. Let's move the `os.chdir` to `setUp` phase where it makes
sense and add new ones where they were not present.

Related to basedir the test_mux was using hardcoded path based on the
method used to execute the test, let's change it to `__file__` which
gives better results.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The ExternalLoader uses collections.namedtuple to create class fitting
it's purpose. This class is intended for dynamic coding while here we
always know the interface. Let's create ExternalLoaderSpec class to wrap
the details.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The `_make_avocado_tests` does not actually produce avocado tests, it
only processes existing file into the most suitable test definition,
which can be INSTRUMENTED, SIMPLE but also MISSING test. Let's rename
that function as well as the tests variable.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's currently not clear how users should go about installing the
optional plugins when using PyPI/pip.

Let's list the package names as they're available on PyPI.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Utility to provide Qcow VM Images acquired from distro repositories.

Usage:

    >>> from avocado.utils import vmimage

    >>> image = vmimage.get()
    >>> image
    <Image name=Fedora version=26 arch=x86_64>
    >>> image.name
    'Fedora'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-d369c285.qcow2'
    >>> image.get()
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-e887c743.qcow2'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64-e887c743.qcow2'
    >>> image.version
    26
    >>> image.base_image
    '/tmp/Fedora-Cloud-Base-26-1.5.x86_64.qcow2'

    >>> image = vmimage.get(arch='aarch64')
    >>> image
    <Image name=FedoraSecondary version=26 arch=aarch64>
    >>> image.name
    'FedoraSecondary'
    >>> image.path
    '/tmp/Fedora-Cloud-Base-26-1.5.aarch64-07b8fbda.qcow2'

    >>> image = vmimage.get(version=7)
    >>> image
    <Image name=CentOS version=7 arch=x86_64>
    >>> image.path
    '/tmp/CentOS-7-x86_64-GenericCloud-1708-dd8139c5.qcow2'

    >>> i1 = vmimage.get()
    >>> i2 = vmimage.get()
    >>> i1.path == i2.path
    False
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  test: flag that test is being skipped

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Removal of "import magic" for avocado and avocado-rest-client
  scripts/avocado: remove duplicate conditional '__main__' section