Some tests that rely on output check may also rely on the combined
generated output (stdout+stderr).  The first step is to record that
in the same order it was generated.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Added a method to get near real physical memory

The current state of this comment is the result of a mechanical change
replacing `urls` with `references`.

The source for references given on the command line is working as
intended, that is, if test references are given on the command line
they are taken and will override the ones on the replay args.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The recording of Avocado version, when running from a GIT repo has
been broken for a long time (since the SPEC file was renamed).  This
could be a simple fix to just match the new SPEC file named, but I
think we can do better.  Besides this fix, the changes here include:

 - Print a short commit instead (8 chars)
 - Omit branch name, commit is authoritative enough and developers can
   tell the name of a branch if it's really necessary

But, let me say that this is still broken.  The GIT version
information is only printed if the current work directory is inside
the GIT repo directory.  A better (and way more complex) fix would be
one that looks where the avocado script and Python libraries were
loaded from, and check if that location is a GIT repo.  Instead of
doing that, though, it'd make more sense to use a semantic version
approach (and possibly a library).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

New functions added for memory offline and online, check if memory is
hotpluggable, check if kernel supports memory hotplug.

These functions will be used more often by memory testcases in avocado-misc-tests

Implemented review comments from #2114, #2116
Signed-off-by: NAbdul Haleem <abdhalee@linux.vnet.ibm.com>

The current TestName class records more than a test name (according
to the Avocado specification).  It records, and by default, presents
the Test ID (__str__() and __repr__()).

The Test Name, again according to the Avocado specifications, is
contained within a Test ID, so it's not necessary to have two
different classes IMO.

Finally, the str_filesystem() method was adapted to be coherent with
the fact that it returns a file system representation of the Test ID,
not the Test Name.  It also became a property, to match the same use
of str_uid and str_variant.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's a clear difference about of what a test file, and a test
itself, is in Avocado.  The datadir attribute though, has not been
created with such a difference in mind.

The best solution would be to renamed it to something like
"file_datadir", but since it's test a public (and stable) API, it's
not going to be changed anytime soon.

So, for now, let's clarify the meaning of the datadir property.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current assignment of variant and str_variant attributes of a
TestName have two extra conditional blocks that are unnecessary.

Besides that, IMO, the proposed code is easier to follow.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python code should not be doing type check/enforcement.

This bit was here temporarily, when the name parameter to
avocado.core.test.Test got changed.  Now it's way past time to remove
it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current example, on Test Names, where being given on the Test ID
section.  Let's move them closer to the Test Name section, and while
at it, also give Test ID examples.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

A number of example files are not currently being packaged.  Let's
install and package them.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The current SPEC file changelog is getting really long.  I think
we can do better with a shorter version.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

There's no need for this .gitignore file, the dir has other legit
files.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

While a given resolver could return such a test name, I think this is
a bad example for a Test Name in this section.

The reason is that it's not possible, with the available test
resolvers/loaders to create a test such as that (it used to be).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The execute_cmd() method is not supposed to be public, to be used by
instances of the SimpleTest and ExternalRunnerTest class.

Let's make it protected then.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Because it's a Python standard module, and while it doesn't violate
any style rules, using a different name avoid any confusion.

While changing the parameter name, do a minor improvement of the
docstrings.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The vast majority of selftests do not use CamelCase, but some still
remain.  Let's stick to a single naming pattern.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Fix Travis check

With the EOL of Ubuntu 12.04, Travis CI is now running our tests using
Ubuntu 14.04. With this change, our check started to fail.

Even though I'm not sure about the reasons, I could make it work by
using a newer version of Pillow and also installing libvirt-python from
pip, since it's not working in the virtualenv if installed from apt.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

utils.wait: docstring typo

Parameter is `step`, docstring says `steps`. Fixing.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

This module has a number of functions aiming to retrieve and/or
convert values from /proc/meminfo. It's time to create a more robust
representation of /proc/meminfo. This commit creates a MemInfo class,
instantiated in a meminfo object.

The MemInfo class carries one attribute for each item in /proc/meminfo.
Each attribute is in fact an instance of the _MemInfoItem class, which
contains attributes to expose the item value. The basic 'value'
attribute will show the value as is. The additional attributes will
show the converted value, according to the selected unit.

Usage:

    >>> from avocado.utils import memory

    >>> memory.meminfo
    <avocado.utils.memory.MemInfo object at 0x7fe8e737f250>

    >>> dir(memory.meminfo)
    ['Active', 'Active_anon_', 'Active_file_', 'AnonHugePages',
    'AnonPages', 'Bounce', 'Buffers', 'Cached', 'CmaFree', 'CmaTotal',
    'CommitLimit', 'Committed_AS', 'DirectMap1G', 'DirectMap2M',
    'DirectMap4k', 'Dirty', 'HardwareCorrupted', 'HugePages_Free',
    'HugePages_Rsvd', 'HugePages_Surp', 'HugePages_Total', 'Hugepagesize',
    'Inactive', 'Inactive_anon_', 'Inactive_file_', 'KernelStack',
    'Mapped', 'MemAvailable', 'MemFree', 'MemInfoObject', 'MemTotal',
    'Mlocked', 'NFS_Unstable', 'PageTables', 'SReclaimable', 'SUnreclaim',
    'Shmem', 'ShmemHugePages', 'ShmemPmdMapped', 'Slab', 'SwapCached',
    'SwapFree', 'SwapTotal', 'Unevictable', 'VmallocChunk', 'VmallocTotal',
    'VmallocUsed', 'Writeback', 'WritebackTmp', '_MemInfo__meminfo',
    '__class__', '__delattr__', '__dict__', '__dir__', '__doc__',
    '__format__', '__getattr__', '__getattribute__', '__hash__',
    '__init__', '__iter__', '__module__', '__new__', '__reduce__',
    '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__', '__str__',
    '__subclasshook__', '__weakref__']

    >>> memory.meminfo.MemTotal
    <avocado.utils.memory._MemInfoItem object at 0x7fe8f6ff8750>

    >>> dir(memory.meminfo.MemTotal)
    ['_MemInfoObject__units', '__call__', '__class__', '__delattr__',
    '__dict__', '__dir__', '__doc__', '__format__', '__getattr__',
    '__getattribute__', '__hash__', '__init__', '__module__', '__new__',
    '__reduce__', '__reduce_ex__', '__repr__', '__setattr__', '__sizeof__',
    '__str__', '__subclasshook__', '__weakref__', '_convert', 'name',
    'value', 'b', 'gb', 'kb', 'mb', 'tb']

    >>> memory.meminfo.MemTotal.value
    15853856

    >>> memory.meminfo.MemTotal.mb
    15482

    >>> for item in memory.meminfo:
    ...     print item.name, item.mb
    ...
    WritebackTmp 0
    SwapTotal 7744
    SwapFree 7744
    DirectMap4k 384
    KernelStack 5
    MemFree 10785
    HugePages_Rsvd 0
    Committed_AS 2108
    SUnreclaim 197
    NFS_Unstable 0
    VmallocChunk 0
    CmaFree 0
    Writeback 0
    MemTotal 15482
    VmallocUsed 0
    DirectMap1G 6144
    HugePages_Free 0
    AnonHugePages 0
    Active_file_ 1259
    AnonPages 440
    Inactive_anon_ 67
    Active 1719
    CommitLimit 15486
    Hugepagesize 2
    Active_anon_ 459
    Cached 2969
    SwapCached 0
    VmallocTotal 33554431
    CmaTotal 0
    Shmem 87
    Mapped 242
    ShmemPmdMapped 0
    Unevictable 0
    SReclaimable 536
    MemAvailable 13874
    Mlocked 0
    DirectMap2M 10310
    HugePages_Surp 0
    Bounce 0
    Inactive 1691
    PageTables 19
    HardwareCorrupted 0
    ShmemHugePages 0
    HugePages_Total 0
    Slab 734
    Inactive_file_ 1623
    Buffers 2
    Dirty 0
Signed-off-by: NAmador Pahim <apahim@redhat.com>

MemTotal in /proc/meminfo would display total
usable memory(i.e. physical ram minus a few reserved
bits and the kernel binary code)

So, this method helps to report actual memory size according
to online-memory blocks available via "/sys"
Signed-off-by: NSatheesh Rajendran <sathnaga@linux.vnet.ibm.com>

selftests: Two small selftest-related tweaks

This test is failing on my "slow" system, let's increase the timeouts,
they are used in `wait_for` so it shouldn't slow down the "quick"
systems.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Recently we changed the inspekt execution to use the 0.4.5 syntax and
forgot to include this change in `requirements-selftest`. Fixing it now.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  travis: Update to inspektor 0.4.5
  Linter Fixes

Inspektor 0.4.5 brings a number of updates, including
porting to the cliff command line application framework,
which makes inspekt commands to look more natural in
terms of arguments.  Let's update and reflect that
in the CI scripts.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Found by the newest version of inspektor, 0.4.5.
Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>