Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

As it was done in d2b4edc3, Python 3.4 needs a string to be passed to
json.loads() (and, indirectly, to json.load()).  Different from
d2b4edc3, the content we fetch externally may be able to tell us the
encoding that is used.

Let's use that information, if available, to decode the stream of
bytes into a string that is acceptable to json.loads().
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

On Python 2 packages.  We were previously relying on the fact that
stevedore requires six too, but that's not the right way to approach a
direct dependency.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python dependencies are already tracked by the python2 or python3
"Requires".  This filters out the python binaries from the RPM
automatic requires/provides scanner.

Before this change, a query for the requirements of the Python 2 package
would reveal:

    $ rpm -qRp fedora-26-noarch/python2-avocado-60.0-1.fc26.noarch.rpm
    /usr/bin/python2
    /usr/bin/python3
    ...

Reference: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Filtering_provides_and_requires_after_scanningSigned-off-by: NCleber Rosa <crosa@redhat.com>

text_output was removed from test status. Now we have to open the log
file directly.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

So that, if the system version on a given distro is Python 3, the
python3-avocado package will automatically "Provide:" python-avocado.

Reference: https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macroSigned-off-by: NCleber Rosa <crosa@redhat.com>

As it has been done with python-avocado-common in 18d21873,
the requirements should really be in the versioned sub-packages.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Into the specific python2-avocado or python3-avocado.  This is the
right way, and not using the python-avocado package that won't get
installed, to make sure the needed configuration files are always
present.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The skip_location is suppose to use "skip_location" and not
"warn_location".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The built-in regexp requires re.MULTILINE to work the same way as before
(allowing the match to be everywhere and not just in the first line).

As for the existing ones I believe users would benefit from allowing
MULTILINE as well, but there might be slight change in behavior.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

And not the hardcoded path "./scripts/avocado".
Signed-off-by: NMerlin Mathesius <mmathesi@redhat.com>
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

And not only for the content of params, assuming the existence of
params.  This fixes the following error:

   $ avocado run passtest.py --vm-domain f26 --vm-username root
   JOB ID     : 488c8f26de7b52707e8ddb2b89d0f03a0622391d
   JOB LOG    : /home/cleber/avocado/job-results/job-2018-03-26T16.58-488c8f2/job.log
   DOMAIN     : f26
   LOGIN      : root@f26 (TIMEOUT: 120 seconds)
    (1/1) passtest.py:PassTest.test: PASS (0.01 s)
   RESULTS    : PASS 1 | ERROR 0 | FAIL 0 | SKIP 0 | WARN 0 | INTERRUPT 0 | CANCEL 0
   JOB TIME   : 1.39 s
   Error running method "render" of plugin "html": 'params'
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

And only if the method is not available, attempt to fallback to
the stdout itself if it is a string.

Before 30617c1e, the following kind of check was done:

   >>> type(bytes('foo')) in string_types
   False

And after it, the check was changed to:

   >>> isinstance(bytes('foo'), string_types)
   True

That made the bytes decoding not to be performed at times.  While the
new check is correct, we should favor the attempt to decode, and
only if not available, fallback to the original stdout if it looks
like a string.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

in avocado/core/data_dir.py, line 232, in __del__
Signed-off-by: Nchunfuwen <chwen@redhat.com>

string in python3
Signed-off-by: Nchunfuwen <chwen@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  Lint: enable unreachable code (W0101) check
  Lint: enable reimported (W0404) check
  Lint: add check for warnings also on CI
  Lint: W0622 fixes

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Pylint describes this warning as:

   Used when a module is reimported multiple times.

Let's enable it and fix the one occurrence it finds.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The following two issues come up on the CI environment:

    ************* Module avocado_runner_remote
    W0622: 51,0: ConnectionError: Redefining built-in 'ConnectionError'
    ************* Module tests.test_mux
    W0622:130,8: TestMuxTree.test_basic_functions: Redefining built-in 'ascii'

And are fixed here.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Update process.run, process.system, process.system_output
docstring for new allow_output_check
Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NJunxiang Li <junli@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Each Job creates several dirs/files and uses certain handlers to setup
the environment, let's be explicit and instead of preparing everything
magically on __init__ and cleaning most of it after "run" let users to
"setup" and "cleanup" the Job handlers explicitly and to simplify the
usage also support __enter__ and __exit__ methods to be able to simply
use:

    # No job
    with Job(...) as job:
        # do your stuff with temporary handlers set
    # Job temporary handlers cleaned
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>