avocado/core/virt.py: avoid crashing when trying to detect VM IP address

The current code assumes that libvirt will always return information
about the VM in a given format, and also assumes that the VM will have
a NIC, which may not be the case.

This adds better checks if the conditions are not met, skipping the
IP detection feature, instead of crashing.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Together with the asset files, we'll now host the RPM repos at
a couple of OpenShift instances, named after the Avocado Project.

The two main repo files are located at:

 * https://repos-avocadoproject.rhcloud.com/static/avocado-fedora.repo
 * https://repos-avocadoproject.rhcloud.com/static/avocado-el.repo

And they point to the same base URL for individual repositories.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

With recent refactorings of the loading code, some of
the logic became unreachable (and irrelevant to avocado).
Let's remove the unreachable code.
Signed-off-by: NLucas Meneghel Rodrigues <lmr@redhat.com>

Signed-off-by: NLucas Meneghel Rodrigues <lookkas@gmail.com>

To sync with the latest changes in Avocado.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The path in logdir has to be turned into a safe-path.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

This function can be used in other parts of this project (eg. remote).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

this was removed from the "Log remaining buffer on exit" fix, but it's
in-deed necessary (bfr is filled in a loop).
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The SubProcess logs output only when it finishes with '\n' to avoid
partial outputs. Anyway we have to print the remaining buffer on
exit, otherwise we miss the unterminated output (eg on "echo -n")
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When the user provides url, which is not directory, this piece of code
tries to discover it as usual. When this fails it splits the command
using "shlex.split" and checks whether the first argument is executable.
If so it it reports it as a simple test.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Currently SimpleTest escapes the test command. External runner used
a workaround to be able to override the command with it's custom
one. Instead of this hack we can simply expect user to supply command
already escaped so it can be simply executed.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We base our log-dir on test name, which can contain various characters
including '/', causing multiple directories being created instead of one
log directory. This patch modifies the `self.logdir` to use '_' instead
'/'.

Note this approach is not safe on windows so in the future we might
implement a `utils` function to make filenames "safe". (similarly to
django, which uses whitelist)
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

We have a nice mechanism to notify user about job failures, let's use
it instead of custom sys.exit().

Additionally add '\n' before the first message on exception, because
quite often there are already some characters written.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When the process handling test fails before it puts the early_status,
avocado hangs for ever (or test-timeout). This patch raises an
exception in case the process died and the queue is still empty.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

In case of uncaught exception exception store the exception info and
notify the user about the fatal crash, instead of default traceback.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Since the job log result directory will not exit, let's not create
the utility link "latest" to it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Test loader: replace list_tests parameter name for a better description

Exit codes: use symbols

Since we define the meaning of each exit code, we should be using that
ourselves.

Functional tests have been coded using literal values, and there may
be a good reason for that: proving that the API stands.  But there's a
big issue: we have not declared those codes as some kind of an
external API and guarantee stability. Also the subsequent changes in
this series actually change the meaning and values of those.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

This makes the individual definitions (symbols) to be properly documented
and indexed in the documentation.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

It's prone to mistakes maintain two separate ways to query for tests
(running them and displaying available ones).

This patch implements --dry-run, which follows the full "run" process,
only instead of running the test it skips them.

Additionally the --dry-run uses some tweaks to tell them apart from
normal executions, namely:

    1. No sysinfo gathering
    2. Unique id is 0000000000000000000000000000000000000000
    3. Unless user provides custom log location, fresh tmpdir is used
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Improve the `AvocadoParams.iteritems()` to return unique items only
in the same fashion `multiplexer` does it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

dmesg -c does not work well in multi-user/execution scenario and also it
removes the messages for debugging purposes on the system. Let's store
full dmesg and leave it up-to the users to diff it.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The 'list_tests' parameters is used to select which tests should be
listed.  IMHO, it sounds like a boolean kind of parameter, which will
either list tests or not. Let's replace that parameter name with
'which_tests', that IMHO give a better message about its intended
usage.

Also, let's standardize the docstrings, and use the declared supported
symbols for these parameters (DEFAULT, AVAILABLE or ALL) instead of their
values (False, etc).
Signed-off-by: NCleber Rosa <crosa@redhat.com>