Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Some distros don't create `/bin/python` and only ship with
`/bin/python2` or `/bin/python3`.  As we are already detecting
`python3` let's also look for `python2` explicitly.

Also, let's fallback to unversioned `python` if no other is found, as
unlikely as it may be.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The test names are based on the executable output with '-l', but
it should be treated as text, and not as bytes.

This fixes issue #2927.

Reference: https://github.com/avocado-framework/avocado/issues/2927Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

to prevent Fedora 30 BuildRoot Policy Scripts from failing the build with
"ambiguous python shebang" errors.

https://fedoraproject.org/wiki/Changes/Make_ambiguous_python_shebangs_error
https://fedoraproject.org/wiki/Packaging:Guidelines#Shebang_linesSigned-off-by: NMerlin Mathesius <mmathesi@redhat.com>

https://fedoraproject.org/wiki/Changes/Mass_Python_2_Package_RemovalSigned-off-by: NMerlin Mathesius <mmathesi@redhat.com>

The fixes initated by d9a13f1d missed all results in the `revert`
function and any `stderr` decoding.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Thin pools don't have LVPath field which we originally used to
detect logical volume. A far better approach to identify the
existance of a logical volume is to restrict the large output
to logical volumes wihin the group and then match on the more
universal Name field.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

In addition, we unify the naming of both to standard "vg/lv_list". It
is true that the "--all" switch has different meaning for each of these
functions but we simply default to listing as much as possible in a
single list function for each of LV/VG (e.g. the "--all" switch includes
internal logical volumes the listing of which won't harm but help the
output to be as explicit as possible).
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Since SSDs are becoming more common, the performance punishment
of moving from RAM to SSD is not very high and the capacity gain
is significant when running a large number of vms.
Signed-off-by: NPlamen Dimitrov <pdimitrov@pevogam.com>

Because the test test_force_unmount_get_pids_fail() mocks the
inner behavior of the the unmount() method, let's add a call
to non-mocked version before the process attempts to terminate
itself.

Note: this is a hot fix for the problem described in the comment,
and referenced below.

Reference: https://trello.com/c/7OnKaLoG/1446-bug-procterminate-not-reliableSigned-off-by: NCleber Rosa <crosa@redhat.com>

The goal of the shell command used in these tests is to simply have
the mountpoint as being used, and for that, there's no need to keep
creating/removing files (it's actually an invitation to race
conditions).

Let's replace that approach with a more stable/predictable command,
which opens a single file for writing at the mount point location.

The original motivation for the change was caused by failures on
the test when run in certain environments.  I believe the fact
that trying to kill the shell process while it's spawning "echo"
and "rm" in a busy loop could be causing a race condition.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The only goal of many of the "with open()" blocks, is to read a file.
Let's move the rest of the outside that context.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

On 03d81fea, we let the Avocado developer choose the Python version
to use by setting a PYTHON variable that gets passed to `make`
commands.

But, we missed the case when the execution of the selftests is not
done in parallel.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Given that the setUp() phase is not useful for test_disk_space, and the
custom cleanup done in the test is better had at the tearDown() phase.

Additionally, the following changes where made to make it more reliable:

 * Avoid the busy loop giving modprobe some time between attempts
 * Use "modprobe -r" instead of rmmod, which handlers module dependencies
 * Do an explicit check for status
 * If "modprobe -r" doesn't succeed, it's not a test failure, but a test
   a test error (given that the get_diskspace() function already ran
   and succeeded).

Ideally, the module removal would be done by the linux_modules.unload_module()
but there are some issues with that function that needs addressing first
(such as returning a meaningful result).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

As we don't need to support Python < 2.7 anymore.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Currently we use "avocado" as a suite name, let's use job-dir which is
quite useful when matching xml results to output directories.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

The logic of _make_test_runner() is too simple, and can be further
simplified, to justify a separate method.  Referring back to the
implementation of _make_test_runner() makes reading the code harder
IMO, so let's inline it.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The related command line option is "--keep-tmp", and it keeps the
setting on "keep_tmp", so it just makes sense, for easier reading of
the code, to name the variable in a similar way.

While at it, let's prevent crash if "os.path.exists()" in "cleanup()"
is given a tmpdir that is None.  This was not caught before because
the default value of "__remove_tmp" would prevent "os.path.exists()"
to be reached.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

A gzip file doesn't have all the "archive" properties that a tarfile
or zipfile has, but still, it could be useful to wrap in the archive
module.

At this point, support is being added to allow for files compressed
with gzip, to be acknowledged as valid in avocado.utils.is_archive()
and transparently handled with avocado.util.uncompress().

The goal of this implementation is to allow for gzip files, which
are compressed tarbals, to be properly handled at uncompress() time.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The PYTHON variable evaluation changed recently resulting in different
than default PYTHON variable in some plugins resulting "make link" in
setting Avocado under different python than the linked plugin (eg.
Avocado-vt). Let's make sure we use the same python by passing
PYTHON="$(PYTHON)".
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCaio Carrara <ccarrara@redhat.com>

The newly released pylint version 2.2.0, changed its default behavior
(enabled) the following checks:

 * :unnecessary-pass (W0107): *Unnecessary pass statement*
   Used when a "pass" statement that can be avoided is encountered.

 * :unused-import (W0611): *Unused %s*
   Used when an imported module or variable is not used.

Let's apply fixes to those checks, and at the same time, pin the
pylint versions so that our CI environment is more stable (code that
test our code -- pylint -- doesn't change, while our code changes).

For Python 2, the latest release was 1.9.3, so let's use that.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Python3 only allows seek from the beginning of the file when the file is
opened in text mode.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

On python3 divisions are converted to float automatically, but floats
can't be supplied to seek.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

When attaching only partial log file we already calculate the "size =
max_size / 2", therefor it does not make sense to divide it twice (it
actually results in even shorter attached logs.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>