For small classes, like this one, with known attributes, using dict
wastes a lot of RAM. Defining __slots__ as a list will save a lot of
memory, while improving the performance a bit.

Before this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 1.1383171081542969

After this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 1.1071600914001465
Signed-off-by: NAmador Pahim <apahim@redhat.com>

We loose in flexibility by the performance improvement justifies the
change. Since __getattr__ is the last resource python tries to solve
attributes, creating the actual properties makes the resolution to
happen earlier and the performance to be way better.

Before this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 2.0695440769195557

After this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 1.1383171081542969
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Instead of using regex to parse the `data`, let's use a simpler and more
performatic version witch just handles the last character to figure out
the unit.

Before this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 2.988218069076538

After this patch:

>>> timeit.timeit('data_structures.DataSize("1M").b',
                  setup='from avocado.utils import data_structures',
                  number=1000000)
>>> 2.0695440769195557
Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

There are few issues (3 to my count) which affect a number of tests
on Python 3.  Instead of not executing any of the functional tests,
let's skip the broken ones.

This is important because it will prevent new issues from making
its way into the Avocado code.

The list of tests being skipped is being tracked on our planning board,
so that they are accounted for, and enabled when fixed.

Reference: https://trello.com/c/eFY9Vw1R/1282-python-3-functional-tests-checklistSigned-off-by: NCleber Rosa <crosa@redhat.com>

This prevents the plugin from trying to run references such as
Avocado-VT tests or any other that is not backed by an executable
file.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

And that have been causing failures on Travis jobs, due to limited
on unreliable amount of resources present.

This is the full list of tests that won't be run anymore on Travis,
only on `make check-full`:

  selftests.functional.test_basic.RunnerOperationTest.test_early_latest_result
  selftests.functional.test_basic.RunnerSimpleTest.test_kill_stopped_sleep
  selftests.functional.test_interrupt.InterruptTest.test_well_behaved_sigint
  selftests.functional.test_interrupt.InterruptTest.test_well_behaved_sigterm
  selftests.functional.test_loader.LoaderTestFunctional.test_simple_using_main
  selftests.functional.test_loader.LoaderTestFunctional.test_sleep_a_lot
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Some tests might produce too much logs which might result in too big
xunit results, that might be hard/impossible to publish. Let's allow
setting a limit to number of characters to those files and embed only
1/2 of the limit from the beginning and 1/2 of the limit from the end of
the log.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Added support to pass full string of block id like 'memory234',
it saves few steps of the user to find the memory blocks and call
this functions to hotplug/unplug
Signed-off-by: NAbdul Haleem <abdhalee@linux.vnet.ibm.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The fingerprint is used when replaying jobs causing "yaml_loader" test
not being replayable.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Waiting 120s is not appropriate as the system takes less time for
memory state to change from 'going-online' to 'online' so changed
it to 10s and with freq of 0.2s
Signed-off-by: NAbdul Haleem <abdhalee@linux.vnet.ibm.com>

When this test was initially written, the concept of a shared
directory available across tests did not exist.  Let's optimize the
execution by avoid compilation of the same binary on every single
test.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

The newly W605 warning is caused by incorrect escaped chars, that are
automatically translated to '\\' but future versions should treat it as
SyntaxError.
Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

Signed-off-by: NLukáš Doktor <ldoktor@redhat.com>

* https://github.com/avocado-framework/avocado:
  example/tets/gdbtest.py: do not require trailing newlines
  avocado/utils/external/gdbmi_parser.py: "type" parameter left behind

Since the result of `genio.read_all_lines()` already is a list of all
lines (split by newlines).
Signed-off-by: NCleber Rosa <crosa@redhat.com>

On 3ed6d8ea we missed this one "type" rename.  This was causing
failures when running avocado/utils/gdb.py based code, such as the
example/tests/gdbtest.py tests.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

We are using `;` in the test name, before the Variant ID. That character
is unsafe to be used as a fs path and, as such, need to be replaced for
a `_`.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

As it was done in d2b4edc3, Python 3.4 needs a string to be passed to
json.loads() (and, indirectly, to json.load()).  Different from
d2b4edc3, the content we fetch externally may be able to tell us the
encoding that is used.

Let's use that information, if available, to decode the stream of
bytes into a string that is acceptable to json.loads().
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NCleber Rosa <crosa@redhat.com>

On Python 2 packages.  We were previously relying on the fact that
stevedore requires six too, but that's not the right way to approach a
direct dependency.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

The Python dependencies are already tracked by the python2 or python3
"Requires".  This filters out the python binaries from the RPM
automatic requires/provides scanner.

Before this change, a query for the requirements of the Python 2 package
would reveal:

    $ rpm -qRp fedora-26-noarch/python2-avocado-60.0-1.fc26.noarch.rpm
    /usr/bin/python2
    /usr/bin/python3
    ...

Reference: https://fedoraproject.org/wiki/Packaging:AutoProvidesAndRequiresFiltering#Filtering_provides_and_requires_after_scanningSigned-off-by: NCleber Rosa <crosa@redhat.com>

text_output was removed from test status. Now we have to open the log
file directly.
Signed-off-by: NAmador Pahim <apahim@redhat.com>

So that, if the system version on a given distro is Python 3, the
python3-avocado package will automatically "Provide:" python-avocado.

Reference: https://fedoraproject.org/wiki/Packaging:Python#The_.25python_provide_macroSigned-off-by: NCleber Rosa <crosa@redhat.com>

As it has been done with python-avocado-common in 18d21873,
the requirements should really be in the versioned sub-packages.
Signed-off-by: NCleber Rosa <crosa@redhat.com>

Signed-off-by: NAmador Pahim <apahim@redhat.com>

Into the specific python2-avocado or python3-avocado.  This is the
right way, and not using the python-avocado package that won't get
installed, to make sure the needed configuration files are always
present.
Signed-off-by: NCleber Rosa <crosa@redhat.com>