Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openeuler
avocado
提交
2914ae6e
A
avocado
项目概览
openeuler
/
avocado
通知
0
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
A
avocado
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
2914ae6e
编写于
6月 16, 2017
作者:
C
Cleber Rosa
浏览文件
操作
浏览文件
下载
差异文件
Merge remote-tracking branch 'apahim/docs_review_v2'
Signed-off-by:
N
Cleber Rosa
<
crosa@redhat.com
>
上级
a7275046
5f1bc8c2
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
32 addition
and
0 deletion
+32
-0
docs/source/ContributionGuide.rst
docs/source/ContributionGuide.rst
+32
-0
未找到文件。
docs/source/ContributionGuide.rst
浏览文件 @
2914ae6e
...
...
@@ -242,6 +242,38 @@ approved by your employer) and you grant a full, complete, irrevocable
copyright license to all users and developers of the Avocado project,
present and future, pursuant to the license of the project.
Code Review
-----------
Every single Pull Request in Avocado has to be reviewed by at least one
other developer. All members of the core team have permission to merge
a Pull Request, but there are some conditions that have to be fulfilled
before merging the code:
- Pull Request has to pass the CI tests.
- One 'Approved' code review should be given.
- No explicit disapproval should be present.
Pull Requests failing in CI will not be merged, and reviews won't be
given to them until all the problems are sorted out. If you want help
to debug the issues with the CI, please reach the developers and/or the
community using the available communication channels.
While reviewing the code, one should:
- Verify that the code is sound and clean.
- Run the highest level of selftests (see `make`).
- Verify that code works to its purpose.
- Make sure the commits organization is proper (i.e. code is well
organized in atomic commits, there's no extra/unwanted commits, ...).
- Provide an in-line feedback with explicit questions and/or requests of
improvements.
- Provide a general feedback in the review message, being explicit about
what's expected for the next Pull Request version, if that's the case.
When the Pull Request is approved, the reviewer will merge the code or
wait for someone with merge permission to merge it.
Tests Repositories
==================
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录