!77 代码检视

Merge pull request !77 from 韩雨航/master

external/android-emugl/host/tools/emugen/ApiGen.cpp

@@ -21,6 +21,8 @@
 #include <errno.h>
 #include <sys/types.h>
 
+#include <limits.h>
+
 /* Define this to 1 to enable support for the 'isLarge' variable flag
  * that instructs the encoder to send large data buffers by a direct
  * write through the pipe (i.e. without copying it into a temporary
@@ -286,9 +288,15 @@ int ApiGen::genOpcodes(const std::string &filename)
 }
 int ApiGen::genAttributesTemplate(const std::string &filename )
 {
-    FILE *fp = fopen(filename.c_str(), "wt");
+    const char* untrustPath = filename.c_str();
+    char path[PATH_MAX] = {0};
+    if(realpath(untrustPath, path) == NULL) {
+        return -1;
+    }
+
+    FILE *fp = fopen(path, "wt");
     if (fp == NULL) {
-        perror(filename.c_str());
+        perror(path);
         return -1;
     }
 
@@ -454,9 +462,15 @@ static void writeEncodingChecksumValidatorOnReturn(const char* funcName, FILE* f
 
 int ApiGen::genEncoderImpl(const std::string &filename)
 {
-    FILE *fp = fopen(filename.c_str(), "wt");
+    const char* untrustPath = filename.c_str();
+    char path[PATH_MAX] = {0};
+    if(realpath(untrustPath, path) == NULL) {
+        return -1;
+    }
+
+    FILE *fp = fopen(path, "wt");
     if (fp == NULL) {
-        perror(filename.c_str());
+        perror(path);
         return -1;
     }
 
@@ -1333,6 +1347,8 @@ int ApiGen::readAttributes(const std::string & attribFilename)
             break;
         }
     }
+    
+    fclose(fp);
     return 0;
 }
 

external/android-emugl/shared/OpenglCodecCommon/ChecksumCalculatorThreadInfo.cpp

@@ -59,35 +59,55 @@ ChecksumCalculatorThreadInfo::~ChecksumCalculatorThreadInfo() {
 }
 
 uint32_t ChecksumCalculatorThreadInfo::getVersion() {
-    return getChecksumCalculatorThreadInfo()->m_protocol.getVersion();
+    uint32_t ret = 0;
+    if(getChecksumCalculatorThreadInfo() != nullptr) {
+        ret = getChecksumCalculatorThreadInfo()->m_protocol.getVersion();
+    }
+    return ret;
 }
 
 bool ChecksumCalculatorThreadInfo::setVersion(uint32_t version) {
-    return getChecksumCalculatorThreadInfo()->m_protocol.setVersion(version);
+    bool ret = false;
+    if(getChecksumCalculatorThreadInfo() != nullptr) {
+       ret = getChecksumCalculatorThreadInfo()->m_protocol.setVersion(version);
+    }
+    return ret; 
 }
 
 size_t ChecksumCalculatorThreadInfo::checksumByteSize() {
-    return getChecksumCalculatorThreadInfo()->m_protocol.checksumByteSize();
+    size_t ret = 0;
+    if(getChecksumCalculatorThreadInfo() != nullptr) {
+       ret = getChecksumCalculatorThreadInfo()->m_protocol.checksumByteSize();
+    }
+    return ret;
 }
 
 bool ChecksumCalculatorThreadInfo::writeChecksum(const void* buf,
                                                  size_t bufLen,
                                                  void* outputChecksum,
                                                  size_t outputChecksumLen) {
-    ChecksumCalculator& protocol =
-            getChecksumCalculatorThreadInfo()->m_protocol;
-    protocol.addBuffer(buf, bufLen);
-    return protocol.writeChecksum(outputChecksum, outputChecksumLen);
+    bool ret = false;
+    if(getChecksumCalculatorThreadInfo() != nullptr) {
+        ChecksumCalculator& protocol =
+                    getChecksumCalculatorThreadInfo()->m_protocol;
+        protocol.addBuffer(buf, bufLen);
+        ret =  protocol.writeChecksum(outputChecksum, outputChecksumLen);   
+    }
+    return ret;
 }
 
 bool ChecksumCalculatorThreadInfo::validate(const void* buf,
                                             size_t bufLen,
                                             void* checksum,
                                             size_t checksumLen) {
-    ChecksumCalculator& protocol =
-            getChecksumCalculatorThreadInfo()->m_protocol;
-    protocol.addBuffer(buf, bufLen);
-    return protocol.validate(checksum, checksumLen);
+    bool ret = false;
+    if(getChecksumCalculatorThreadInfo() != nullptr) {
+      ChecksumCalculator& protocol =
+              getChecksumCalculatorThreadInfo()->m_protocol;
+      protocol.addBuffer(buf, bufLen);
+      ret =  protocol.validate(checksum, checksumLen);
+    }
+    return ret;    
 }
 
 void ChecksumCalculatorThreadInfo::validOrDie(const void* buf,

src/anbox/cmds/check_features.h

@@ -29,6 +29,7 @@ namespace cmds {
 class CheckFeatures : public cli::CommandWithFlagsAndAction {
  public:
   CheckFeatures();
+  ~CheckFeatures(){}
 
  private:
   bool sanity_check_for_features();

src/anbox/graphics/emugl/Renderer.cpp

@@ -460,7 +460,11 @@ HandleType Renderer::createWindowSurface(int p_config, int p_width,
     ret = genHandle();
     m_windows[ret] = std::pair<WindowSurfacePtr, HandleType>(win, 0);
     RenderThreadInfo *tinfo = RenderThreadInfo::get();
-    tinfo->m_windowSet.insert(ret);
+    if (tinfo) {
+      tinfo->m_windowSet.insert(ret);
+    }else{
+      ERROR("tinfo == nullptr!!!");
+    }
   }
 
   return ret;