提交 717be173 编写于 作者: J jjg

6868548: remove spurious ';' from after constant pool entries

Reviewed-by: ksrini
上级 dbc30f0b
...@@ -140,7 +140,7 @@ class CodeWriter extends BasicWriter { ...@@ -140,7 +140,7 @@ class CodeWriter extends BasicWriter {
} }
public Void visitConstantPoolRef(Instruction instr, int index, Void p) { public Void visitConstantPoolRef(Instruction instr, int index, Void p) {
print("#" + index + ";"); print("#" + index);
tab(); tab();
print("// "); print("// ");
printConstant(index); printConstant(index);
...@@ -148,7 +148,7 @@ class CodeWriter extends BasicWriter { ...@@ -148,7 +148,7 @@ class CodeWriter extends BasicWriter {
} }
public Void visitConstantPoolRefAndValue(Instruction instr, int index, int value, Void p) { public Void visitConstantPoolRefAndValue(Instruction instr, int index, int value, Void p) {
print("#" + index + ", " + value + ";"); print("#" + index + ", " + value);
tab(); tab();
print("// "); print("// ");
printConstant(index); printConstant(index);
...@@ -170,7 +170,7 @@ class CodeWriter extends BasicWriter { ...@@ -170,7 +170,7 @@ class CodeWriter extends BasicWriter {
print("{ // " + npairs); print("{ // " + npairs);
indent(+1); indent(+1);
for (int i = 0; i < npairs; i++) { for (int i = 0; i < npairs; i++) {
print("\n" + matches[i] + ": " + (pc + offsets[i]) + ";"); print("\n" + matches[i] + ": " + (pc + offsets[i]));
} }
print("\ndefault: " + (pc + default_) + " }"); print("\ndefault: " + (pc + default_) + " }");
indent(-1); indent(-1);
...@@ -182,7 +182,7 @@ class CodeWriter extends BasicWriter { ...@@ -182,7 +182,7 @@ class CodeWriter extends BasicWriter {
print("{ //" + low + " to " + high); print("{ //" + low + " to " + high);
indent(+1); indent(+1);
for (int i = 0; i < offsets.length; i++) { for (int i = 0; i < offsets.length; i++) {
print("\n" + (low + i) + ": " + (pc + offsets[i]) + ";"); print("\n" + (low + i) + ": " + (pc + offsets[i]));
} }
print("\ndefault: " + (pc + default_) + " }"); print("\ndefault: " + (pc + default_) + " }");
indent(-1); indent(-1);
......
...@@ -62,69 +62,69 @@ public class ConstantWriter extends BasicWriter { ...@@ -62,69 +62,69 @@ public class ConstantWriter extends BasicWriter {
protected void writeConstantPool(ConstantPool constant_pool) { protected void writeConstantPool(ConstantPool constant_pool) {
ConstantPool.Visitor<Integer, Void> v = new ConstantPool.Visitor<Integer,Void>() { ConstantPool.Visitor<Integer, Void> v = new ConstantPool.Visitor<Integer,Void>() {
public Integer visitClass(CONSTANT_Class_info info, Void p) { public Integer visitClass(CONSTANT_Class_info info, Void p) {
print("#" + info.name_index + ";"); print("#" + info.name_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitDouble(CONSTANT_Double_info info, Void p) { public Integer visitDouble(CONSTANT_Double_info info, Void p) {
println(stringValue(info) + ";"); println(stringValue(info));
return 2; return 2;
} }
public Integer visitFieldref(CONSTANT_Fieldref_info info, Void p) { public Integer visitFieldref(CONSTANT_Fieldref_info info, Void p) {
print("#" + info.class_index + ".#" + info.name_and_type_index + ";"); print("#" + info.class_index + ".#" + info.name_and_type_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitFloat(CONSTANT_Float_info info, Void p) { public Integer visitFloat(CONSTANT_Float_info info, Void p) {
println(stringValue(info) + ";"); println(stringValue(info));
return 1; return 1;
} }
public Integer visitInteger(CONSTANT_Integer_info info, Void p) { public Integer visitInteger(CONSTANT_Integer_info info, Void p) {
println(stringValue(info) + ";"); println(stringValue(info));
return 1; return 1;
} }
public Integer visitInterfaceMethodref(CONSTANT_InterfaceMethodref_info info, Void p) { public Integer visitInterfaceMethodref(CONSTANT_InterfaceMethodref_info info, Void p) {
print("#" + info.class_index + ".#" + info.name_and_type_index + ";"); print("#" + info.class_index + ".#" + info.name_and_type_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitLong(CONSTANT_Long_info info, Void p) { public Integer visitLong(CONSTANT_Long_info info, Void p) {
println(stringValue(info) + ";"); println(stringValue(info));
return 2; return 2;
} }
public Integer visitNameAndType(CONSTANT_NameAndType_info info, Void p) { public Integer visitNameAndType(CONSTANT_NameAndType_info info, Void p) {
print("#" + info.name_index + ":#" + info.type_index + ";"); print("#" + info.name_index + ":#" + info.type_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitMethodref(CONSTANT_Methodref_info info, Void p) { public Integer visitMethodref(CONSTANT_Methodref_info info, Void p) {
print("#" + info.class_index + ".#" + info.name_and_type_index + ";"); print("#" + info.class_index + ".#" + info.name_and_type_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitString(CONSTANT_String_info info, Void p) { public Integer visitString(CONSTANT_String_info info, Void p) {
print("#" + info.string_index + ";"); print("#" + info.string_index);
tab(); tab();
println("// " + stringValue(info)); println("// " + stringValue(info));
return 1; return 1;
} }
public Integer visitUtf8(CONSTANT_Utf8_info info, Void p) { public Integer visitUtf8(CONSTANT_Utf8_info info, Void p) {
println(stringValue(info) + ";"); println(stringValue(info));
return 1; return 1;
} }
......
...@@ -48,7 +48,7 @@ public class ArrayClone { ...@@ -48,7 +48,7 @@ public class ArrayClone {
System.out.println(out); System.out.println(out);
for (String line: out.split("\n")) { for (String line: out.split("\n")) {
String match = "[ \t]+[0-9]+:[ \t]+invokevirtual[ \t]+#[0-9]+;[ \t]+// Method \"\\[Ljava/lang/String;\".clone:\\(\\)Ljava/lang/Object;"; String match = "[ \t]+[0-9]+:[ \t]+invokevirtual[ \t]+#[0-9]+[ \t]+// Method \"\\[Ljava/lang/String;\".clone:\\(\\)Ljava/lang/Object;";
if (line.matches(match)) if (line.matches(match))
return; return;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册