Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openanolis
dragonwell8_jdk
提交
c9bd342d
D
dragonwell8_jdk
项目概览
openanolis
/
dragonwell8_jdk
通知
4
Star
2
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
D
dragonwell8_jdk
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
c9bd342d
编写于
7月 17, 2009
作者:
V
vinnie
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
6657695: AbstractSaslImpl.logger is a static mutable (findbugs)
Reviewed-by: alanb
上级
c7d207e2
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
52 addition
and
15 deletion
+52
-15
src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.java
.../classes/com/sun/security/sasl/util/AbstractSaslImpl.java
+6
-15
test/com/sun/security/sasl/util/CheckAccess.java
test/com/sun/security/sasl/util/CheckAccess.java
+46
-0
未找到文件。
src/share/classes/com/sun/security/sasl/util/AbstractSaslImpl.java
浏览文件 @
c9bd342d
/*
/*
* Copyright 2000-200
3
Sun Microsystems, Inc. All Rights Reserved.
* Copyright 2000-200
9
Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
*
* This code is free software; you can redistribute it and/or modify it
* This code is free software; you can redistribute it and/or modify it
...
@@ -48,10 +48,6 @@ import sun.misc.HexDumpEncoder;
...
@@ -48,10 +48,6 @@ import sun.misc.HexDumpEncoder;
* @author Rosanna Lee
* @author Rosanna Lee
*/
*/
public
abstract
class
AbstractSaslImpl
{
public
abstract
class
AbstractSaslImpl
{
/**
* Logger for debug messages
*/
protected
static
Logger
logger
;
// set in initLogger(); lazily loads logger
protected
boolean
completed
=
false
;
protected
boolean
completed
=
false
;
protected
boolean
privacy
=
false
;
protected
boolean
privacy
=
false
;
...
@@ -68,7 +64,6 @@ public abstract class AbstractSaslImpl {
...
@@ -68,7 +64,6 @@ public abstract class AbstractSaslImpl {
protected
String
myClassName
;
protected
String
myClassName
;
protected
AbstractSaslImpl
(
Map
props
,
String
className
)
throws
SaslException
{
protected
AbstractSaslImpl
(
Map
props
,
String
className
)
throws
SaslException
{
initLogger
();
myClassName
=
className
;
myClassName
=
className
;
// Parse properties to set desired context options
// Parse properties to set desired context options
...
@@ -325,19 +320,15 @@ public abstract class AbstractSaslImpl {
...
@@ -325,19 +320,15 @@ public abstract class AbstractSaslImpl {
}
}
}
}
/**
* Sets logger field.
*/
private
static
synchronized
void
initLogger
()
{
if
(
logger
==
null
)
{
logger
=
Logger
.
getLogger
(
SASL_LOGGER_NAME
);
}
}
// ---------------- Constants -----------------
// ---------------- Constants -----------------
private
static
final
String
SASL_LOGGER_NAME
=
"javax.security.sasl"
;
private
static
final
String
SASL_LOGGER_NAME
=
"javax.security.sasl"
;
protected
static
final
String
MAX_SEND_BUF
=
"javax.security.sasl.sendmaxbuffer"
;
protected
static
final
String
MAX_SEND_BUF
=
"javax.security.sasl.sendmaxbuffer"
;
/**
* Logger for debug messages
*/
protected
static
final
Logger
logger
=
Logger
.
getLogger
(
SASL_LOGGER_NAME
);
// default 0 (no protection); 1 (integrity only)
// default 0 (no protection); 1 (integrity only)
protected
static
final
byte
NO_PROTECTION
=
(
byte
)
1
;
protected
static
final
byte
NO_PROTECTION
=
(
byte
)
1
;
protected
static
final
byte
INTEGRITY_ONLY_PROTECTION
=
(
byte
)
2
;
protected
static
final
byte
INTEGRITY_ONLY_PROTECTION
=
(
byte
)
2
;
...
...
test/com/sun/security/sasl/util/CheckAccess.java
0 → 100644
浏览文件 @
c9bd342d
/*
* Copyright 2009 Sun Microsystems, Inc. All Rights Reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
* CA 95054 USA or visit www.sun.com if you need additional information or
* have any questions.
*/
/**
* @test
* @bug 6657695
* @summary AbstractSaslImpl.logger is a static mutable (findbugs)
* @author Vincent Ryan
*/
import
java.lang.reflect.*
;
/*
* Check that the 'logger' class member is immutable.
*/
public
class
CheckAccess
{
public
static
final
void
main
(
String
[]
args
)
throws
Exception
{
Class
clazz
=
Class
.
forName
(
"com.sun.security.sasl.util.AbstractSaslImpl"
);
Field
field
=
clazz
.
getDeclaredField
(
"logger"
);
if
(!
Modifier
.
isFinal
(
field
.
getModifiers
()))
{
throw
new
Exception
(
"class member 'logger' must be immutable"
);
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录