Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openanolis
dragonwell8_jdk
提交
a74ecd25
D
dragonwell8_jdk
项目概览
openanolis
/
dragonwell8_jdk
通知
4
Star
2
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
D
dragonwell8_jdk
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
提交
a74ecd25
编写于
6月 11, 2010
作者:
W
weijun
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
6958869: regression: PKIXValidator fails when multiple trust anchors have same dn
Reviewed-by: xuelei, wetmore, mullan
上级
0a5483f4
变更
4
隐藏空白更改
内联
并排
Showing
4 changed file
with
135 addition
and
31 deletion
+135
-31
src/share/classes/sun/security/validator/PKIXValidator.java
src/share/classes/sun/security/validator/PKIXValidator.java
+32
-13
test/sun/security/validator/CertReplace.java
test/sun/security/validator/CertReplace.java
+16
-13
test/sun/security/validator/certreplace.sh
test/sun/security/validator/certreplace.sh
+5
-5
test/sun/security/validator/samedn.sh
test/sun/security/validator/samedn.sh
+82
-0
未找到文件。
src/share/classes/sun/security/validator/PKIXValidator.java
浏览文件 @
a74ecd25
...
@@ -53,7 +53,7 @@ public final class PKIXValidator extends Validator {
...
@@ -53,7 +53,7 @@ public final class PKIXValidator extends Validator {
private
int
certPathLength
=
-
1
;
private
int
certPathLength
=
-
1
;
// needed only for the validator
// needed only for the validator
private
Map
<
X500Principal
,
X509Certificate
>
trustedSubjects
;
private
Map
<
X500Principal
,
List
<
PublicKey
>
>
trustedSubjects
;
private
CertificateFactory
factory
;
private
CertificateFactory
factory
;
private
boolean
plugin
=
false
;
private
boolean
plugin
=
false
;
...
@@ -95,9 +95,17 @@ public final class PKIXValidator extends Validator {
...
@@ -95,9 +95,17 @@ public final class PKIXValidator extends Validator {
if
(
TRY_VALIDATOR
==
false
)
{
if
(
TRY_VALIDATOR
==
false
)
{
return
;
return
;
}
}
trustedSubjects
=
new
HashMap
<
X500Principal
,
X509Certificate
>();
trustedSubjects
=
new
HashMap
<
X500Principal
,
List
<
PublicKey
>
>();
for
(
X509Certificate
cert
:
trustedCerts
)
{
for
(
X509Certificate
cert
:
trustedCerts
)
{
trustedSubjects
.
put
(
cert
.
getSubjectX500Principal
(),
cert
);
X500Principal
dn
=
cert
.
getSubjectX500Principal
();
List
<
PublicKey
>
keys
;
if
(
trustedSubjects
.
containsKey
(
dn
))
{
keys
=
trustedSubjects
.
get
(
dn
);
}
else
{
keys
=
new
ArrayList
<
PublicKey
>();
trustedSubjects
.
put
(
dn
,
keys
);
}
keys
.
add
(
cert
.
getPublicKey
());
}
}
try
{
try
{
factory
=
CertificateFactory
.
getInstance
(
"X.509"
);
factory
=
CertificateFactory
.
getInstance
(
"X.509"
);
...
@@ -161,13 +169,21 @@ public final class PKIXValidator extends Validator {
...
@@ -161,13 +169,21 @@ public final class PKIXValidator extends Validator {
// chain is not ordered correctly, call builder instead
// chain is not ordered correctly, call builder instead
return
doBuild
(
chain
,
otherCerts
);
return
doBuild
(
chain
,
otherCerts
);
}
}
if
(
trustedSubjects
.
containsKey
(
dn
)
&&
trustedSubjects
.
get
(
dn
).
getPublicKey
()
// Check if chain[i] is already trusted. It may be inside
.
equals
(
cert
.
getPublicKey
()))
{
// trustedCerts, or has the same dn and public key as a cert
// inside trustedCerts. The latter happens when a CA has
// updated its cert with a stronger signature algorithm in JRE
// but the weak one is still in circulation.
if
(
trustedCerts
.
contains
(
cert
)
||
// trusted cert
(
trustedSubjects
.
containsKey
(
dn
)
&&
// replacing ...
trustedSubjects
.
get
(
dn
).
contains
(
// ... weak cert
cert
.
getPublicKey
())))
{
if
(
i
==
0
)
{
if
(
i
==
0
)
{
return
new
X509Certificate
[]
{
chain
[
0
]};
return
new
X509Certificate
[]
{
chain
[
0
]};
}
}
// Remove and call validator
// Remove and call validator
on partial chain [0 .. i-1]
X509Certificate
[]
newChain
=
new
X509Certificate
[
i
];
X509Certificate
[]
newChain
=
new
X509Certificate
[
i
];
System
.
arraycopy
(
chain
,
0
,
newChain
,
0
,
i
);
System
.
arraycopy
(
chain
,
0
,
newChain
,
0
,
i
);
return
doValidate
(
newChain
);
return
doValidate
(
newChain
);
...
@@ -217,14 +233,17 @@ public final class PKIXValidator extends Validator {
...
@@ -217,14 +233,17 @@ public final class PKIXValidator extends Validator {
return
doBuild
(
chain
,
otherCerts
);
return
doBuild
(
chain
,
otherCerts
);
}
}
private
boolean
isSignatureValid
(
X509Certificate
is
s
,
X509Certificate
sub
)
{
private
boolean
isSignatureValid
(
List
<
PublicKey
>
key
s
,
X509Certificate
sub
)
{
if
(
plugin
)
{
if
(
plugin
)
{
try
{
for
(
PublicKey
key:
keys
)
{
sub
.
verify
(
iss
.
getPublicKey
());
try
{
}
catch
(
Exception
ex
)
{
sub
.
verify
(
key
);
return
false
;
return
true
;
}
catch
(
Exception
ex
)
{
continue
;
}
}
}
return
tru
e
;
return
fals
e
;
}
}
return
true
;
// only check if PLUGIN is set
return
true
;
// only check if PLUGIN is set
}
}
...
...
test/sun/security/validator/CertReplace.java
浏览文件 @
a74ecd25
/*
/*
* Copyright
2010 Sun Microsystems, Inc. All Rights R
eserved.
* Copyright
(c) 2010, Oracle and/or its affiliates. All rights r
eserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
*
* This code is free software; you can redistribute it and/or modify it
* This code is free software; you can redistribute it and/or modify it
...
@@ -16,9 +16,9 @@
...
@@ -16,9 +16,9 @@
* 2 along with this work; if not, write to the Free Software Foundation,
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
*
* Please contact
Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
* Please contact
Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
*
CA 95054 USA or visit www.sun.com if you need additional information or
*
or visit www.oracle.com if you need additional information or have any
*
have any
questions.
* questions.
*/
*/
/*
/*
...
@@ -37,25 +37,28 @@ import sun.security.validator.Validator;
...
@@ -37,25 +37,28 @@ import sun.security.validator.Validator;
public
class
CertReplace
{
public
class
CertReplace
{
private
final
static
String
cacerts
=
"certreplace.jks"
;
/**
private
final
static
String
certs
=
"certreplace.certs"
;
* @param args {cacerts keystore, cert chain}
*/
public
static
void
main
(
String
[]
args
)
throws
Exception
{
public
static
void
main
(
String
[]
args
)
throws
Exception
{
KeyStore
ks
=
KeyStore
.
getInstance
(
"JKS"
);
KeyStore
ks
=
KeyStore
.
getInstance
(
"JKS"
);
ks
.
load
(
new
FileInputStream
(
cacerts
),
"changeit"
.
toCharArray
());
ks
.
load
(
new
FileInputStream
(
args
[
0
]
),
"changeit"
.
toCharArray
());
Validator
v
=
Validator
.
getInstance
Validator
v
=
Validator
.
getInstance
(
Validator
.
TYPE_PKIX
,
Validator
.
VAR_GENERIC
,
ks
);
(
Validator
.
TYPE_PKIX
,
Validator
.
VAR_GENERIC
,
ks
);
X509Certificate
[]
chain
=
createPath
();
X509Certificate
[]
chain
=
createPath
(
args
[
1
]);
System
.
out
.
println
(
Arrays
.
toString
(
v
.
validate
(
chain
)));
System
.
out
.
println
(
"Chain: "
);
for
(
X509Certificate
c:
v
.
validate
(
chain
))
{
System
.
out
.
println
(
" "
+
c
.
getSubjectX500Principal
()
+
" issued by "
+
c
.
getIssuerX500Principal
());
}
}
}
public
static
X509Certificate
[]
createPath
()
throws
Exception
{
public
static
X509Certificate
[]
createPath
(
String
chain
)
throws
Exception
{
CertificateFactory
cf
=
CertificateFactory
.
getInstance
(
"X.509"
);
CertificateFactory
cf
=
CertificateFactory
.
getInstance
(
"X.509"
);
List
list
=
new
ArrayList
();
List
list
=
new
ArrayList
();
for
(
Certificate
c:
cf
.
generateCertificates
(
for
(
Certificate
c:
cf
.
generateCertificates
(
new
FileInputStream
(
c
erts
)))
{
new
FileInputStream
(
c
hain
)))
{
list
.
add
((
X509Certificate
)
c
);
list
.
add
((
X509Certificate
)
c
);
}
}
return
(
X509Certificate
[])
list
.
toArray
(
new
X509Certificate
[
0
]);
return
(
X509Certificate
[])
list
.
toArray
(
new
X509Certificate
[
0
]);
...
...
test/sun/security/validator/certreplace.sh
浏览文件 @
a74ecd25
#
#
# Copyright
2010 Sun Microsystems, Inc. All Rights R
eserved.
# Copyright
(c) 2010, Oracle and/or its affiliates. All rights r
eserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
#
# This code is free software; you can redistribute it and/or modify it
# This code is free software; you can redistribute it and/or modify it
...
@@ -16,9 +16,9 @@
...
@@ -16,9 +16,9 @@
# 2 along with this work; if not, write to the Free Software Foundation,
# 2 along with this work; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
#
#
# Please contact
Sun Microsystems, Inc., 4150 Network Circle, Santa Clara,
# Please contact
Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
#
CA 95054 USA or visit www.sun.com if you need additional information or
#
or visit www.oracle.com if you need additional information or have any
#
have any
questions.
# questions.
#
#
# @test
# @test
...
@@ -82,4 +82,4 @@ $KT -delete -alias user
...
@@ -82,4 +82,4 @@ $KT -delete -alias user
# 5. Build and run test
# 5. Build and run test
$JAVAC
-d
.
${
TESTSRC
}${
FS
}
CertReplace.java
$JAVAC
-d
.
${
TESTSRC
}${
FS
}
CertReplace.java
$JAVA
CertReplace
$JAVA
CertReplace
certreplace.jks certreplace.certs
test/sun/security/validator/samedn.sh
0 → 100644
浏览文件 @
a74ecd25
#
# Copyright (c) 2010, Oracle and/or its affiliates. All rights reserved.
# DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
#
# This code is free software; you can redistribute it and/or modify it
# under the terms of the GNU General Public License version 2 only, as
# published by the Free Software Foundation.
#
# This code is distributed in the hope that it will be useful, but WITHOUT
# ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
# FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
# version 2 for more details (a copy is included in the LICENSE file that
# accompanied this code).
#
# You should have received a copy of the GNU General Public License version
# 2 along with this work; if not, write to the Free Software Foundation,
# Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
#
# Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
# or visit www.oracle.com if you need additional information or have any
# questions.
#
# @test
# @bug 6958869
# @summary regression: PKIXValidator fails when multiple trust anchors
# have same dn
#
if
[
"
${
TESTSRC
}
"
=
""
]
;
then
TESTSRC
=
"."
fi
if
[
"
${
TESTJAVA
}
"
=
""
]
;
then
JAVAC_CMD
=
`
which javac
`
TESTJAVA
=
`
dirname
$JAVAC_CMD
`
/..
fi
# set platform-dependent variables
OS
=
`
uname
-s
`
case
"
$OS
"
in
Windows_
*
)
FS
=
"
\\
"
;;
*
)
FS
=
"/"
;;
esac
KT
=
"
$TESTJAVA
${
FS
}
bin
${
FS
}
keytool -storepass changeit
\
-keypass changeit -keystore samedn.jks"
JAVAC
=
$TESTJAVA
${
FS
}
bin
${
FS
}
javac
JAVA
=
$TESTJAVA
${
FS
}
bin
${
FS
}
java
rm
-rf
samedn.jks 2> /dev/null
# 1. Generate 3 aliases in a keystore: ca1, ca2, user. The CAs' startdate
# is set to one year ago so that they are expired now
$KT
-genkeypair
-alias
ca1
-dname
CN
=
CA
-keyalg
rsa
-sigalg
md5withrsa
-ext
bc
-startdate
-1y
$KT
-genkeypair
-alias
ca2
-dname
CN
=
CA
-keyalg
rsa
-sigalg
sha1withrsa
-ext
bc
-startdate
-1y
$KT
-genkeypair
-alias
user
-dname
CN
=
User
-keyalg
rsa
# 2. Signing: ca -> user
$KT
-certreq
-alias
user |
$KT
-gencert
-rfc
-alias
ca1
>
samedn1.certs
$KT
-certreq
-alias
user |
$KT
-gencert
-rfc
-alias
ca2
>
samedn2.certs
# 3. Append the ca file
$KT
-export
-rfc
-alias
ca1
>>
samedn1.certs
$KT
-export
-rfc
-alias
ca2
>>
samedn2.certs
# 4. Remove user for cacerts
$KT
-delete
-alias
user
# 5. Build and run test. Make sure the CA certs are ignored for validity check.
# Check both, one of them might be dropped out of map in old codes.
$JAVAC
-d
.
${
TESTSRC
}${
FS
}
CertReplace.java
$JAVA
CertReplace samedn.jks samedn1.certs
||
exit
1
$JAVA
CertReplace samedn.jks samedn2.certs
||
exit
2
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录