8010814: More buffers are stored or returned without cloning

Reviewed-by: lancea

src/share/classes/com/sun/jndi/ldap/BerDecoder.java

@@ -42,7 +42,7 @@ public final class BerDecoder extends Ber {
      */
     public BerDecoder(byte buf[], int offset, int bufsize) {
 
-        this.buf = buf;
+        this.buf = buf;         // shared buffer, be careful to use this class
         this.bufsize = bufsize;
         this.origOffset = offset;
 

src/share/classes/com/sun/jndi/ldap/BerEncoder.java

@@ -99,7 +99,7 @@ public final class BerEncoder extends Ber {
         if (curSeqIndex != 0) {
             throw new IllegalStateException("BER encode error: Unbalanced SEQUENCEs.");
         }
-        return buf;
+        return buf;     // shared buffer, be careful to use this method.
     }
 
     /**

src/share/classes/com/sun/jndi/ldap/ext/StartTlsResponseImpl.java

@@ -134,7 +134,9 @@ final public class StartTlsResponseImpl extends StartTlsResponse {
      * @see #negotiate
      */
     public void setEnabledCipherSuites(String[] suites) {
-        this.suites = suites;
+        // The impl does accept null suites, although the spec requires
+        // a non-null list.
+        this.suites = suites == null ? null : suites.clone();
     }
 
     /**