Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openanolis
dragonwell8_jdk
提交
878b8818
D
dragonwell8_jdk
项目概览
openanolis
/
dragonwell8_jdk
通知
4
Star
2
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
D
dragonwell8_jdk
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
提交
878b8818
编写于
2月 27, 2014
作者:
I
igerasim
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
6853696: (ref) ReferenceQueue.remove(timeout) may return null even if timeout has not expired
Reviewed-by: mchung, mduigou, rriggs
上级
0c65fe22
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
107 addition
and
1 deletion
+107
-1
src/share/classes/java/lang/ref/ReferenceQueue.java
src/share/classes/java/lang/ref/ReferenceQueue.java
+7
-1
test/java/lang/ref/EarlyTimeout.java
test/java/lang/ref/EarlyTimeout.java
+100
-0
未找到文件。
src/share/classes/java/lang/ref/ReferenceQueue.java
浏览文件 @
878b8818
...
...
@@ -138,11 +138,17 @@ public class ReferenceQueue<T> {
synchronized
(
lock
)
{
Reference
<?
extends
T
>
r
=
reallyPoll
();
if
(
r
!=
null
)
return
r
;
long
start
=
(
timeout
==
0
)
?
0
:
System
.
nanoTime
();
for
(;;)
{
lock
.
wait
(
timeout
);
r
=
reallyPoll
();
if
(
r
!=
null
)
return
r
;
if
(
timeout
!=
0
)
return
null
;
if
(
timeout
!=
0
)
{
long
end
=
System
.
nanoTime
();
timeout
-=
(
end
-
start
)
/
1000_000
;
if
(
timeout
<=
0
)
return
null
;
start
=
end
;
}
}
}
}
...
...
test/java/lang/ref/EarlyTimeout.java
0 → 100644
浏览文件 @
878b8818
/*
* Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
/* @test
* @bug 6853696
* @summary ReferenceQueue#remove(timeout) should not return null before
* timeout is elapsed
*/
import
java.lang.InterruptedException
;
import
java.lang.System
;
import
java.lang.ref.Reference
;
import
java.lang.ref.ReferenceQueue
;
import
java.lang.ref.WeakReference
;
import
java.util.concurrent.CountDownLatch
;
/**
* In order to demonstrate the issue we make several threads (two appears to be sufficient)
* to block in ReferenceQueue#remove(timeout) at the same time.
* Then, we force a reference to be enqueued by setting its referent to null and calling System.gs().
* One of the threads gets the reference returned from the remove().
* The other threads get null:
* 1) with bug: this may happen before the specified timeout is elapsed,
* 2) without bug: this can only happen after the timeout is fully elapsed.
*/
public
class
EarlyTimeout
extends
Thread
{
static
final
int
THREADS_COUNT
=
2
;
static
final
int
TIMEOUT
=
1000
;
static
Object
referent
=
new
Object
();
static
final
ReferenceQueue
<
Object
>
queue
=
new
ReferenceQueue
<
Object
>();
static
final
WeakReference
<
Object
>
weakReference
=
new
WeakReference
<
Object
>(
referent
,
queue
);
static
final
CountDownLatch
startedSignal
=
new
CountDownLatch
(
THREADS_COUNT
);
long
actual
;
Reference
<?>
reference
;
public
static
void
main
(
String
[]
args
)
throws
Exception
{
EarlyTimeout
[]
threads
=
new
EarlyTimeout
[
THREADS_COUNT
];
for
(
int
i
=
0
;
i
<
THREADS_COUNT
;
++
i
)
{
threads
[
i
]
=
new
EarlyTimeout
();
threads
[
i
].
start
();
}
startedSignal
.
await
();
referent
=
null
;
System
.
gc
();
for
(
EarlyTimeout
thread
:
threads
)
{
thread
.
join
();
}
if
(
weakReference
.
get
()
!=
null
)
{
throw
new
RuntimeException
(
"weakReference was not cleared"
);
}
int
nonNullRefCount
=
0
;
for
(
EarlyTimeout
thread
:
threads
)
{
if
(
thread
.
reference
==
null
&&
thread
.
actual
<
TIMEOUT
)
{
throw
new
RuntimeException
(
"elapsed time "
+
thread
.
actual
+
" is less than timeout "
+
TIMEOUT
);
}
if
(
thread
.
reference
!=
null
&&
thread
.
reference
==
weakReference
)
{
nonNullRefCount
++;
}
}
if
(
nonNullRefCount
!=
1
)
{
throw
new
RuntimeException
(
"more than one references were removed from queue"
);
}
}
public
void
run
()
{
try
{
startedSignal
.
countDown
();
long
start
=
System
.
currentTimeMillis
();
reference
=
queue
.
remove
(
TIMEOUT
);
actual
=
System
.
currentTimeMillis
()
-
start
;
}
catch
(
InterruptedException
ex
)
{
throw
new
RuntimeException
(
ex
);
}
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录