Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
openanolis
dragonwell8_jdk
提交
5c003d46
D
dragonwell8_jdk
项目概览
openanolis
/
dragonwell8_jdk
通知
4
Star
2
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
D
dragonwell8_jdk
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
提交
5c003d46
编写于
1月 21, 2015
作者:
D
dl
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
8068432: Inconsistent exception handling in CompletableFuture.thenCompose
Reviewed-by: psandoz, chegar, martin
上级
575aae29
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
121 addition
and
1 deletion
+121
-1
src/share/classes/java/util/concurrent/CompletableFuture.java
...share/classes/java/util/concurrent/CompletableFuture.java
+9
-1
test/java/util/concurrent/CompletableFuture/ThenComposeExceptionTest.java
...oncurrent/CompletableFuture/ThenComposeExceptionTest.java
+112
-0
未找到文件。
src/share/classes/java/util/concurrent/CompletableFuture.java
浏览文件 @
5c003d46
...
...
@@ -978,7 +978,15 @@ public class CompletableFuture<T> implements Future<T>, CompletionStage<T> {
}
try
{
@SuppressWarnings
(
"unchecked"
)
T
t
=
(
T
)
r
;
return
f
.
apply
(
t
).
toCompletableFuture
();
CompletableFuture
<
V
>
g
=
f
.
apply
(
t
).
toCompletableFuture
();
Object
s
=
g
.
result
;
if
(
s
!=
null
)
return
new
CompletableFuture
<
V
>(
encodeRelay
(
s
));
CompletableFuture
<
V
>
d
=
new
CompletableFuture
<
V
>();
UniRelay
<
V
>
copy
=
new
UniRelay
<
V
>(
d
,
g
);
g
.
push
(
copy
);
copy
.
tryFire
(
SYNC
);
return
d
;
}
catch
(
Throwable
ex
)
{
return
new
CompletableFuture
<
V
>(
encodeThrowable
(
ex
));
}
...
...
test/java/util/concurrent/CompletableFuture/ThenComposeExceptionTest.java
0 → 100644
浏览文件 @
5c003d46
/*
* Copyright (c) 2015, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
*
* This code is free software; you can redistribute it and/or modify it
* under the terms of the GNU General Public License version 2 only, as
* published by the Free Software Foundation.
*
* This code is distributed in the hope that it will be useful, but WITHOUT
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
* version 2 for more details (a copy is included in the LICENSE file that
* accompanied this code).
*
* You should have received a copy of the GNU General Public License version
* 2 along with this work; if not, write to the Free Software Foundation,
* Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
*
* Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA
* or visit www.oracle.com if you need additional information or have any
* questions.
*/
import
org.testng.Assert
;
import
org.testng.annotations.DataProvider
;
import
org.testng.annotations.Test
;
import
java.util.ArrayList
;
import
java.util.List
;
import
java.util.concurrent.CompletableFuture
;
import
java.util.concurrent.CompletionException
;
import
java.util.concurrent.atomic.AtomicReference
;
import
java.util.function.BiFunction
;
import
java.util.function.Consumer
;
/**
* @test
* @bug 8068432
* @run testng ThenComposeExceptionTest
* @summary Test that CompletableFuture.thenCompose works correctly if the
* composing future completes exceptionally
*/
@Test
public
class
ThenComposeExceptionTest
{
static
final
BiFunction
<
CompletableFuture
<
String
>,
CompletableFuture
<
String
>,
CompletableFuture
<
String
>>
THEN_COMPOSE
=
(
f
,
fe
)
->
f
.
thenCompose
(
s
->
fe
);
static
final
BiFunction
<
CompletableFuture
<
String
>,
CompletableFuture
<
String
>,
CompletableFuture
<
String
>>
THEN_COMPOSE_ASYNC
=
(
f
,
fe
)
->
f
.
thenComposeAsync
(
s
->
fe
);
static
final
Consumer
<
CompletableFuture
<
String
>>
COMPLETE_EXCEPTIONALLY
=
f
->
f
.
completeExceptionally
(
new
RuntimeException
());
static
final
Consumer
<
CompletableFuture
<
String
>>
NOP
=
f
->
{
};
static
Object
[][]
actionsDataProvider
;
@DataProvider
(
name
=
"actions"
)
static
Object
[][]
actionsDataProvider
()
{
if
(
actionsDataProvider
!=
null
)
{
return
actionsDataProvider
;
}
List
<
Object
[]>
data
=
new
ArrayList
<>();
data
.
add
(
new
Object
[]{
"thenCompose and completeExceptionally"
,
NOP
,
THEN_COMPOSE
,
COMPLETE_EXCEPTIONALLY
});
data
.
add
(
new
Object
[]{
"thenComposeAsync and completeExceptionally"
,
NOP
,
THEN_COMPOSE_ASYNC
,
COMPLETE_EXCEPTIONALLY
});
data
.
add
(
new
Object
[]{
"completeExceptionally and thenCompose"
,
COMPLETE_EXCEPTIONALLY
,
THEN_COMPOSE
,
NOP
});
data
.
add
(
new
Object
[]{
"completeExceptionally and thenComposeAsync"
,
COMPLETE_EXCEPTIONALLY
,
THEN_COMPOSE_ASYNC
,
NOP
});
return
actionsDataProvider
=
data
.
toArray
(
new
Object
[
0
][]);
}
@Test
(
dataProvider
=
"actions"
)
public
void
testThenCompose
(
String
description
,
Consumer
<
CompletableFuture
<
String
>>
beforeAction
,
BiFunction
<
CompletableFuture
<
String
>,
CompletableFuture
<
String
>,
CompletableFuture
<
String
>>
composeFunction
,
Consumer
<
CompletableFuture
<
String
>>
afterAction
)
throws
Exception
{
CompletableFuture
<
String
>
f
=
new
CompletableFuture
<>();
CompletableFuture
<
String
>
fe
=
new
CompletableFuture
<>();
// Ensure pre-composed stage is completed to trigger
// processing the composing future
f
.
complete
(
""
);
beforeAction
.
accept
(
fe
);
CompletableFuture
<
String
>
f_thenCompose
=
composeFunction
.
apply
(
f
,
fe
);
Assert
.
assertNotSame
(
f_thenCompose
,
fe
,
"Composed CompletableFuture returned directly"
);
AtomicReference
<
Throwable
>
eOnWhenComplete
=
new
AtomicReference
<>();
f_thenCompose
.
whenComplete
((
r
,
e
)
->
eOnWhenComplete
.
set
(
e
));
afterAction
.
accept
(
fe
);
Throwable
eOnJoined
=
null
;
try
{
f_thenCompose
.
join
();
}
catch
(
Throwable
t
)
{
eOnJoined
=
t
;
}
Assert
.
assertTrue
(
eOnWhenComplete
.
get
()
instanceof
CompletionException
,
"Incorrect exception reported on whenComplete"
);
Assert
.
assertTrue
(
eOnJoined
instanceof
CompletionException
,
"Incorrect exception reported when joined"
);
}
}
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录