提交 a30e9e27 编写于 作者: B brutisso

7130334: G1: Change comments and error messages that refer to CMS in g1/concurrentMark.cpp/hpp

Summary: Removed references to CMS in the concurrentMark.cpp/hpp files.
Reviewed-by: tonyp, jmasa, johnc
上级 55a1b16e
...@@ -42,8 +42,7 @@ ...@@ -42,8 +42,7 @@
#include "runtime/handles.inline.hpp" #include "runtime/handles.inline.hpp"
#include "runtime/java.hpp" #include "runtime/java.hpp"
// // Concurrent marking bit map wrapper
// CMS Bit Map Wrapper
CMBitMapRO::CMBitMapRO(ReservedSpace rs, int shifter) : CMBitMapRO::CMBitMapRO(ReservedSpace rs, int shifter) :
_bm((uintptr_t*)NULL,0), _bm((uintptr_t*)NULL,0),
...@@ -53,13 +52,13 @@ CMBitMapRO::CMBitMapRO(ReservedSpace rs, int shifter) : ...@@ -53,13 +52,13 @@ CMBitMapRO::CMBitMapRO(ReservedSpace rs, int shifter) :
ReservedSpace brs(ReservedSpace::allocation_align_size_up( ReservedSpace brs(ReservedSpace::allocation_align_size_up(
(_bmWordSize >> (_shifter + LogBitsPerByte)) + 1)); (_bmWordSize >> (_shifter + LogBitsPerByte)) + 1));
guarantee(brs.is_reserved(), "couldn't allocate CMS bit map"); guarantee(brs.is_reserved(), "couldn't allocate concurrent marking bit map");
// For now we'll just commit all of the bit map up fromt. // For now we'll just commit all of the bit map up fromt.
// Later on we'll try to be more parsimonious with swap. // Later on we'll try to be more parsimonious with swap.
guarantee(_virtual_space.initialize(brs, brs.size()), guarantee(_virtual_space.initialize(brs, brs.size()),
"couldn't reseve backing store for CMS bit map"); "couldn't reseve backing store for concurrent marking bit map");
assert(_virtual_space.committed_size() == brs.size(), assert(_virtual_space.committed_size() == brs.size(),
"didn't reserve backing store for all of CMS bit map?"); "didn't reserve backing store for all of concurrent marking bit map?");
_bm.set_map((uintptr_t*)_virtual_space.low()); _bm.set_map((uintptr_t*)_virtual_space.low());
assert(_virtual_space.committed_size() << (_shifter + LogBitsPerByte) >= assert(_virtual_space.committed_size() << (_shifter + LogBitsPerByte) >=
_bmWordSize, "inconsistency in bit map sizing"); _bmWordSize, "inconsistency in bit map sizing");
...@@ -420,8 +419,6 @@ bool CMMarkStack::drain(OopClosureClass* cl, CMBitMap* bm, bool yield_after) { ...@@ -420,8 +419,6 @@ bool CMMarkStack::drain(OopClosureClass* cl, CMBitMap* bm, bool yield_after) {
assert(newOop->is_oop(), "Expected an oop"); assert(newOop->is_oop(), "Expected an oop");
assert(bm == NULL || bm->isMarked((HeapWord*)newOop), assert(bm == NULL || bm->isMarked((HeapWord*)newOop),
"only grey objects on this stack"); "only grey objects on this stack");
// iterate over the oops in this oop, marking and pushing
// the ones in CMS generation.
newOop->oop_iterate(cl); newOop->oop_iterate(cl);
if (yield_after && _cm->do_yield_check()) { if (yield_after && _cm->do_yield_check()) {
res = false; res = false;
...@@ -739,11 +736,6 @@ ConcurrentMark::~ConcurrentMark() { ...@@ -739,11 +736,6 @@ ConcurrentMark::~ConcurrentMark() {
ShouldNotReachHere(); ShouldNotReachHere();
} }
// This closure is used to mark refs into the g1 generation
// from external roots in the CMS bit map.
// Called at the first checkpoint.
//
void ConcurrentMark::clearNextBitmap() { void ConcurrentMark::clearNextBitmap() {
G1CollectedHeap* g1h = G1CollectedHeap::heap(); G1CollectedHeap* g1h = G1CollectedHeap::heap();
G1CollectorPolicy* g1p = g1h->g1_policy(); G1CollectorPolicy* g1p = g1h->g1_policy();
...@@ -3401,13 +3393,6 @@ void ConcurrentMark::print_worker_threads_on(outputStream* st) const { ...@@ -3401,13 +3393,6 @@ void ConcurrentMark::print_worker_threads_on(outputStream* st) const {
_parallel_workers->print_worker_threads_on(st); _parallel_workers->print_worker_threads_on(st);
} }
// Closures
// XXX: there seems to be a lot of code duplication here;
// should refactor and consolidate the shared code.
// This closure is used to mark refs into the CMS generation in
// the CMS bit map. Called at the first checkpoint.
// We take a break if someone is trying to stop the world. // We take a break if someone is trying to stop the world.
bool ConcurrentMark::do_yield_check(uint worker_id) { bool ConcurrentMark::do_yield_check(uint worker_id) {
if (should_yield()) { if (should_yield()) {
......
...@@ -386,7 +386,7 @@ protected: ...@@ -386,7 +386,7 @@ protected:
FreeRegionList _cleanup_list; FreeRegionList _cleanup_list;
// CMS marking support structures // Concurrent marking support structures
CMBitMap _markBitMap1; CMBitMap _markBitMap1;
CMBitMap _markBitMap2; CMBitMap _markBitMap2;
CMBitMapRO* _prevMarkBitMap; // completed mark bitmap CMBitMapRO* _prevMarkBitMap; // completed mark bitmap
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册