提交 9c7bd3d2 编写于 作者: T tonyp

6864886: G1: rename -XX parameters related to update buffers

Summary: renaming a couple of update buffer-related parameters to make them more understandable and consistent.
Reviewed-by: iveresov, ysr
上级 e2af5521
...@@ -104,17 +104,17 @@ void ConcurrentG1RefineThread::run() { ...@@ -104,17 +104,17 @@ void ConcurrentG1RefineThread::run() {
double start_vtime_sec; // only used when G1SmoothConcRefine is on double start_vtime_sec; // only used when G1SmoothConcRefine is on
int prev_buffer_num; // only used when G1SmoothConcRefine is on int prev_buffer_num; // only used when G1SmoothConcRefine is on
// This thread activation threshold // This thread activation threshold
int threshold = DCQBarrierProcessCompletedThreshold * _worker_id; int threshold = G1UpdateBufferQueueProcessingThreshold * _worker_id;
// Next thread activation threshold // Next thread activation threshold
int next_threshold = threshold + DCQBarrierProcessCompletedThreshold; int next_threshold = threshold + G1UpdateBufferQueueProcessingThreshold;
int deactivation_threshold = MAX2<int>(threshold - DCQBarrierProcessCompletedThreshold / 2, 0); int deactivation_threshold = MAX2<int>(threshold - G1UpdateBufferQueueProcessingThreshold / 2, 0);
if (G1SmoothConcRefine) { if (G1SmoothConcRefine) {
lower_limit = 0; lower_limit = 0;
start_vtime_sec = os::elapsedVTime(); start_vtime_sec = os::elapsedVTime();
prev_buffer_num = (int) dcqs.completed_buffers_num(); prev_buffer_num = (int) dcqs.completed_buffers_num();
} else { } else {
lower_limit = DCQBarrierProcessCompletedThreshold / 4; // For now. lower_limit = G1UpdateBufferQueueProcessingThreshold / 4; // For now.
} }
while (dcqs.apply_closure_to_completed_buffer(_worker_id + _worker_id_offset, lower_limit)) { while (dcqs.apply_closure_to_completed_buffer(_worker_id + _worker_id_offset, lower_limit)) {
double end_vtime_sec; double end_vtime_sec;
......
...@@ -80,8 +80,8 @@ void DirtyCardQueueSet::initialize(Monitor* cbl_mon, Mutex* fl_lock, ...@@ -80,8 +80,8 @@ void DirtyCardQueueSet::initialize(Monitor* cbl_mon, Mutex* fl_lock,
int max_completed_queue, int max_completed_queue,
Mutex* lock, PtrQueueSet* fl_owner) { Mutex* lock, PtrQueueSet* fl_owner) {
PtrQueueSet::initialize(cbl_mon, fl_lock, max_completed_queue, fl_owner); PtrQueueSet::initialize(cbl_mon, fl_lock, max_completed_queue, fl_owner);
set_buffer_size(DCQBarrierQueueBufferSize); set_buffer_size(G1UpdateBufferSize);
set_process_completed_threshold(DCQBarrierProcessCompletedThreshold); set_process_completed_threshold(G1UpdateBufferQueueProcessingThreshold);
_shared_dirty_card_queue.set_lock(lock); _shared_dirty_card_queue.set_lock(lock);
_free_ids = new FreeIdSet((int) num_par_ids(), _cbl_mon); _free_ids = new FreeIdSet((int) num_par_ids(), _cbl_mon);
......
...@@ -1591,7 +1591,7 @@ jint G1CollectedHeap::initialize() { ...@@ -1591,7 +1591,7 @@ jint G1CollectedHeap::initialize() {
JavaThread::dirty_card_queue_set().initialize(DirtyCardQ_CBL_mon, JavaThread::dirty_card_queue_set().initialize(DirtyCardQ_CBL_mon,
DirtyCardQ_FL_lock, DirtyCardQ_FL_lock,
G1DirtyCardQueueMax, G1UpdateBufferQueueMaxLength,
Shared_DirtyCardQ_lock); Shared_DirtyCardQ_lock);
if (G1DeferredRSUpdate) { if (G1DeferredRSUpdate) {
......
...@@ -167,9 +167,16 @@ ...@@ -167,9 +167,16 @@
develop(bool, G1DisablePostBarrier, false, \ develop(bool, G1DisablePostBarrier, false, \
"Disable generation of post-barrier (i.e., RS barrier) ") \ "Disable generation of post-barrier (i.e., RS barrier) ") \
\ \
product(intx, G1DirtyCardQueueMax, 30, \ product(intx, G1UpdateBufferSize, 256, \
"Maximum number of completed RS buffers before mutator threads " \ "Size of an update buffer") \
"start processing them.") \ \
product(intx, G1UpdateBufferQueueProcessingThreshold, 5, \
"Number of enqueued update buffers that will " \
"trigger concurrent processing") \
\
product(intx, G1UpdateBufferQueueMaxLength, 30, \
"Maximum number of enqueued update buffers before mutator " \
"threads start processing new ones instead of enqueueing them") \
\ \
develop(intx, G1ConcRSLogCacheSize, 10, \ develop(intx, G1ConcRSLogCacheSize, 10, \
"Log base 2 of the length of conc RS hot-card cache.") \ "Log base 2 of the length of conc RS hot-card cache.") \
......
...@@ -2924,12 +2924,6 @@ class CommandLineFlags { ...@@ -2924,12 +2924,6 @@ class CommandLineFlags {
"how many entries we'll try to leave on the stack during " \ "how many entries we'll try to leave on the stack during " \
"parallel GC") \ "parallel GC") \
\ \
product(intx, DCQBarrierQueueBufferSize, 256, \
"Number of elements in a dirty card queue buffer") \
\
product(intx, DCQBarrierProcessCompletedThreshold, 5, \
"Number of completed dirty card buffers to trigger processing.") \
\
/* stack parameters */ \ /* stack parameters */ \
product_pd(intx, StackYellowPages, \ product_pd(intx, StackYellowPages, \
"Number of yellow zone (recoverable overflows) pages") \ "Number of yellow zone (recoverable overflows) pages") \
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册