提交 77eca09d 编写于 作者: T tonyp

6866190: Remove SIMPLE_STACK code from TaskQueue

Summary: What the title says. We don't use SIMPLE_STACK any more.
Reviewed-by: ysr
上级 0d14f5f2
...@@ -465,19 +465,7 @@ public: ...@@ -465,19 +465,7 @@ public:
#endif #endif
}; };
#define SIMPLE_STACK 0
template<class E> inline bool GenericTaskQueue<E>::push(E t) { template<class E> inline bool GenericTaskQueue<E>::push(E t) {
#if SIMPLE_STACK
uint localBot = _bottom;
if (_bottom < max_elems()) {
_elems[localBot] = t;
_bottom = localBot + 1;
return true;
} else {
return false;
}
#else
uint localBot = _bottom; uint localBot = _bottom;
assert((localBot >= 0) && (localBot < N), "_bottom out of range."); assert((localBot >= 0) && (localBot < N), "_bottom out of range.");
idx_t top = _age.top(); idx_t top = _age.top();
...@@ -490,18 +478,9 @@ template<class E> inline bool GenericTaskQueue<E>::push(E t) { ...@@ -490,18 +478,9 @@ template<class E> inline bool GenericTaskQueue<E>::push(E t) {
} else { } else {
return push_slow(t, dirty_n_elems); return push_slow(t, dirty_n_elems);
} }
#endif
} }
template<class E> inline bool GenericTaskQueue<E>::pop_local(E& t) { template<class E> inline bool GenericTaskQueue<E>::pop_local(E& t) {
#if SIMPLE_STACK
uint localBot = _bottom;
assert(localBot > 0, "precondition.");
localBot--;
t = _elems[localBot];
_bottom = localBot;
return true;
#else
uint localBot = _bottom; uint localBot = _bottom;
// This value cannot be N-1. That can only occur as a result of // This value cannot be N-1. That can only occur as a result of
// the assignment to bottom in this method. If it does, this method // the assignment to bottom in this method. If it does, this method
...@@ -529,7 +508,6 @@ template<class E> inline bool GenericTaskQueue<E>::pop_local(E& t) { ...@@ -529,7 +508,6 @@ template<class E> inline bool GenericTaskQueue<E>::pop_local(E& t) {
// path. // path.
return pop_local_slow(localBot, _age.get()); return pop_local_slow(localBot, _age.get());
} }
#endif
} }
typedef oop Task; typedef oop Task;
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册