6866585: debug code in ciObjectFactory too slow for large objects

Reviewed-by: ysr, never, kvn

src/share/vm/ci/ciObjectFactory.cpp

@@ -219,24 +219,27 @@ ciObject* ciObjectFactory::get(oop key) {
   ASSERT_IN_VM;
 
 #ifdef ASSERT
+  if (CIObjectFactoryVerify) {
     oop last = NULL;
     for (int j = 0; j< _ci_objects->length(); j++) {
       oop o = _ci_objects->at(j)->get_oop();
       assert(last < o, "out of order");
       last = o;
     }
+  }
 #endif // ASSERT
   int len = _ci_objects->length();
   int index = find(key, _ci_objects);
 #ifdef ASSERT
+  if (CIObjectFactoryVerify) {
     for (int i=0; i<_ci_objects->length(); i++) {
       if (_ci_objects->at(i)->get_oop() == key) {
         assert(index == i, " bad lookup");
       }
     }
+  }
 #endif
   if (!is_found_at(index, key, _ci_objects)) {
-
     // Check in the non-perm area before putting it in the list.
     NonPermObject* &bucket = find_non_perm(key);
     if (bucket != NULL) {
@@ -539,12 +542,14 @@ void ciObjectFactory::insert(int index, ciObject* obj, GrowableArray<ciObject*>*
     objects->at_put(index, obj);
   }
 #ifdef ASSERT
+  if (CIObjectFactoryVerify) {
     oop last = NULL;
     for (int j = 0; j< objects->length(); j++) {
       oop o = objects->at(j)->get_oop();
       assert(last < o, "out of order");
       last = o;
     }
+  }
 #endif // ASSERT
 }
 

src/share/vm/runtime/globals.hpp

@@ -3034,6 +3034,9 @@ class CommandLineFlags {
           "Wait for this many CI accesses to occur in all compiles before " \
           "beginning to throw OutOfMemoryErrors in each compile")           \
                                                                             \
+  notproduct(bool, CIObjectFactoryVerify, false,                            \
+          "enable potentially expensive verification in ciObjectFactory")   \
+                                                                            \
   /* Priorities */                                                          \
   product_pd(bool, UseThreadPriorities,  "Use native thread priorities")    \
                                                                             \