8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization

Summary: Compile with -O3 and relevant C flags as for fdlibm. Reviewed-by: andrew

8210425: [x86] sharedRuntimeTrig/sharedRuntimeTrans compiled without optimization
Summary: Compile with -O3 and relevant C flags as for fdlibm. Reviewed-by: andrew
4eee399e · sgehwolf · 2e1aa959 · 4eee399e · 4eee399e · 4eee399e
8 changed file
--- a/make/bsd/makefiles/amd64.make
+++ b/make/bsd/makefiles/amd64.make
@@ -22,11 +22,16 @@
 #  
 #
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
-# Must also specify if CPU is little endian
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 CFLAGS += -DVM_LITTLE_ENDIAN
 CFLAGS += -D_LP64=1

--- a/make/bsd/makefiles/i486.make
+++ b/make/bsd/makefiles/i486.make
@@ -24,10 +24,16 @@
 # TLS helper, assembled from .s file
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Must also specify if CPU is little endian
 CFLAGS += -DVM_LITTLE_ENDIAN

--- a/make/bsd/makefiles/ppc.make
+++ b/make/bsd/makefiles/ppc.make
@@ -22,8 +22,16 @@
 #  
 #
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
+# without losing precision.
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Must also specify if CPU is big endian
 CFLAGS += -DVM_BIG_ENDIAN

--- a/make/bsd/makefiles/zeroshark.make
+++ b/make/bsd/makefiles/zeroshark.make
@@ -25,10 +25,16 @@
 # Setup common to Zero (non-Shark) and Shark versions of VM
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Specify that the CPU is little endian, if necessary
 ifeq ($(ZERO_ENDIANNESS), little)

--- a/make/linux/makefiles/amd64.make
+++ b/make/linux/makefiles/amd64.make
@@ -22,10 +22,16 @@
 #  
 #
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Must also specify if CPU is little endian
 CFLAGS += -DVM_LITTLE_ENDIAN

--- a/make/linux/makefiles/i486.make
+++ b/make/linux/makefiles/i486.make
@@ -24,10 +24,16 @@
 # TLS helper, assembled from .s file
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Must also specify if CPU is little endian
 CFLAGS += -DVM_LITTLE_ENDIAN

--- a/make/linux/makefiles/ppc64.make
+++ b/make/linux/makefiles/ppc64.make
@@ -49,3 +49,14 @@ else
  # Use Power8, this is the first CPU to support PPC64 LE with ELFv2 ABI.
  CFLAGS += -mcpu=power7 -mtune=power8 -minsert-sched-nops=regroup_exact -mno-multiple -mno-string
 endif
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
+# the compiler so as to be able to produce optimized objects
+# without losing precision.
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
--- a/make/linux/makefiles/zeroshark.make
+++ b/make/linux/makefiles/zeroshark.make
@@ -28,10 +28,16 @@
 # override this from the main file because some version of llvm do not like -Wundef
 WARNING_FLAGS = -Wpointer-arith -Wsign-compare -Wunused-function -Wunused-value
-# The copied fdlibm routines in sharedRuntimeTrig.o must not be optimized
+# If FDLIBM_CFLAGS is non-empty it holds CFLAGS needed to be passed to
-OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+# the compiler so as to be able to produce optimized objects
-# The copied fdlibm routines in sharedRuntimeTrans.o must not be optimized
+# without losing precision.
-OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+ifneq ($(FDLIBM_CFLAGS),)
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/SPEED) $(FDLIBM_CFLAGS)
+else
+  OPT_CFLAGS/sharedRuntimeTrig.o = $(OPT_CFLAGS/NOOPT)
+  OPT_CFLAGS/sharedRuntimeTrans.o = $(OPT_CFLAGS/NOOPT)
+endif
 # Specify that the CPU is little endian, if necessary
 ifeq ($(ZERO_ENDIANNESS), little)