提交 040a6228 编写于 作者: S shshahma

8152438: Threads may do significant work out of the non-shared overflow buffer

Summary: Before processing an element in the non-shared overflow buffer, try to push it into the local shared buffer to keep it full.
Reviewed-by: jmasa, ehelin, sjohanss
上级 ab0850f0
/* /*
* Copyright (c) 2014, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2014, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
...@@ -148,7 +148,9 @@ void G1ParScanThreadState::trim_queue() { ...@@ -148,7 +148,9 @@ void G1ParScanThreadState::trim_queue() {
do { do {
// Drain the overflow stack first, so other threads can steal. // Drain the overflow stack first, so other threads can steal.
while (_refs->pop_overflow(ref)) { while (_refs->pop_overflow(ref)) {
dispatch_reference(ref); if (!_refs->try_push_to_taskqueue(ref)) {
dispatch_reference(ref);
}
} }
while (_refs->pop_local(ref)) { while (_refs->pop_local(ref)) {
......
/* /*
* Copyright (c) 2001, 2013, Oracle and/or its affiliates. All rights reserved. * Copyright (c) 2001, 2016, Oracle and/or its affiliates. All rights reserved.
* DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
* *
* This code is free software; you can redistribute it and/or modify it * This code is free software; you can redistribute it and/or modify it
...@@ -453,6 +453,9 @@ public: ...@@ -453,6 +453,9 @@ public:
// Push task t onto the queue or onto the overflow stack. Return true. // Push task t onto the queue or onto the overflow stack. Return true.
inline bool push(E t); inline bool push(E t);
// Try to push task t onto the queue only. Returns true if successful, false otherwise.
inline bool try_push_to_taskqueue(E t);
// Attempt to pop from the overflow stack; return true if anything was popped. // Attempt to pop from the overflow stack; return true if anything was popped.
inline bool pop_overflow(E& t); inline bool pop_overflow(E& t);
...@@ -486,6 +489,10 @@ bool OverflowTaskQueue<E, F, N>::pop_overflow(E& t) ...@@ -486,6 +489,10 @@ bool OverflowTaskQueue<E, F, N>::pop_overflow(E& t)
return true; return true;
} }
template <class E, MEMFLAGS F, unsigned int N>
bool OverflowTaskQueue<E, F, N>::try_push_to_taskqueue(E t) {
return taskqueue_t::push(t);
}
class TaskQueueSetSuper { class TaskQueueSetSuper {
protected: protected:
static int randomParkAndMiller(int* seed0); static int randomParkAndMiller(int* seed0);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册