1. 08 7月, 2014 3 次提交
  2. 04 7月, 2014 3 次提交
  3. 01 7月, 2014 4 次提交
    • N
      tmon: set umask to a reasonable value · 4adccf9f
      Neil Horman 提交于
      Currently, the tmon umask value is set to 0, which means whatever the permission
      mask in the shell are when starting tmon in daemon mode are what the permissions
      of any created files will be.  We should likely set something more explicit, so
      lets go with the usual 022
      Signed-off-by: NNeil Horman <nhorman@tuxdriver.com>
      Acked-by: NJacob Pan <jacob.jun.pan@linux.intel.com>
      Signed-off-by: NZhang Rui <rui.zhang@intel.com>
      4adccf9f
    • N
      tmon: Check log file for common secuirty issues · 951fda3d
      Neil Horman 提交于
      The tmon logging system blindly opens its log file on a static path, making it
      very easy for someone to redirect that log information to inappropriate places
      or overwrite other users data.  Do some easy checking to make sure we're not
      logging to a symlink or a file owned by another user.
      Signed-off-by: NNeil Horman <nhorman@tuxdriver.com>
      Acked-by: NJacob Pan <jacob.jun.pan@linux.intel.com>
      Signed-off-by: NZhang Rui <rui.zhang@intel.com>
      951fda3d
    • J
      tools/thermal: tmon: fix compilation errors when building statically · 6b533269
      Javi Merino 提交于
      tmon fails to build statically with the following error:
      
      $ make LDFLAGS=-static
      gcc -O1 -Wall -Wshadow -W -Wformat -Wimplicit-function-declaration -Wimplicit-int -fstack-protector -D VERSION=\"1.0\" -static tmon.o tui.o sysfs.o pid.o   -o tmon -lm -lpanel -lncursesw  -lpthread
      tmon.o: In function `tmon_sig_handler':
      tmon.c:(.text+0x21): undefined reference to `stdscr'
      tmon.o: In function `tmon_cleanup':
      tmon.c:(.text+0xb9): undefined reference to `stdscr'
      tmon.c:(.text+0x11e): undefined reference to `stdscr'
      tmon.c:(.text+0x123): undefined reference to `keypad'
      tmon.c:(.text+0x12d): undefined reference to `nocbreak'
      tmon.o: In function `main':
      tmon.c:(.text+0x785): undefined reference to `stdscr'
      tmon.c:(.text+0x78a): undefined reference to `nodelay'
      tui.o: In function `setup_windows':
      tui.c:(.text+0x131): undefined reference to `stdscr'
      tui.c:(.text+0x176): undefined reference to `stdscr'
      tui.c:(.text+0x19f): undefined reference to `stdscr'
      tui.c:(.text+0x1cc): undefined reference to `stdscr'
      tui.c:(.text+0x1ff): undefined reference to `stdscr'
      tui.o:tui.c:(.text+0x229): more undefined references to `stdscr' follow
      tui.o: In function `show_cooling_device':
      [...]
      
      stdscr() and friends are in libtinfo (part of ncurses) so add it to
      the libraries that are linked in when compiling tmon to fix it.
      
      Cc: Jacob Pan <jacob.jun.pan@linux.intel.com>
      Cc: Zhang Rui <rui.zhang@intel.com>
      Signed-off-by: NJavi Merino <javi.merino@arm.com>
      Acked-by: NJacob Pan <jacob.jun.pan@linux.intel.com>
      6b533269
    • M
      tools: ffs-test: fix header values endianess · f35f7124
      Michal Nazarewicz 提交于
      It appears that no one ever run ffs-test on a big-endian machine,
      since it used cpu-endianess for fs_count and hs_count fields which
      should be in little-endian format.  Fix by wrapping the numbers in
      cpu_to_le32.
      
      Cc: stable@vger.kernel.org
      Signed-off-by: NMichal Nazarewicz <mina86@mina86.com>
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      f35f7124
  4. 27 6月, 2014 1 次提交
  5. 24 6月, 2014 1 次提交
  6. 20 6月, 2014 2 次提交
  7. 19 6月, 2014 1 次提交
  8. 12 6月, 2014 14 次提交
  9. 11 6月, 2014 5 次提交
  10. 10 6月, 2014 4 次提交
  11. 09 6月, 2014 2 次提交
    • M
      perf probe: Improve error message for unknown member of data structure · 36d789a4
      Masami Hiramatsu 提交于
      Improve the error message if we can not find given member in the given
      structure. Currently perf probe shows a wrong error message as below.
      
        -----
        # perf probe getname_flags:65 "result->BOGUS"
        result(type:filename) has no member BOGUS.
        Failed to find 'result' in this function.
          Error: Failed to add events. (-22)
        -----
      
      The first message is correct, but the second one is not, since we didn't
      fail to find a variable but fails to find the member of given variable.
      
        -----
        # perf probe getname_flags:65 "result->BOGUS"
        result(type:filename) has no member BOGUS.
          Error: Failed to add events. (-22)
        -----
      
      With this patch, the error message shows only the first one.  And if we
      really failed to find given variable, it tells us so.
      
        -----
        # perf probe getname_flags:65 "BOGUS"
        Failed to find 'BOGUS' in this function.
          Error: Failed to add events. (-2)
        -----
      Reported-by: NArnaldo Carvalho de Melo <acme@kernel.org>
      Signed-off-by: NMasami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Jiri Olsa <jolsa@redhat.com>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
      Link: http://lkml.kernel.org/r/20140606071345.6788.23744.stgit@kbuild-fedora.novalocalSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      36d789a4
    • A
      perf tests: Show the inner make output when an error happens · a5c5009f
      Arnaldo Carvalho de Melo 提交于
      Before:
      
        [acme@zoo linux]$ make -C tools/perf -f tests/make make_static
        make: Entering directory `/home/git/linux/tools/perf'
        - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.JcWuM4Zu9f LDFLAGS=-static
        make: *** [make_static] Error 1
        make: Leaving directory `/home/git/linux/tools/perf'
        [acme@zoo linux]$
      
      After:
      
        [acme@zoo linux]$ make -C tools/perf -f tests/make make_static
        make: Entering directory `/home/git/linux/tools/perf'
        - make_static: cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static
        cd . && make -f Makefile DESTDIR=/tmp/tmp.X3su83i14u LDFLAGS=-static
          BUILD:   Doing 'make -j4' parallel build
        config/Makefile:303: *** No static glibc found, please install glibc-static.  Stop.
        make[1]: *** [all] Error 2
          test: test -x ./perf
        make: Leaving directory `/home/git/linux/tools/perf'
        [acme@zoo linux]$
      
      Cc: Adrian Hunter <adrian.hunter@intel.com>
      Cc: David Ahern <dsahern@gmail.com>
      Cc: Don Zickus <dzickus@redhat.com>
      Cc: Frederic Weisbecker <fweisbec@gmail.com>
      Cc: Ingo Molnar <mingo@kernel.org>
      Cc: Mike Galbraith <efault@gmx.de>
      Cc: Namhyung Kim <namhyung@kernel.org>
      Cc: Paul Mackerras <paulus@samba.org>
      Cc: Peter Zijlstra <peterz@infradead.org>
      Cc: Stephane Eranian <eranian@google.com>
      Link: http://lkml.kernel.org/n/tip-h4kby5wyp6nfev3882rzm3r9@git.kernel.orgSigned-off-by: NArnaldo Carvalho de Melo <acme@redhat.com>
      a5c5009f