1. 18 11月, 2014 1 次提交
    • J
      mfd/axp20x: avoid irq numbering collision · ff3bbc5c
      Jacob Pan 提交于
      IRQ numbers in axp20x devices are defined with high-order bit first
      in each IRQ enable/status registers. On Intel platforms it is more
      common to number IRQs with least significant bit first. Therefore,
      sharing IRQ# between the two is very difficult. Since AXP288 is a
      customized PMIC for Intel platform and the amount of shared IRQs are
      very small, we use separate IRQ numbering. This also fixes collision
      and a duplicate in WBTO interrupt.
      
      e.g. For the 16 interrupts controlled in IRQ enabled registers 1 & 2,
      on axp20x for ARM, the PMIC local IRQ numbers and register bits are
      mapped as:
      IRQ#:  0  1  2  3  4  5  6  7      8  9 10 11 12 13 14 15
      ---------------------------------------------------------
      ARM:   7  6  5  4  3  2  1  0      7  6  5  4  3  2  1  0
      Intel: 0  1  2  3  4  5  6  7      0  1  2  3  4  5  6  7
      Signed-off-by: NTodd Brandt <todd.e.brandt@linux.intel.com>
      Signed-off-by: NJacob Pan <jacob.jun.pan@linux.intel.com>
      Acked-by: NJonathan Cameron <jic23@kernel.org>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      ff3bbc5c
  2. 07 10月, 2014 1 次提交
  3. 28 8月, 2014 1 次提交
    • T
      mfd: twl4030-power: Fix PM idle pin configuration to not conflict with regulators · daebabd5
      Tony Lindgren 提交于
      Commit 43fef47f (mfd: twl4030-power: Add a configuration to turn
      off oscillator during off-idle) added support for configuring the PMIC
      to cut off resources during deeper idle states to save power.
      
      This however caused regression for n900 display power that needed the
      PMIC configuration to be disabled with commit d937678a (ARM: dts:
      Revert enabling of twl configuration for n900).
      
      Turns out the root cause of the problem is that we must use
      TWL4030_RESCONFIG_UNDEF instead of DEV_GRP_NULL to avoid disabling
      regulators that may have been enabled before the init function
      for twl4030-power.c runs. With TWL4030_RESCONFIG_UNDEF we let the
      regulator framework control the regulators like it should. Here we
      need to only configure the sys_clken and sys_off_mode triggers for
      the regulators that cannot be done by the regulator framework as
      it's not running at that point.
      
      This allows us to enable the PMIC configuration for n900.
      
      Fixes: 43fef47f (mfd: twl4030-power: Add a configuration to turn off oscillator during off-idle)
      
      Cc: stable@vger.kernel.org # v3.16
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Tested-by: NAaro Koskinen <aaro.koskinen@iki.fi>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      daebabd5
  4. 20 8月, 2014 3 次提交
  5. 15 8月, 2014 1 次提交
  6. 29 7月, 2014 1 次提交
  7. 28 7月, 2014 11 次提交
  8. 25 7月, 2014 14 次提交
    • L
      mfd: max77686: Ensure device type IDs are architecture agnostic · ec8bd566
      Lee Jones 提交于
      Extinguishes:
      
      ../drivers/mfd/max77686.c: In function ‘max77686_i2c_probe’:
      ../drivers/mfd/max77686.c:254:20:
      	warning: cast from pointer to integer of different size
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      ec8bd566
    • J
      mfd: max77686: Add Maxim 77802 PMIC support · a259f389
      Javier Martinez Canillas 提交于
      Maxim MAX77802 is a power management chip that contains 10 high
      efficiency Buck regulators, 32 Low-dropout (LDO) regulators used
      to power up application processors and peripherals, a 2-channel
      32kHz clock outputs, a Real-Time-Clock (RTC) and a I2C interface
      to program the individual regulators, clocks outputs and the RTC.
      
      This patch adds support for MAX77802 to the MAX77686 driver and is
      based on a driver added to the Chrome OS kernel 3.8 by Simon Glass.
      Signed-off-by: NJavier Martinez Canillas <javier.martinez@collabora.co.uk>
      Reviewed-by: NKrzysztof Kozlowski <k.kozlowski@samsung.com>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      a259f389
    • H
      mfd: tps6105x: Use managed resources when allocating memory · ad83533a
      Himangi Saraogi 提交于
      This patch introduces the use of devm_kzalloc instead of the
      corresponding unmanaged version and does away with the kfrees in the
      probe and remove functions. Also, a label is done away with.
      Signed-off-by: NHimangi Saraogi <himangi774@gmail.com>
      Acked-by: NJulia Lawall <julia.lawall@lip6.fr>
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      ad83533a
    • L
      mfd: wm8997-tables: Suppress 'line over 80 chars' warnings · 23213218
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: line over 80 characters
      +       { 0x00000068, 0x01FF },    /* R104   - Always On Triggers Sequence Select 3 */
      
      WARNING: line over 80 characters
      +       { 0x00000069, 0x01FF },    /* R105   - Always On Triggers Sequence Select 4 */
      
      WARNING: line over 80 characters
      +       { 0x0000006A, 0x01FF },    /* R106   - Always On Triggers Sequence Select 5 */
      
      WARNING: line over 80 characters
      +       { 0x0000006B, 0x01FF },    /* R107   - Always On Triggers Sequence Select 6 */
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      23213218
    • L
      mfd: kempld-core: Correct a variety of checkpatch warnings · 9ef4e935
      Lee Jones 提交于
      WARNING: line over 80 characters
      +module_param_string(force_device_id, force_device_id, sizeof(force_device_id), 0);
      
      WARNING: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.txt
      +               msleep(1);
      
      WARNING: __initdata should be placed after kempld_dmi_table[]
      +static struct dmi_system_id __initdata kempld_dmi_table[] = {
      
      WARNING: line over 80 characters
      +               for (id = kempld_dmi_table; id->matches[0].slot != DMI_NONE; id++)
      
      total: 0 errors, 4 warnings, 771 lines checked
      
      This is part of an effort to clean-up the MFD subsystem.
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      9ef4e935
    • L
      mfd: ipaq-micro: Fix coding style errors/warnings reported by checkpatch · 9336fe91
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      ERROR: space required before the open parenthesis '('
      +                       if(!micro->msg)
      
      WARNING: unnecessary whitespace before a quoted newline
      +                       dev_dbg(micro->dev, "key message ignored, no handle \n");
      
      WARNING: unnecessary whitespace before a quoted newline
      +                       dev_dbg(micro->dev, "touchscreen message ignored, no handle \n");
      
      WARNING: space prohibited before semicolon
      +               rx->id = (ch & 0xf0) >> 4 ;
      
      total: 1 errors, 3 warnings, 482 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      9336fe91
    • L
      mfd: si476x-cmd: Remedy checkpatch style complains · d69d4212
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: line over 80 characters
      +                        struct si476x_rsq_status_args *rsqargs,
      
      WARNING: line over 80 characters
      +                        struct si476x_rsq_status_report *report)
      
      WARNING: Unnecessary space before function pointer arguments
      +       int (*power_up) (struct si476x_core *,
      
      WARNING: Unnecessary space before function pointer arguments
      +       int (*power_down) (struct si476x_core *,
      
      total: 0 errors, 4 warnings, 1555 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      d69d4212
    • L
      mfd: tc6387xb: Remove unnecessary braces and correct style warnings · d5ce79ff
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: braces {} are not necessary for single statement blocks
      +       if (!iomem) {
      +               return -EINVAL;
      +       }
      
      WARNING: sizeof *tc6387xb should be sizeof(*tc6387xb)
      +       tc6387xb = kzalloc(sizeof *tc6387xb, GFP_KERNEL);
      
      WARNING: Prefer [subsystem eg: netdev]_info([subsystem]dev, ... then dev_info(dev, ... then pr_info(...  to printk(KERN_INFO ...
      +       printk(KERN_INFO "Toshiba tc6387xb initialised\n");
      
      total: 0 errors, 3 warnings, 242 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      d5ce79ff
    • L
      mfd: twl6030-irq: Extinguish coding style warnings · 3103de8c
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: please, no space before tabs
      +^IRSV_INTR_OFFSET,  ^I/* Bit 12^IReserved^I^I*/$
      
      WARNING: Missing a blank line after declarations
      +       u8 unmask_value;
      +       ret = twl_i2c_read_u8(TWL_MODULE_PIH, &unmask_value,
      
      WARNING: Missing a blank line after declarations
      +       u8 mask_value;
      +       ret = twl_i2c_read_u8(TWL_MODULE_PIH, &mask_value,
      
      total: 0 errors, 3 warnings, 484 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      3103de8c
    • L
      mfd: wm8350-i2c: Replace spaces with tabs · 6db1c9ba
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: please, no spaces at the start of a line
      +       { "wm8350", 0 },$
      
      WARNING: please, no spaces at the start of a line
      +       { "wm8351", 0 },$
      
      WARNING: please, no spaces at the start of a line
      +       { "wm8352", 0 },$
      
      WARNING: please, no spaces at the start of a line
      +       { }$
      
      total: 0 errors, 4 warnings, 93 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      6db1c9ba
    • L
      mfd: max8925-core: Fix 'missing blank line after declarations' warning · a5c5accf
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: Missing a blank line after declarations
      +       struct max8925_chip *chip = irq_data_get_irq_chip_data(data);
      +       max8925_irqs[data->irq - chip->irq_base].enable
      
      WARNING: Missing a blank line after declarations
      +       struct max8925_chip *chip = irq_data_get_irq_chip_data(data);
      +       max8925_irqs[data->irq - chip->irq_base].enable = 0;
      
      total: 0 errors, 2 warnings, 927 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      a5c5accf
    • L
      mfd: twl4030-irq: Fix style warnings relating to pr_warn() and sizeof() · 04aa4438
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: Prefer pr_warn(... to pr_warning(...
      +               pr_warning("twl4030: I2C error %d reading PIH ISR\n", ret);
      
      WARNING: sizeof buf should be sizeof(buf)
      +       memset(buf, 0xff, sizeof buf);
      
      WARNING: sizeof *agent should be sizeof(*agent)
      +       agent = kzalloc(sizeof *agent, GFP_KERNEL);
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      04aa4438
    • L
      mfd: lp8788-irq: Fix 'missing blank line after declarations' warning · 52149ad2
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: Missing a blank line after declarations
      +       struct lp8788_irq_data *irqd = irq_data_get_irq_chip_data(data);
      +       irqd->enabled[data->hwirq] = 1;
      
      WARNING: Missing a blank line after declarations
      +       struct lp8788_irq_data *irqd = irq_data_get_irq_chip_data(data);
      +       irqd->enabled[data->hwirq] = 0;
      
      total: 0 errors, 2 warnings, 198 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      52149ad2
    • L
      mfd: ezx-pcap: Repair coding style errors picked up with checkpatch · 0309528a
      Lee Jones 提交于
      This is part of an effort to clean-up the MFD subsystem.
      
      WARNING: sizeof t should be sizeof(t)
      +       memset(&t, 0, sizeof t);
      
      WARNING: void function return statements are not generally useful
      +       return;
      +}
      
      total: 0 errors, 2 warnings, 542 lines checked
      Signed-off-by: NLee Jones <lee.jones@linaro.org>
      0309528a
  9. 24 7月, 2014 1 次提交
  10. 22 7月, 2014 5 次提交
  11. 21 7月, 2014 1 次提交