1. 01 8月, 2017 1 次提交
    • T
      device property: Fix usecount for of_graph_get_port_parent() · c0a480d1
      Tony Lindgren 提交于
      Fix inconsistent use of of_graph_get_port_parent() where
      asoc_simple_card_parse_graph_dai() does of_node_get() before
      calling it while other callers do not. We can fix this by
      not trashing the node passed to of_graph_get_port_parent().
      
      Let's also make sure the callers have correct refcounts and remove
      related incorrect of_node_put() calls for of_for_each_phandle
      as that's done by of_phandle_iterator_next() except when
      we break out of the loop early.
      
      Let's fix both issues with a single patch to avoid kobject
      refcounts getting messed up more if two patches are merged
      separately.
      
      Otherwise strange issues can happen caused by memory corruption
      caused by too many kobject_del() calls such as:
      
      BUG: sleeping function called from invalid context at
      kernel/locking/mutex.c:747
      ...
      (___might_sleep)
      (__mutex_lock)
      (mutex_lock_nested)
      (kernfs_remove)
      (kobject_del)
      (kobject_put)
      (of_get_next_parent)
      (of_graph_get_port_parent)
      (asoc_simple_card_parse_graph_dai [snd_soc_simple_card_utils])
      (asoc_graph_card_probe [snd_soc_audio_graph_card])
      
      Fixes: 0ef472a9 ("of_graph: add of_graph_get_port_parent()")
      Fixes: 2692c1c6 ("ASoC: add audio-graph-card support")
      Fixes: 1689333f ("ASoC: simple-card-utils: add asoc_simple_card_parse_graph_dai()")
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Reviewed-by: NRob Herring <robh@kernel.org>
      Tested-by: NAntonio Borneo <borneo.antonio@gmail.com>
      Tested-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      c0a480d1
  2. 17 6月, 2017 1 次提交
  3. 16 6月, 2017 2 次提交
  4. 14 6月, 2017 2 次提交
    • K
      ASoC: simple_card_utils: add EXPORT_SYMBOL_GPL() for asoc_simple_card_clk_xxx() · 63a5f592
      Kuninori Morimoto 提交于
      commit 891caea4 ("ASoC: simple_card_utils:
      add asoc_simple_card_clk_xxx()") added new asoc_simple_card_clk_xxx(),
      but, it didn't have EXPORT_SYMBOL_GPL().
      This patch adds it. Otherwise, we will get below error
      
      ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-simple-scu-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-simple-scu-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-simple-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-audio-graph-scu-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-audio-graph-scu-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_enable" [sound/soc/generic/snd-soc-audio-graph-card.ko] undefined!
      ERROR: "asoc_simple_card_clk_disable" [sound/soc/generic/snd-soc-audio-graph-card.ko] undefined!
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      63a5f592
    • K
      ASoC: simple_card_utils: add asoc_simple_card_clk_xxx() · 891caea4
      Kuninori Morimoto 提交于
      Current simple-card-utils sets asoc_simple_dai::clk via
      asoc_simple_card_parse_clk().
      Current simple card drivers are using it directly for
      clk_enable/disable.
      Encapsulation is one of simple card util's purpose.
      Let's encapsulate it.
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      891caea4
  5. 07 6月, 2017 4 次提交
  6. 26 5月, 2017 1 次提交
  7. 25 5月, 2017 1 次提交
  8. 17 5月, 2017 2 次提交
  9. 25 3月, 2017 1 次提交
  10. 24 1月, 2017 1 次提交
  11. 05 12月, 2016 1 次提交
  12. 29 10月, 2016 1 次提交
  13. 11 8月, 2016 2 次提交
  14. 09 8月, 2016 2 次提交
  15. 08 8月, 2016 2 次提交
  16. 04 8月, 2016 1 次提交
  17. 16 7月, 2016 2 次提交
  18. 30 6月, 2016 1 次提交
    • K
      ASoC: add new simple-card-utils.c · abd3147e
      Kuninori Morimoto 提交于
      Current ALSA SoC has simple-card driver which is supporting both
      platform and DT probe.
      Now, some sound cards driver are created based on simple-card.
      They have similar feature or function, but implemented separately
      on each drivers. This is a waste of code.
      OTOH, merging these driver into same driver is highly risk,
      because it will be very difficult to keep compatibility.
      More over, ALSA SoC want to have graph base of DT feature in the
      future. Maybe it want to use simple-card like feature / function.
      Because of these background, this patch creates simple-card
      helper utils, and provides common function to each drivers.
      1st is asoc_simple_card_parse_daifmt()
      Signed-off-by: NKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      abd3147e