1. 20 11月, 2008 1 次提交
  2. 04 11月, 2008 1 次提交
  3. 31 10月, 2008 1 次提交
    • R
      skge: adapt skge to use reworked PCI PM · 5177b324
      Rafael J. Wysocki 提交于
      Adapt the skge driver to the reworked PCI PM
      
      * Use device_set_wakeup_enable() and friends as needed
      * Remove an open-coded reference to the standard PCI PM registers
      * Use pci_prepare_to_sleep() and pci_back_from_sleep() in the
        ->suspend() and ->resume() callbacks
      * Use the observation that it is sufficient to call pci_enable_wake()
        once, unless it fails
      
      Tested on Asus L5D (Yukon-Lite rev 7).
      Signed-off-by: NRafael J. Wysocki <rjw@sisk.pl>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Cc: Jesse Barnes <jbarnes@virtuousgeek.org>
      Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
      Signed-off-by: NJeff Garzik <jgarzik@redhat.com>
      5177b324
  4. 28 10月, 2008 1 次提交
  5. 09 10月, 2008 2 次提交
    • W
      skge: Fix skge_set_ring_param() losing error return · e824b3eb
      Wang Chen 提交于
      The error return is useful to caller, driver shouldn't miss it.
      Signed-off-by: NWang Chen <wangchen@cn.fujitsu.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e824b3eb
    • X
      [10/21] driver/net/skge.c: restart the interface when it's options or · 9ac1353f
      Xiaoming.Zhang 提交于
      pauseparam is set
      
      On Wednesday 24 September 2008 07:47, Stephen Hemminger wrote:
      > On Mon, 22 Sep 2008 14:52:17 -0700
      >
      > akpm@linux-foundation.org wrote:
      > > From: "Xiaoming.Zhang" <Xiaoming.Zhang@resilience.com>
      > >
      > > We have an issue of the skge driver: The card won't work when it's
      > > options are changed.  Here's the hardware info:
      > >
      > > # lspci -v
      > > 05:04.0 Ethernet controller: Marvell Technology Group Ltd. 88E8001
      > > Gigabit Ethernet Controller (rev 13) Subsystem: Marvell Technology Group
      > > Ltd. Marvell RDK-8001 Flags: bus master, 66MHz, medium devsel, latency
      > > 32, IRQ 16 Memory at d042c000 (32-bit, non-prefetchable) [size=16K] I/O
      > > ports at d000 [size=256]
      > >         [virtual] Expansion ROM at 20400000 [disabled] [size=128K]
      > >         Capabilities: [48] Power Management version 2
      > >         Capabilities: [50] Vital Product Data
      > >
      > > The happens in both Linux-2.6.26(skge version 1.23) and RHEL5.2(skge
      > > version 1.6).
      > >
      > > For example, at first it is set to "speed 1000 duplex full auto-neg on"
      > > and it works, then run
      > >
      > >        ethtool -s <ethx> autoneg off
      > > or     ethtool -s <ethx> speed 100 duplex full autoneg off
      > >
      > > Then it will stop working. After that if we restart the interface:
      > >
      > > 	ifconifg <ethx> down
      > > 	ifconfig <ethx> up
      > >
      > > It will work again. And `ethtool -A' has the same issue.
      > >
      > > So we think after setting the options, the interface should be restarted.
      > >
      > > Signed-off-by: Zhang Xiaoming <xiaoming.zhang@resilience.com>
      > > Cc: Stephen Hemminger <shemminger@vyatta.com>
      > > Cc: Jeff Garzik <jeff@garzik.org>
      > > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
      > > ---
      > >
      > >  drivers/net/skge.c |   12 ++++++++----
      > >  1 file changed, 8 insertions(+), 4 deletions(-)
      > >
      > > diff -puN
      > > drivers/net/skge.c~driver-net-skgec-restart-the-interface-when-its-option
      > >s-or-pauseparam-is-set drivers/net/skge.c ---
      > > a/drivers/net/skge.c~driver-net-skgec-restart-the-interface-when-its-opti
      > >ons-or-pauseparam-is-set +++ a/drivers/net/skge.c
      > > @@ -353,8 +353,10 @@ static int skge_set_settings(struct net_
      > >  	skge->autoneg = ecmd->autoneg;
      > >  	skge->advertising = ecmd->advertising;
      > >
      > > -	if (netif_running(dev))
      > > -		skge_phy_reset(skge);
      > > +	if (netif_running(dev)) {
      > > +		skge_down(dev);
      > > +		skge_up(dev);
      > > +	}
      > >
      > >  	return (0);
      > >  }
      > > @@ -595,8 +597,10 @@ static int skge_set_pauseparam(struct ne
      > >  			skge->flow_control = FLOW_MODE_NONE;
      > >  	}
      > >
      > > -	if (netif_running(dev))
      > > -		skge_phy_reset(skge);
      > > +	if (netif_running(dev)) {
      > > +		skge_down(dev);
      > > +		skge_up(dev);
      > > +	}
      > >
      > >  	return 0;
      > >  }
      >
      > Since skge_up can fail because of out of memory, this code needs to
      > check the return value. And then if it fails the "limbo state" needs
      > to be handled in skge_down.
      
      How about like this? It is tested.
      
      Thank you.
      Signed-off-by: NZhang Xiaoming <xiaoming.zhang@resilience.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      9ac1353f
  6. 26 3月, 2008 2 次提交
  7. 02 12月, 2007 8 次提交
  8. 16 11月, 2007 1 次提交
    • L
      Revert "skge: fix ram buffer size calculation" · 279e1dab
      Linus Torvalds 提交于
      This reverts commit 7fb7ac24.
      
      Heikki Orsila reports that it causes a regression:
      
        "Doing
      
      	nc host port < /dev/zero
      
         on a sending machine (not skge) to an skge machine that is receiving:
      
      	nc -l -p port >/dev/null
      
         with ~60 MiB/s speed, causes the interface go malfunct. A slow
         transfer doesn't cause a problem."
      
      See
      
      	http://bugzilla.kernel.org/show_bug.cgi?id=9321
      
      for some more information.
      
      There is a workaround (also reported by Heikki):
      
        "After some fiddling, I noticed that not changing the register write
         order on patch:
      
         +       skge_write32(hw, RB_ADDR(q, RB_END), end);
                 skge_write32(hw, RB_ADDR(q, RB_WP), start);
                 skge_write32(hw, RB_ADDR(q, RB_RP), start);
         -       skge_write32(hw, RB_ADDR(q, RB_END), end);
      
         fixes the visible effect..  Possibly not the root cause of the
         problem, but changing the order back fixes networking here."
      
      but that has yet to be ack'ed or tested more widely, so the whole
      problem-causing commit gets reverted until this is resolved properly.
      Bisected-and-requested-by: NHeikki Orsila <shdl@zakalwe.fi>
      Cc: Stephen Hemminger <shemminger@linux-foundation.org>
      Cc: Jeff Garzik <jeff@garzik.org>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      279e1dab
  9. 17 10月, 2007 7 次提交
  10. 11 10月, 2007 5 次提交
    • J
      [netdrvr] Stop using legacy hooks ->self_test_count, ->get_stats_count · b9f2c044
      Jeff Garzik 提交于
      These have been superceded by the new ->get_sset_count() hook.
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      b9f2c044
    • J
      [NET]: Introduce and use print_mac() and DECLARE_MAC_BUF() · 0795af57
      Joe Perches 提交于
      This is nicer than the MAC_FMT stuff.
      Signed-off-by: NJoe Perches <joe@perches.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      0795af57
    • J
      [ETHTOOL] Provide default behaviors for a few ethtool sub-ioctls · 88d3aafd
      Jeff Garzik 提交于
      For the operations
      	get-tx-csum
      	get-sg
      	get-tso
      	get-ufo
      the default ethtool_op_xxx behavior is fine for all drivers, so we
      permit op==NULL to imply the default behavior.
      
      This provides a more uniform behavior across all drivers, eliminating
      ethtool(8) "ioctl not supported" errors on older drivers that had
      not been updated for the latest sub-ioctls.
      
      The ethtool_op_xxx() functions are left exported, in case anyone
      wishes to call them directly from a driver-private implementation --
      a not-uncommon case.  Should an ethtool_op_xxx() helper remain unused
      for a while, except by net/core/ethtool.c, we can un-export it at a
      later date.
      
      [ Resolved conflicts with set/get value ethtool patch... -DaveM ]
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      88d3aafd
    • R
      [NET]: Nuke SET_MODULE_OWNER macro. · 10d024c1
      Ralf Baechle 提交于
      It's been a useless no-op for long enough in 2.6 so I figured it's time to
      remove it.  The number of people that could object because they're
      maintaining unified 2.4 and 2.6 drivers is probably rather small.
      
      [ Handled drivers added by netdev tree and some missed IRDA cases... -DaveM ]
      Signed-off-by: NRalf Baechle <ralf@linux-mips.org>
      Signed-off-by: NJeff Garzik <jeff@garzik.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      10d024c1
    • S
      [NET]: Make NAPI polling independent of struct net_device objects. · bea3348e
      Stephen Hemminger 提交于
      Several devices have multiple independant RX queues per net
      device, and some have a single interrupt doorbell for several
      queues.
      
      In either case, it's easier to support layouts like that if the
      structure representing the poll is independant from the net
      device itself.
      
      The signature of the ->poll() call back goes from:
      
      	int foo_poll(struct net_device *dev, int *budget)
      
      to
      
      	int foo_poll(struct napi_struct *napi, int budget)
      
      The caller is returned the number of RX packets processed (or
      the number of "NAPI credits" consumed if you want to get
      abstract).  The callee no longer messes around bumping
      dev->quota, *budget, etc. because that is all handled in the
      caller upon return.
      
      The napi_struct is to be embedded in the device driver private data
      structures.
      
      Furthermore, it is the driver's responsibility to disable all NAPI
      instances in it's ->stop() device close handler.  Since the
      napi_struct is privatized into the driver's private data structures,
      only the driver knows how to get at all of the napi_struct instances
      it may have per-device.
      
      With lots of help and suggestions from Rusty Russell, Roland Dreier,
      Michael Chan, Jeff Garzik, and Jamal Hadi Salim.
      
      Bug fixes from Thomas Graf, Roland Dreier, Peter Zijlstra,
      Joseph Fannin, Scott Wood, Hans J. Koch, and Michael Chan.
      
      [ Ported to current tree and all drivers converted.  Integrated
        Stephen's follow-on kerneldoc additions, and restored poll_list
        handling to the old style to fix mutual exclusion issues.  -DaveM ]
      Signed-off-by: NStephen Hemminger <shemminger@linux-foundation.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      bea3348e
  11. 01 8月, 2007 1 次提交
  12. 12 5月, 2007 1 次提交
  13. 10 5月, 2007 1 次提交
  14. 08 5月, 2007 1 次提交
  15. 28 4月, 2007 2 次提交
  16. 26 4月, 2007 3 次提交
  17. 11 4月, 2007 2 次提交