1. 08 1月, 2011 4 次提交
    • M
      OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+ · f7c5cc45
      Mika Westerberg 提交于
      In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
      updating reg and l values. However, at the end of the function we
      perform a write:
      
      	__raw_writel(l, reg);
      
      So on OMAP2+ we end up writing 0 to the bank->base which is not
      correct (typically this points to GPIO_REVISION register).
      
      Fix this by returning immediately after call to
      set_24xx_gpio_triggering().
      Signed-off-by: NMika Westerberg <ext-mika.1.westerberg@nokia.com>
      Signed-off-by: NKevin Hilman <khilman@ti.com>
      f7c5cc45
    • N
      OMAP2+: TWL: include pm header for init protos · dda0aea7
      Nishanth Menon 提交于
      twl_init functions are declared in pm.h and used in pm.c
      pm.h header defining the protos need to be included to
      ensure that omap_twl.c has consistent function definition.
      This fixes sparse warning:
      arch/arm/mach-omap2/omap_twl.c:237:12: warning: symbol 'omap4_twl_init' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:256:12: warning: symbol 'omap3_twl_init' was not declared. Should it be static?
      Signed-off-by: NNishanth Menon <nm@ti.com>
      Signed-off-by: NKevin Hilman <khilman@ti.com>
      dda0aea7
    • N
      OMAP2+: TWL: make conversion routines static · c84ff1cc
      Nishanth Menon 提交于
      The uv_to_vsel, vsel_to_uv functions don't need to be exposed to the
      world as they are used as function pointers. make them static.
      
      Fixes sparse warnings:
      arch/arm/mach-omap2/omap_twl.c:63:15: warning: symbol 'twl4030_vsel_to_uv' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:68:4: warning: symbol 'twl4030_uv_to_vsel' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:73:15: warning: symbol 'twl6030_vsel_to_uv' was not declared. Should it be static?
      arch/arm/mach-omap2/omap_twl.c:105:4: warning: symbol 'twl6030_uv_to_vsel' was not declared. Should it be static?
      Signed-off-by: NNishanth Menon <nm@ti.com>
      Signed-off-by: NKevin Hilman <khilman@ti.com>
      c84ff1cc
    • N
      OMAP3+: sr_device: include pm header · d0eadf6d
      Nishanth Menon 提交于
      omap_enable_smartreflex_on_init is meant to be used by boards
      which would like to have SR enabled by default on the platform, while
      omap_devinit_smartreflex is used by pm code, the protos are defined
      in pm.h. This header should be included to ensure that sr_device
      function definitions match the prototypes.
      
      including pm.h fixes the sparse warnings (with CONFIG_OMAP_SMARTREFLEX=y):
      arch/arm/mach-omap2/sr_device.c:138:13: warning: symbol 'omap_enable_smartreflex_on_init' was not declared. Should it be static?
      arch/arm/mach-omap2/sr_device.c:143:12: warning: symbol 'omap_devinit_smartreflex' was not declared. Should it be static?
      Signed-off-by: NNishanth Menon <nm@ti.com>
      Signed-off-by: NKevin Hilman <khilman@ti.com>
      d0eadf6d
  2. 07 1月, 2011 36 次提交