1. 10 5月, 2013 2 次提交
  2. 19 2月, 2012 2 次提交
    • M
      [SCSI] pm8001: deficient responses to IO_XFER_ERROR_BREAK and IO_XFER_OPEN_RETRY_TIMEOUT · 5954d738
      Mark Salyzyn 提交于
      IO_XFER_ERROR_BREAK and IO_XFER_OPEN_RETRY_TIMEOUT are deficient of the
      required actions as outlined in the programming manual for the pm8001. Due to
      the overlapping code requirements of these recovery responses, we found it
      necessary to bundle them together into one patch.
      
      When a break is received during the command phase (ssp_completion), this is a
      result of a timeout or interruption on the bus. Logic suggests that we should
      retry the command.
      
      When a break is received during the data-phase (ssp_event), the task must be
      aborted on the target or it will retain a data-phase lock turning the target
      reticent to all future media commands yet will successfully respond to TUR,
      INQUIRY and ABORT leading eventually to target failure through several
      abort-cycle loops.
      
      The open retry interval is exceedingly short resulting in occasional target
      drop-off during expander resets or when targets push-back during bad-block
      remapping. Increased effective timeout from 130ms to 1.5 seconds for each try
      so as to trigger after the administrative inquiry/tur timeout in the scsi
      subsystem to keep error-recovery harmonics to a minimum.
      
      When an open retry timeout event is received, the action required by the
      targets is to issue an abort for the outstanding command then logic suggests
      we retry the command as this state is usually an indication of a credit block
      or busy condition on the target.
      
      We hijacked the pm8001_handle_event work queue handler so that it will handle
      task as an argument instead of device for the workers in support of the
      deferred handling outlined above.
      
      Moderate to Heavy bad-path testing on a 2.6.32 vintage kernel, compile-testing
      on scsi-misc-2.6 kernel ...
      Signed-off-by: NMark Salyzyn <mark_salyzyn@xyratex.com>
      Acked-by: NJack Wang <jack_wang@usish.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      5954d738
    • M
      [SCSI] pm8001: Add FUNC_GET_EVENTS · d95d0001
      Mark Salyzyn 提交于
      Jack noticed I dropped a patch fragment associated with a flags automatic
      variable in mpi_set_phys_g3_with_ssc (ooops) and that the pre-emptive locking
      that piggy-backed this patch was not in-fact necessary because of underlying
      atomic accesses to the hardware. Here is the updated patch fixing these two
      issues.
      
      The pm8001 driver is missing the FUNC_GET_EVENTS handler in the phy control
      function. Since the pm8001_bar4_shift function was not designed to be called
      at runtime, added locking surrounding the adjustment for all accesses.
      Signed-off-by: NMark Salyzyn <mark_salyzyn@xyratex.com>
      Acked-by: NJack Wang <jack_wang@usish.com>
      Signed-off-by: NJames Bottomley <JBottomley@Parallels.com>
      d95d0001
  3. 03 10月, 2011 1 次提交
  4. 27 7月, 2011 1 次提交
  5. 31 3月, 2011 1 次提交
  6. 13 2月, 2011 1 次提交
    • T
      [SCSI] pm8001: simplify workqueue usage · 429305e4
      Tejun Heo 提交于
      pm8001 manages its own list of pending works and cancel them on device
      free.  It is unnecessarily complex and has a race condition - the
      works are canceled but not synced, so the work could still be running
      during and after the data structures are freed.
      
      This patch simplifies workqueue usage.
      
      * A driver specific workqueue pm8001_wq is created to serve these
        work items.
      
      * To avoid confusion, the "queue" suffixes are dropped from work items
        and functions.
      
      * Delayed queueing was never used.  pm8001_work now uses work_struct
        instead.
      
      * The driver no longer keeps track of pending works.  All pm8001_works
        are queued to pm8001_wq and the workqueue is flushed as necessary.
      
      flush_scheduled_work() usage is removed during conversion.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Acked-by: NJack Wang <jack_wang@usish.com>
      Signed-off-by: NJames Bottomley <James.Bottomley@suse.de>
      429305e4
  7. 18 11月, 2010 1 次提交
  8. 11 12月, 2009 3 次提交
  9. 05 12月, 2009 3 次提交