提交 · f6c64c6fc8d793b414446f1a655a37b7bfce68e3 · openanolis / cloud-kernel

07 2月, 2013 6 次提交

leds-lp55xx: do chip specific configuration on device init · f6c64c6f

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 Chip specific function is configured when the device is initialized.
 So _configure() is moved to each device init function.

 If chip configuration gets failed, the device is de-initialized in
 each _init_device(), not probe().

 For compile error fix, function type declarations are added.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

f6c64c6f

leds-lp55xx: add device reset function in lp5521/5523 · 86eb7748

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 Use explicit each driver function rather than raw command.
 These function will be merged into the lp55xx common driver.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

86eb7748

leds-lp55xx: clean up deinit leds in lp5521/5523 · 1904f83d

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 To make LED unregistration code simple, new function, _unregister_leds()
 is added in each driver.
 This patch is a preceding step for lp55xx common driver architecture.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

1904f83d

leds-lp55xx: clean up init leds in lp5521/5523 · f6524808

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 To make LED initialization code simple, new function, _register_leds()
 is added at each driver.
 This patch is a preceding step for lp55xx common driver architecture.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

f6524808

leds-lp55xx: clean up deinit_device() in lp5521/5523 · 1a991485

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 Device de-initialization code is moved to _deinit_device() at each driver.
 This patch is a preceding step for lp55xx common driver architecture.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

1a991485

leds-lp55xx: clean up init_device() in lp5521/5523 · 944f7b1d

由 Milo(Woogyom) Kim 提交于 2月 05, 2013

 To make _probe() simple, device initialization code is moved to
 _init_device() at each driver.
 This patch is a preceding step for lp55xx common driver architecture.

 leds-lp5521:
 When 'lp5521_init_device()' gets failed, error handling should be 'fail1'
 rather than 'fail2'.
   fail1: releasing platform resource and return code
   fail2: releasing allocated LED devices with handling 'fail1'
 The 'lp5521_init_device()' is called before creating LED devices.
 Thus, 'goto fail1' is proper error handler of this function.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

944f7b1d

02 2月, 2013 14 次提交

leds: wm831x: add missing const · 8a4529a3

由 Jingoo Han 提交于 1月 21, 2013

Fixed the checkpatch warning as below:

  WARNING: static const char * array should probably be static const char * const
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

8a4529a3

leds: leds-ss4200: use DEFINE_PCI_DEVICE_TABLE · d7789430

由 Jingoo Han 提交于 1月 21, 2013

This macro is used to create a struct pci_device_id array.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

d7789430

leds: pca9532: fix suspect code indent for conditional statements · 962363ce

由 Jingoo Han 提交于 1月 21, 2013

Fixed the checkpatch warning as below:

  WARNING: suspect code indent for conditional statements (8, 8)
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

962363ce

leds: lm3642: rename devAttr to avoid CamelCase · 85b4b756

由 Jingoo Han 提交于 1月 21, 2013

Fixed the checkpatch warning as below:

  WARNING: Avoid CamelCase: <devAttr>

Rename devAttr to attr.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

85b4b756

leds: lm355x: rename devAttr to avoid CamelCase · 0c0d9067

由 Jingoo Han 提交于 1月 21, 2013

Fixed the checkpatch warning as below:

  WARNING: Avoid CamelCase: <devAttr>

Rename devAttr to attr.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

0c0d9067

leds: renesas-tpu: Improve the readability to pick the lowest acceptable rate · 4d798332

由 Axel Lin 提交于 1月 10, 2013

I spent a few minutes to understand why the code catching the mismatch case
by checking if k is 0 or not. And the code using "k - 1" as array index is
unusual.

This patch checks acceptable rate from the lowest rate, and then we don't need
to subtract k by 1. This change improves the readability.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

4d798332

leds: lm3530: Ensure drvdata->enable has correct status if regulator_disable fails · 5e3b7c6b

由 Axel Lin 提交于 12月 19, 2012

Add lm3530_led_enable() and lm3530_led_disable() helper functions.
This ensures setting drvdata->enable to correct status if regulator_disable
fails.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Acked-by: NShreshtha Kumar SAHU <shreshthakumar.sahu@stericsson.com>
Acked-by: NMilo Kim <milo.kim@ti.com>
Tested-by: NMilo Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

5e3b7c6b

leds-lp8788: fix a parent device in _probe() · a1932edf

由 Kim, Milo 提交于 1月 02, 2013

The lp8788-keyled is a platform driver of lp8788-mfd. The platform
device is allocated when mfd_add_devices() is called in lp8788-mfd.
On the other hand, 'lp->dev' is the i2c client device.

Therefore, this 'platform_device' is a proper parent device in case
of resource managed mem alloc, registering led device and device
kernel messages.
Signed-off-by: NMilo(Woogyom) Kim <milo.kim@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

a1932edf

leds: leds-pwm: Add device tree bindings · 08541cbc

由 Peter Ujfalusi 提交于 12月 21, 2012

The DT binding for the pwm-leds devices are similar to the gpio-leds type.
LEDs are represented as sub-nodes of the pwm-leds device.
The code for handling the DT boot is based on the code found in the
leds-gpio driver and adapted to use PWMs instead of GPIOs.
To avoid having custom cleanup code in case of DT boot the newly created
devm_of_pwm_get() API is used to get the correct PWM instance.

For usage see:
Documentation/devicetree/bindings/leds/leds-pwm.txt
Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Acked-by: NGrant Likely <grant.likely@secretlab.ca>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

08541cbc

leds: leds-pwm: Simplify cleanup code · 8a66a579

由 Peter Ujfalusi 提交于 12月 21, 2012

The code looks more nicer if we use:

while (i--)

instead:
if (i > 0)
	for (i = i - 1; i >= 0; i--)
Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

8a66a579

leds: leds-pwm: Preparing the driver for device tree support · 0f86815a

由 Peter Ujfalusi 提交于 12月 21, 2012

In order to be able to add device tree support for leds-pwm driver we need
to rearrange the data structures used by the drivers.
Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

0f86815a

leds: leds-pwm: Convert to use devm_get_pwm · 9ea6cdac

由 Peter Ujfalusi 提交于 12月 21, 2012

Update the driver to use the new API for requesting pwm so we can take
advantage of the pwm_lookup table to find the correct pwm to be used for the
LED functionality.
Signed-off-by: NPeter Ujfalusi <peter.ujfalusi@ti.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

9ea6cdac

A
leds: pca9532: Convert to devm_input_allocate_device() · 8614fb46
由 Axel Lin 提交于 12月 25, 2012
```
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>
```
8614fb46

leds/tca6507: Add support for devicetree. · 0c596a7e

由 Marek Belisko 提交于 11月 30, 2012

Support added only for leds (not for gpio's).

(cooloney@gmail.com: fix 2 building errors)
Signed-off-by: NMarek Belisko <marek.belisko@open-nandra.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

0c596a7e

03 1月, 2013 1 次提交

leds: leds-gpio: set devm_gpio_request_one() flags param correctly · 2d7c22f6

由 Javier Martinez Canillas 提交于 12月 20, 2012

commit a99d76f9 leds: leds-gpio: use gpio_request_one

changed the leds-gpio driver to use gpio_request_one() instead
of gpio_request() + gpio_direction_output()

Unfortunately, it also made a semantic change that breaks the
leds-gpio driver.

The gpio_request_one() flags parameter was set to:

GPIOF_DIR_OUT | (led_dat->active_low ^ state)

Since GPIOF_DIR_OUT is 0, the final flags value will just be the
XOR'ed value of led_dat->active_low and state.

This value were used to distinguish between HIGH/LOW output initial
level and call gpio_direction_output() accordingly.

With this new semantic gpio_request_one() will take the flags value
of 1 as a configuration of input direction (GPIOF_DIR_IN) and will
call gpio_direction_input() instead of gpio_direction_output().

int gpio_request_one(unsigned gpio, unsigned long flags, const char *label)
{
..
	if (flags & GPIOF_DIR_IN)
		err = gpio_direction_input(gpio);
	else
		err = gpio_direction_output(gpio,
				(flags & GPIOF_INIT_HIGH) ? 1 : 0);
..
}

The right semantic is to evaluate led_dat->active_low ^ state and
set the output initial level explicitly.
Signed-off-by: NJavier Martinez Canillas <javier.martinez@collabora.co.uk>
Reported-by: NArnaud Patard <arnaud.patard@rtp-net.org>
Tested-by: NEzequiel Garcia <ezequiel.garcia@free-electrons.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

2d7c22f6

04 12月, 2012 1 次提交

leds: leds-lp5521: return an error code on error in probe() · 2f05e1d4

由 Dan Carpenter 提交于 12月 02, 2012

If "buf" wasn't equal to LP5521_REG_R_CURR_DEFAULT the probe fails but
we still return zero.  I've changed it to print an error message and
return -EINVAL.
Reported-by: NBen Hutchings <ben@decadent.org.uk>
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

2f05e1d4

29 11月, 2012 5 次提交

leds: leds-clevo-mail: Use pr_* instead of printks · 5c6f844c

由 Sachin Kamat 提交于 11月 27, 2012

Silences checkpatch warnings related to the use of printks.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

5c6f844c

leds: leds-rb532: Fix checkpatch errors · 7a0eff4d

由 Sachin Kamat 提交于 11月 27, 2012

Fixes the following issues:
ERROR: code indent should use tabs where possible
WARNING: please, no spaces at the start of a line
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NBryan Wu <cooloney@gmail.com>

7a0eff4d

leds: remove use of __devexit · 678e8a6b

由 Bill Pemberton 提交于 11月 19, 2012

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>
Acked-by: NBryan Wu <cooloney@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

678e8a6b

leds: remove use of __devinit · 98ea1ea2

由 Bill Pemberton 提交于 11月 19, 2012

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>
Acked-by: NBryan Wu <cooloney@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

98ea1ea2

leds: remove use of __devexit_p · df07cf81

由 Bill Pemberton 提交于 11月 19, 2012

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Cc: Richard Purdie <rpurdie@rpsys.net>
Cc: Jan-Simon Moeller <jansimon.moeller@gmx.de>
Acked-by: NBryan Wu <cooloney@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

df07cf81

28 11月, 2012 13 次提交

leds: led-triggers: Fix checkpatch warnings · 09f5fe75