1. 21 12月, 2006 1 次提交
    • V
      kref refcnt and false positives · f334b60b
      Venkatesh Pallipadi 提交于
      With WARN_ON addition to kobject_init()
      [ http://kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.19/2.6.19-mm1/dont-use/broken-out/gregkh-driver-kobject-warn.patch ]
      
      I started seeing following WARNING on CPU offline followed by online on my
      x86_64 system.
      
      WARNING at lib/kobject.c:172 kobject_init()
      
      Call Trace:
       [<ffffffff8020ab45>] dump_trace+0xaa/0x3ef
       [<ffffffff8020aec4>] show_trace+0x3a/0x50
       [<ffffffff8020b0f6>] dump_stack+0x15/0x17
       [<ffffffff80350abc>] kobject_init+0x3f/0x8a
       [<ffffffff80350be1>] kobject_register+0x1a/0x3e
       [<ffffffff803bbd89>] sysdev_register+0x5b/0xf9
       [<ffffffff80211d0b>] mce_create_device+0x77/0xf4
       [<ffffffff80211dc2>] mce_cpu_callback+0x3a/0xe5
       [<ffffffff805632fd>] notifier_call_chain+0x26/0x3b
       [<ffffffff8023f6f3>] raw_notifier_call_chain+0x9/0xb
       [<ffffffff802519bf>] _cpu_up+0xb4/0xdc
       [<ffffffff80251a12>] cpu_up+0x2b/0x42
       [<ffffffff803bef00>] store_online+0x4a/0x72
       [<ffffffff803bb6ce>] sysdev_store+0x24/0x26
       [<ffffffff802baaa2>] sysfs_write_file+0xcf/0xfc
       [<ffffffff8027fc6f>] vfs_write+0xae/0x154
       [<ffffffff80280418>] sys_write+0x47/0x6f
       [<ffffffff8020963e>] system_call+0x7e/0x83
      DWARF2 unwinder stuck at system_call+0x7e/0x83
      Leftover inexact backtrace:
      
      This is a false positive as mce.c is unregistering/registering sysfs
      interfaces cleanly on hotplug.
      
      kref_put() and conditional decrement of refcnt seems to be the root cause
      for this and the patch below resolves the issue for me.
      Signed-off-by: NVenkatesh Pallipadi <venkatesh.pallipadi@intel.com>
      Signed-off-by: NAndrew Morton <akpm@osdl.org>
      Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>
      
      f334b60b
  2. 20 12月, 2006 1 次提交
  3. 18 12月, 2006 35 次提交
  4. 17 12月, 2006 3 次提交
    • L
      Fix up mm/mincore.c error value cases · 4fb23e43
      Linus Torvalds 提交于
      Hugh Dickins correctly points out that mincore() is actually _supposed_
      to fail on an unmapped hole in the user address space, rather than
      return valid ("empty") information about the hole.  This just simplifies
      the problem further (I had been misled by our previous confusing and
      complicated way of doing mincore()).
      
      Also, in the unlikely situation that we can't allocate a temporary
      kernel buffer, we should actually return EAGAIN, not ENOMEM, to keep the
      "unmapped hole" and "allocation failure" error cases separate.
      
      Finally, add a comment about our stupid historical lack of support for
      anonymous mappings.  I'll fix that if somebody reminds me after 2.6.20
      is out.
      Acked-by: NHugh Dickins <hugh@veritas.com>
      Signed-off-by: NLinus Torvalds <torvalds@osdl.org>
      4fb23e43
    • L
      Merge branch 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband · c7ef259b
      Linus Torvalds 提交于
      * 'for-linus' of master.kernel.org:/pub/scm/linux/kernel/git/roland/infiniband:
        IB/mthca: Use DEFINE_MUTEX() instead of mutex_init()
        IB/mthca: Add HCA profile module parameters
        IB/srp: Fix FMR mapping for 32-bit kernels and addresses above 4G
        IB: Fix ib_dma_alloc_coherent() wrapper
      c7ef259b
    • L
      Merge branch 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev · 99f5e971
      Linus Torvalds 提交于
      * 'upstream-linus' of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev:
        [PATCH] pata_via: Cable detect error
        [PATCH] Fix help text for CONFIG_ATA_PIIX
        [PATCH] initializer entry defined twice in pata_rz1000
        [PATCH] ata: fix platform_device_register_simple() error check
        [PATCH] ahci: do not mangle saved HOST_CAP while resetting controller
        [PATCH] libata: don't initialize sg in ata_exec_internal() if DMA_NONE (take #2)
        [libata] sata_svw: Disable ATAPI DMA on current boards (errata workaround)
        [libata] use kmap_atomic(KM_IRQ0) in SCSI simulator
        [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops
        [PATCH] ata_piix: IDE mode SATA patch for Intel ICH9
      99f5e971