1. 29 1月, 2008 3 次提交
    • D
      [ATM]: Simplify /proc/net/atm/arp opening · ae22120a
      Denis V. Lunev 提交于
      The iterator state->ns.neigh_sub_iter initialization is moved from
      arp_seq_open to clip_seq_start for convinience. This should not be a
      problem as the iterator will be used only after the seq_start
      callback.
      Signed-off-by: NDenis V. Lunev <den@openvz.org>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ae22120a
    • E
      [NETNS]: Add netns parameter to inet_(dev_)add_type. · 6b175b26
      Eric W. Biederman 提交于
      The patch extends the inet_addr_type and inet_dev_addr_type with the
      network namespace pointer. That allows to access the different tables
      relatively to the network namespace.
      
      The modification of the signature function is reported in all the
      callers of the inet_addr_type using the pointer to the well known
      init_net.
      Acked-by: NBenjamin Thery <benjamin.thery@bull.net>
      Acked-by: NDaniel Lezcano <dlezcano@fr.ibm.com>
      Signed-off-by: NEric W. Biederman <ebiederm@xmission.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6b175b26
    • E
      [NETNS]: Modify the neighbour table code so it handles multiple network namespaces · 426b5303
      Eric W. Biederman 提交于
      I'm actually surprised at how much was involved.  At first glance it
      appears that the neighbour table data structures are already split by
      network device so all that should be needed is to modify the user
      interface commands to filter the set of neighbours by the network
      namespace of their devices.
      
      However a couple things turned up while I was reading through the
      code.  The proxy neighbour table allows entries with no network
      device, and the neighbour parms are per network device (except for the
      defaults) so they now need a per network namespace default.
      
      So I updated the two structures (which surprised me) with their very
      own network namespace parameter.  Updated the relevant lookup and
      destroy routines with a network namespace parameter and modified the
      code that interacts with users to filter out neighbour table entries
      for devices of other namespaces.
      
      I'm a little concerned that we can modify and display the global table
      configuration and from all network namespaces.  But this appears good
      enough for now.
      
      I keep thinking modifying the neighbour table to have per network
      namespace instances of each table type would should be cleaner.  The
      hash table is already dynamically sized so there are it is not a
      limiter.  The default parameter would be straight forward to take care
      of.  However when I look at the how the network table is built and
      used I still find some assumptions that there is only a single
      neighbour table for each type of table in the kernel.  The netlink
      operations, neigh_seq_start, the non-core network users that call
      neigh_lookup.  So while it might be doable it would require more
      refactoring than my current approach of just doing a little extra
      filtering in the code.
      Signed-off-by: NEric W. Biederman <ebiederm@xmission.com>
      Signed-off-by: NDaniel Lezcano <dlezcano@fr.ibm.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      426b5303
  2. 11 10月, 2007 2 次提交
  3. 11 7月, 2007 1 次提交
  4. 26 4月, 2007 2 次提交
  5. 26 3月, 2007 1 次提交
    • A
      [NET]: Fix neighbour destructor handling. · ecbb4169
      Alexey Kuznetsov 提交于
      ->neigh_destructor() is killed (not used), replaced with
      ->neigh_cleanup(), which is called when neighbor entry goes to dead
      state. At this point everything is still valid: neigh->dev,
      neigh->parms etc.
      
      The device should guarantee that dead neighbor entries (neigh->dead !=
      0) do not get private part initialized, otherwise nobody will cleanup
      it.
      
      I think this is enough for ipoib which is the only user of this thing.
      Initialization private part of neighbor entries happens in ipib
      start_xmit routine, which is not reached when device is down.  But it
      would be better to add explicit test for neigh->dead in any case.
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      ecbb4169
  6. 13 2月, 2007 1 次提交
  7. 03 12月, 2006 2 次提交
  8. 18 9月, 2006 1 次提交
  9. 22 7月, 2006 1 次提交
  10. 10 7月, 2006 1 次提交
    • A
      [ATM] net/atm/clip.c: fix PROC_FS=n compile · 24781734
      Adrian Bunk 提交于
      This patch fixes the following compile error with CONFIG_PROC_FS=n by 
      reverting commit dcdb0275:
      
      <--  snip  -->
      
      ...
        CC      net/atm/clip.o
      net/atm/clip.c: In function ‘atm_clip_init’:
      net/atm/clip.c:975: error: ‘atm_proc_root’ undeclared (first use in this function)
      net/atm/clip.c:975: error: (Each undeclared identifier is reported only once
      net/atm/clip.c:975: error: for each function it appears in.)
      net/atm/clip.c:977: error: ‘arp_seq_fops’ undeclared (first use in this function)
      make[2]: *** [net/atm/clip.o] Error 1
      
      <--  snip  -->
      Signed-off-by: NAdrian Bunk <bunk@stusta.de>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      24781734
  11. 04 7月, 2006 1 次提交
  12. 01 7月, 2006 1 次提交
  13. 18 6月, 2006 1 次提交
    • H
      [NET]: Add netif_tx_lock · 932ff279
      Herbert Xu 提交于
      Various drivers use xmit_lock internally to synchronise with their
      transmission routines.  They do so without setting xmit_lock_owner.
      This is fine as long as netpoll is not in use.
      
      With netpoll it is possible for deadlocks to occur if xmit_lock_owner
      isn't set.  This is because if a printk occurs while xmit_lock is held
      and xmit_lock_owner is not set can cause netpoll to attempt to take
      xmit_lock recursively.
      
      While it is possible to resolve this by getting netpoll to use
      trylock, it is suboptimal because netpoll's sole objective is to
      maximise the chance of getting the printk out on the wire.  So
      delaying or dropping the message is to be avoided as much as possible.
      
      So the only alternative is to always set xmit_lock_owner.  The
      following patch does this by introducing the netif_tx_lock family of
      functions that take care of setting/unsetting xmit_lock_owner.
      
      I renamed xmit_lock to _xmit_lock to indicate that it should not be
      used directly.  I didn't provide irq versions of the netif_tx_lock
      functions since xmit_lock is meant to be a BH-disabling lock.
      
      This is pretty much a straight text substitution except for a small
      bug fix in winbond.  It currently uses
      netif_stop_queue/spin_unlock_wait to stop transmission.  This is
      unsafe as an IRQ can potentially wake up the queue.  So it is safer to
      use netif_tx_disable.
      
      The hamradio bits used spin_lock_irq but it is unnecessary as
      xmit_lock must never be taken in an IRQ handler.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      932ff279
  14. 13 5月, 2006 1 次提交
    • S
      [NEIGH]: Fix IP-over-ATM and ARP interaction. · bd89efc5
      Simon Kelley 提交于
      The classical IP over ATM code maintains its own IPv4 <-> <ATM stuff>
      ARP table, using the standard neighbour-table code. The
      neigh_table_init function adds this neighbour table to a linked list
      of all neighbor tables which is used by the functions neigh_delete()
      neigh_add() and neightbl_set(), all called by the netlink code.
      
      Once the ATM neighbour table is added to the list, there are two
      tables with family == AF_INET there, and ARP entries sent via netlink
      go into the first table with matching family. This is indeterminate
      and often wrong.
      
      To see the bug, on a kernel with CLIP enabled, create a standard IPv4
      ARP entry by pinging an unused address on a local subnet. Then attempt
      to complete that entry by doing
      
      ip neigh replace <ip address> lladdr <some mac address> nud reachable
      
      Looking at the ARP tables by using 
      
      ip neigh show
      
      will reveal two ARP entries for the same address. One of these can be
      found in /proc/net/arp, and the other in /proc/net/atm/arp.
      
      This patch adds a new function, neigh_table_init_no_netlink() which
      does everything the neigh_table_init() does, except add the table to
      the netlink all-arp-tables chain. In addition neigh_table_init() has a
      check that all tables on the chain have a distinct address family.
      The init call in clip.c is changed to call
      neigh_table_init_no_netlink().
      
      Since ATM ARP tables are rather more complicated than can currently be
      handled by the available rtattrs in the netlink protocol, no
      functionality is lost by this patch, and non-ATM ARP manipulation via
      netlink is rescued. A more complete solution would involve a rtattr
      for ATM ARP entries and some way for the netlink code to give
      neigh_add and friends more information than just address family with
      which to find the correct ARP table.
      
      [ I've changed the assertion checking in neigh_table_init() to not
        use BUG_ON() while holding neigh_tbl_lock.  Instead we remember that
        we found an existing tbl with the same family, and after dropping
        the lock we'll give a diagnostic kernel log message and a stack dump.
        -DaveM ]
      Signed-off-by: NSimon Kelley <simon@thekelleys.org.uk>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      bd89efc5
  15. 15 4月, 2006 6 次提交
  16. 21 3月, 2006 1 次提交
  17. 12 1月, 2006 1 次提交
  18. 04 10月, 2005 1 次提交
    • H
      [IPV4]: Replace __in_dev_get with __in_dev_get_rcu/rtnl · e5ed6399
      Herbert Xu 提交于
      The following patch renames __in_dev_get() to __in_dev_get_rtnl() and
      introduces __in_dev_get_rcu() to cover the second case.
      
      1) RCU with refcnt should use in_dev_get().
      2) RCU without refcnt should use __in_dev_get_rcu().
      3) All others must hold RTNL and use __in_dev_get_rtnl().
      
      There is one exception in net/ipv4/route.c which is in fact a pre-existing
      race condition.  I've marked it as such so that we remember to fix it.
      
      This patch is based on suggestions and prior work by Suzanne Wood and
      Paul McKenney.
      Signed-off-by: NHerbert Xu <herbert@gondor.apana.org.au>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e5ed6399
  19. 17 4月, 2005 1 次提交
    • L
      Linux-2.6.12-rc2 · 1da177e4
      Linus Torvalds 提交于
      Initial git repository build. I'm not bothering with the full history,
      even though we have it. We can create a separate "historical" git
      archive of that later if we want to, and in the meantime it's about
      3.2GB when imported into git - space that would just make the early
      git days unnecessarily complicated, when we don't have a lot of good
      infrastructure for it.
      
      Let it rip!
      1da177e4