This patch removes SIOCDEVPRIVATE + 1 ioctl.  It currently is just a
stub which does some useless printks and returns.  In the original code,
if the user passes priv_cmd.total_len == 0 then it will Oops.  Also it
leaks memory every time it's called.  In the future, we will implement
this functionality using generic API functions
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes unwanted true and false from boolean tests.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch assign proper boolean value to boolean variable.
Signed-off-by: NAbdul Hussain <habdul@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Align some defines in linux_wlan_common.h
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rework line '#include "wilc_oswrapper.h"'
it does not used anywhere after change own data type to common data type.
Signed-off-by: NDean Lee <dean.lee@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This fixes the memory corruption case, if nbytes is less than offset
and sizeof(struct channel_header)
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NJes Sorensen <Jes.Sorensen@redhat.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This driver creates a network device when s-Par sends a device
create message to create network adapter on the visorbus. When
the message is received by visorbus, the visornic_probe function
is called and the netdev device is created and managed by the
visornic driver.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

During testing with visornic the offset of num_rcv_bufs
was being reported at 188 instead of 186. The vnic structure
starts at 180 and the macaddr is only 6 bytes long.

When I defined and packed the structures outside of the struct
and then referenced them in the struct the correct offset
was generated.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Visorchannel directory has been stripped down to almost nothing, and is
no longer referenced. This finishes getting rid of the directory.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The efi framebuffer is defined within the s-Par video channel
console. Before we get the device create message for the video
console, s-Par has alreaady informed linux about the efi
framebuffer and a memory region is already set up for it. Since
we do not use the video channel in linux, we are just ignoring
the failure of the video channel request_mem_region.

Testing: This patch was tested on top of s-Par and we no longer
leave the partition in a failed state.
Signed-off-by: NDavid Kershner <david.kershner@unisys.com>
Signed-off-by: NBenjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Also, remove rt_multi_func enum used exclusively by the killed macros.
Signed-off-by: NJakub Sitnicki <jsitnicki@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch fixes a typo in the comment section.
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch replaces hard coded values with global definitions for the
Ethernet IEEE 802.3 interface defined in standard header file.
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes commented code warned by checkpatch.pl
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes commented code.This was a checkpatch warning.
Signed-off-by: NHari Prasath Gujulan Elango <hgujulan@visteon.com>
Reviewed-by: NIan Abbott <abbotti@mev.co.uk>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

kmalloc() returns void pointer.
Signed-off-by: NChengYi He <chengyihetaipei@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove space prohibited between function name and open parenthesis.
Signed-off-by: NSunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Remove the warnings for multiple blank lines reported by checkpatch.pl.
Signed-off-by: NSunghoon Cho <ywhsbliss@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Align the lines of some defines in wilc_errorsupport.h
Signed-off-by: NChaehyun Lim <chaehyun.lim@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

change own data type(WILC_Char) to common data type(char)
Signed-off-by: NDean Lee <dean.lee@atmel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Change comment style and remove extra spaces before macro names to
avoid exceeding 80 characters.
Signed-off-by: Nmatt mooney <mfm@muteddisk.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

If CONFIG_88EU_AP_MODE is undefined, OnAuth() is never referenced.

Fixes warning:
  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:2725:21: warning: ‘OnAuth’ defined but not used [-Wunused-function]
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Fixes: 68345dd7 ("staging: rtl8188eu: rtw_mlme_ext.c: unexport message callbacks")
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

If CONFIG_88EU_AP_MODE is undefined, issue_asocrsp() is never referenced.

Fixes warning:
  drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:891:13: warning: ‘issue_asocrsp’ defined but not used [-Wunused-function]
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Fixes: 782eddd7 ("staging: rtl8188eu: unexport internal functions")
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Cc: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the warning "space prohibited between
function name and open parenthesis"given by checkpatch.pl
Signed-off-by: NJoglekar Tejas <tjogleka@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

This patch removes the error given by checkpatch.pl
" spaces required around that '>' "
Signed-off-by: NJoglekar Tejas <tjogleka@visteon.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Typo in a comment to register write corrected.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Added spaces after commas in initialization sequences and removed
unnecessary line continuations.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Placed comments to register writes before the function calls to
eliminate long strings and make code more readable.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Eliminated code duplication when searching for a display.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The patch removes spaces before tabs so that checkpatch.pl is content.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Removed unnecessary line continuations in several lines.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split module description strings are merged for searchability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Indentation with spaces fixed.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Put spaces around assignment operators for readability.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Split long function declarations, function calls, comments etc.
Signed-off-by: NAnton Gerasimov <anton.gerasimov@openmailbox.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "Missing a blank line after declarations"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fix coding style issue "braces {} are not necessary for single statement blocks"
detected by checkpatch.pl in visorchipset.c
Signed-off-by: NAlessandro Parini <alessandro.parini@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

buf_unalloc is essentially a vme_free_consistent:
1) image[i].kern_buf is never NULL in buf_alloc call
2) kern_buf, pci_buf and size_buf get zeroed in vme_user_probe anyway
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Checking for image[minor].resource != NULL is not needed since all
resources are allocated before device is created.

image[minor].users accounting is deleted because it's not being used.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Reorder code so that forward declarations are not needed.
Signed-off-by: NDmitry Kalinkin <dmitry.kalinkin@gmail.com>
Cc: Igor Alekseev <igor.alekseev@itep.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>