1. 04 11月, 2014 8 次提交
    • M
      [media] cx231xx: Cleanup printk at the driver · ed0e3729
      Mauro Carvalho Chehab 提交于
      There are lots of debug printks printed with pr_info. Also, the
      printk's data are not too coherent:
      
      - there are duplicated driver name at the print format;
      - function name format string differs from function to function;
      - long strings broken into multiple lines;
      - some printks just produce ugly reports, being almost useless
        as-is.
      
      Do a cleanup on that.
      
      Still, there are much to be done in order to do a better printk
      job on this driver, but, at least it will now be a way less
      verbose, if debug printks are disabled, and some logs might
      actually be useful.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      ed0e3729
    • M
      [media] cx231xx: Fix identation · 88538bb5
      Mauro Carvalho Chehab 提交于
      One of the identation blocks is wrong. Fix it.
      
      While here, replace pr_info by pr_debug inside such block and
      add the function name to the print messages, as otherwise they
      will not help much.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      88538bb5
    • M
      [media] cx231xx: get rid of driver-defined printk macros · 589dadf2
      Mauro Carvalho Chehab 提交于
      It currently does just like what pr_foo() macros do. So,
      replace them.
      
      A deeper cleanup is needed, as there are lots of debug macros
      printed with pr_info.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      589dadf2
    • M
      [media] fix a warning on avr32 arch · f2dd851f
      Mauro Carvalho Chehab 提交于
      X-Patchwork-Delegate: m.chehab@samsung.com
      on avr32 arch, those warnings happen:
      	drivers/media/firewire/firedtv-fw.c: In function 'node_update':
      	drivers/media/firewire/firedtv-fw.c:329: warning: comparison is always true due to limited range of data type
      
      In this particular case, the signal is desired, as the isochannel
      var can be initalized with -1 inside the driver.
      
      So, change the type to s8, to avoid issues on archs where char
      is unsigned.
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      Reviewed-by: NStefan Richter <stefanr@s5r6.in-berlin.de>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      f2dd851f
    • G
      [media] V4L2: fix VIDIOC_CREATE_BUFS 32-bit compatibility mode data copy-back · 6ed9b285
      Guennadi Liakhovetski 提交于
      Similar to an earlier patch, fixing reading user-space data for the
      VIDIOC_CREATE_BUFS ioctl() in 32-bit compatibility mode, this patch fixes
      writing back of the possibly modified struct to the user. However, unlike
      the former bug, this one is much less harmful, because it only results in
      the kernel failing to write the .type field back to the user, but in fact
      this is likely unneeded, because the kernel will hardly want to change
      that field. Therefore this bug is more of a theoretical nature.
      Signed-off-by: NGuennadi Liakhovetski <g.liakhovetski@gmx.de>
      Acked-by: NLaurent Pinchart <laurent.pinchart@ideasonboard.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      6ed9b285
    • D
      [media] stv090x: remove indent levels in stv090x_get_coldlock() · 66ae9fc2
      Dan Carpenter 提交于
      This code is needlessly complicated and checkpatch.pl complains that we
      go over the 80 characters per line limit.
      
      If we flip the "if (!lock) {" test to "if (lock) return;" then we can
      remove an indent level from the rest of the function.
      
      We can add two returns in the "if (state->srate >= 10000000) {"
      condition and move the else statement back an additional indent level.
      
      There is another "if (!lock) {" check which can be removed since we have
      already checked "lock" and know it is zero at this point.  This second
      check on "lock" is also a problem because it sets off a static checker
      warning.  I have reviewed this code for some time to see if something
      else was intended, but have concluded that it was simply an oversight
      and should be removed.  Removing this duplicative check gains us an
      third indent level.
      Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      66ae9fc2
    • S
      [media] DocBook media: Clarify V4L2_FIELD_ANY for drivers · 9fd1f310
      Simon Farnsworth 提交于
      Documentation for enum v4l2_field did not make it clear that V4L2_FIELD_ANY
      is only acceptable as input to the kernel, not as a response from the
      driver.
      
      Make it clear, to stop userspace developers like me assuming it can be
      returned by the driver.
      Signed-off-by: NSimon Farnsworth <simon.farnsworth@onelan.co.uk>
      Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      9fd1f310
    • J
      [media] saa7146: turn bothersome error into a debug message · 847713ea
      Johann Klammer 提交于
      After updating the kernel to 3.14.15 I am seeing these messages:
      
      [273684.964081] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273690.020061] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273695.076082] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273700.132077] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273705.188070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273710.244066] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273715.300187] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273720.356068] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273725.412188] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273730.468094] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273735.524070] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      [273740.580176] saa7146: saa7146 (0): saa7146_wait_for_debi_done_sleep
      timed out while waiting for registers getting programmed
      
      filling up the logs(one about every 5 seconds).
      
      Other posts suggests that it is not actually an error on cards without a
      CI interface. Here's a patch that turns it into a debug message, so it
      does not clobber the logs.
      Signed-off-by: NJohann Klammer <klammerj@a1.net>
      Signed-off-by: NHans Verkuil <hans.verkuil@cisco.com>
      Signed-off-by: NMauro Carvalho Chehab <mchehab@osg.samsung.com>
      847713ea
  2. 03 11月, 2014 32 次提交