1. 09 9月, 2005 2 次提交
    • J
      [SCSI] SCSI core: fix leakage of scsi_cmnd's · e91442b6
      James Bottomley 提交于
      From: 	Alan Stern <stern@rowland.harvard.edu>
      
      This patch (as559b) adds a new routine, scsi_unprep_request, which
      gets called every place a request is requeued.  (That includes
      scsi_queue_insert as well as scsi_requeue_command.)  It also changes
      scsi_kill_requests to make it call __scsi_done with result equal to
      DID_NO_CONNECT << 16.  (I'm not sure if it's necessary to call
      scsi_init_cmd_errh here; maybe you can check on that.)  Finally, the
      patch changes the return value from scsi_end_request, to avoid
      returning a stale pointer in the case where the request was requeued.
      Fortunately the return value is used in only place, and the change
      actually simplified it.
      Signed-off-by: NAlan Stern <stern@rowland.harvard.edu>
      
      Rejections fixed up and
      Signed-off-by: NJames Bottomley <James.Bottomley@SteelEye.com>
      e91442b6
    • N
      [SCSI] fix possible deadlock in scsi_lib.c · 286f3e13
      Neil Brown 提交于
        If a filesystem, while writing out data, decides that it is good
      to issue a cache flush on a SCSI drive (or other 'sd' device), it will
      call blkdev_issue_flush which calls ->issue_flush_fn which is
      scsi_issue_flush_fn.
      This calls sd_issue_flush which calls sd_sync_cache, which calls
      scsi_execute_request.
      This will (as sshdr != NULL) call
          kmalloc(SCSI_SENSE_BUFFERSIZE, GFP_KERNEL)
      
      If memory is tight, the presence of GFP_KERNEL may cause write
      requests to be sent to some filesystem to free up memory, however if
      that filesystem is waiting for the issue_flush_fn to complete, you
      could get a deadlock.
      
      I wonder if it might be more appropriate to use GFP_NOIO as in the
      following patch.
      
      I wonder if it might be even more appropriate to cope better with a
      kmalloc failure, especially as in this use, sd_sync_cache only will
      use the sense information to print out a more informative error
      message.
      Signed-off-by: NNeil Brown <neilb@suse.de>
      Signed-off-by: NJames Bottomley <James.Bottomley@SteelEye.com>
      286f3e13
  2. 07 9月, 2005 1 次提交
    • J
      [SCSI] quieten messages on scsi_execute commands · 3173d8c3
      James Bottomley 提交于
      scsi_io_completion() can be a bit noisy about certain conditions.
      Previously this wasn't a problem for internally generated commands,
      since they never hit it.  However, since we do all SCSI commands via
      bios, now they do.  user CD testers like magicdev are now getting not
      ready messages every time they touch the CD to see if there's anything
      in it.
      
      Fix this by making all scsi_execute commands REQ_QUIET and making
      scsi_finish_io() not say anything for REQ_QUIET.
      Signed-off-by: NJames Bottomley <James.Bottomley@SteelEye.com>
      3173d8c3
  3. 29 8月, 2005 5 次提交
  4. 28 8月, 2005 3 次提交
  5. 31 7月, 2005 1 次提交
  6. 14 7月, 2005 1 次提交
  7. 29 6月, 2005 1 次提交
  8. 27 6月, 2005 3 次提交
  9. 24 6月, 2005 1 次提交
  10. 21 5月, 2005 5 次提交
  11. 19 4月, 2005 2 次提交
  12. 17 4月, 2005 4 次提交