1. 10 11月, 2014 1 次提交
    • D
      mmc: dw_mmc: Remove old card detect infrastructure · 6130e7a9
      Doug Anderson 提交于
      The dw_mmc driver had a bunch of code that ran whenever a card was
      ejected and inserted.  However, this code was old and crufty and
      should be removed.  Some evidence that it's really not needed:
      
      1. Is is supposed to be legal to use 'cd-gpio' on dw_mmc instead of
         using the built-in card detect mechanism.  The 'cd-gpio' code
         doesn't run any of the crufty old code but yet still works.
      
      2. While looking at this, I realized that my old change (369ac861 mmc:
         dw_mmc: don't queue up a card detect at slot startup) actually
         castrated the old code a little bit already and nobody noticed.
         Specifically "last_detect_state" was left as 0 at bootup.  That
         means that on the first card removal none of the crufty code ran.
      
      3. I can run "while true; do dd if=/dev/mmcblk1 of=/dev/null; done"
         while ejecting and inserting an SD Card and the world doesn't
         explode.
      
      If some of the crufty old code is actually needed, we should justify
      it and also put it in some place where it will be run even with
      "cd-gpio".
      
      Note that in my case I'm using the "cd-gpio" mechanism but for various
      reasons the hardware triggers a dw_mmc "card detect" at bootup.  That
      was actually causing a real bug.  The card detect workqueue was
      running while the system was trying to enumerate the card.  The
      "present != slot->last_detect_state" triggered and we were doing all
      kinds of crazy stuff and messing up enumeration.  The new mechanism of
      just asking the core to check the card is much safer and then the
      bogus interrupt doesn't hurt.
      Signed-off-by: NDoug Anderson <dianders@chromium.org>
      Tested-by: NJaehoon Chung <jh80.chung@samsung.com>
      Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
      Tested-by: Nalim.akhtar <alim.akhtar@samsung.com>
      Signed-off-by: NUlf Hansson <ulf.hansson@linaro.org>
      6130e7a9
  2. 09 9月, 2014 1 次提交
  3. 11 8月, 2014 1 次提交
  4. 13 5月, 2014 1 次提交
  5. 04 3月, 2014 1 次提交
    • F
      mmc: dw_mmc: fix possible build error · 370aede6
      Felipe Balbi 提交于
      Fix the following build errors:
      
      drivers/mmc/host/dw_mmc-k3.c: In function ‘dw_mci_k3_suspend’:
      drivers/mmc/host/dw_mmc-k3.c:58:2: error: implicit declaration of
      	function ‘dw_mci_suspend’ [-Werror=implicit-function-declaration]
        ret = dw_mci_suspend(host);
        ^
      drivers/mmc/host/dw_mmc-k3.c: In function ‘dw_mci_k3_resume’:
      drivers/mmc/host/dw_mmc-k3.c:76:2: error: implicit declaration of
      	function ‘dw_mci_resume’ [-Werror=implicit-function-declaration]
        return dw_mci_resume(host);
        ^
      drivers/mmc/host/dw_mmc-k3.c: At top level:
      drivers/mmc/host/dw_mmc-k3.c:53:12: warning: ‘dw_mci_k3_suspend’ defined
      	but not used [-Wunused-function]
       static int dw_mci_k3_suspend(struct device *dev)
                  ^
      drivers/mmc/host/dw_mmc-k3.c:65:12: warning: ‘dw_mci_k3_resume’ defined
      	but not used [-Wunused-function]
       static int dw_mci_k3_resume(struct device *dev)
                  ^
      Signed-off-by: NFelipe Balbi <balbi@ti.com>
      Acked-by: NJaehoon Chung <jh80.chung@samsung.com>
      Signed-off-by: NChris Ball <chris@printf.net>
      370aede6
  6. 26 2月, 2014 1 次提交
  7. 26 9月, 2013 3 次提交
  8. 28 6月, 2013 1 次提交
  9. 27 6月, 2013 1 次提交
  10. 13 4月, 2013 1 次提交
  11. 03 10月, 2012 1 次提交
  12. 26 3月, 2012 1 次提交
  13. 13 1月, 2012 1 次提交
  14. 27 10月, 2011 2 次提交
  15. 21 7月, 2011 2 次提交
  16. 16 3月, 2011 1 次提交
  17. 09 1月, 2011 1 次提交