1. 12 11月, 2010 2 次提交
  2. 11 11月, 2010 2 次提交
  3. 10 11月, 2010 1 次提交
  4. 09 11月, 2010 2 次提交
  5. 08 11月, 2010 5 次提交
  6. 07 11月, 2010 3 次提交
  7. 05 11月, 2010 2 次提交
    • D
      drm/i915: kill mappable/fenceable disdinction · 75e9e915
      Daniel Vetter 提交于
      a00b10c3 "Only enforce fence limits inside the GTT" also
      added a fenceable/mappable disdinction when binding/pinning buffers.
      This only complicates the code with no pratical gain:
      
      - In execbuffer this matters on for g33/pineview, as this is the only
        chip that needs fences and has an unmappable gtt area. But fences
        are only possible in the mappable part of the gtt, so need_fence
        implies need_mappable. And need_mappable is only set independantly
        with relocations which implies (for sane userspace) that the buffer
        is untiled.
      
      - The overlay code is only really used on i8xx, which doesn't have
        unmappable gtt. And it doesn't support tiled buffers, currently.
      
      - For all other buffers it's a bug to pass in a tiled bo.
      
      In short, this disdinction doesn't have any practical gain.
      
      I've also reverted mapping the overlay and context pages as possibly
      unmappable. It's not worth being overtly clever here, all the big
      gains from unmappable are for execbuf bos.
      
      Also add a comment for a clever optimization that confused me
      while reading the original patch by Chris Wilson.
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      75e9e915
    • D
      drm/i915: revert pageflip/mappable related abi breakage · 818f2a3c
      Daniel Vetter 提交于
      In a00b10c3 "Only enforce fence limits inside the GTT"
      Chris Wilson implemented an optimization to only pin framebuffers
      as mappable for crtc_set_base (but not for pageflips). This breaks
      the abi, eg: A double buffering mesa client might leave the last
      framebuffer in unmappable space on close. A subsequent glReadPix
      by a frontbuffer rendering client then goes boom. My pretty anal
      mappable/unmappable consistency checking detected this, see
      
      https://bugs.freedesktop.org/show_bug.cgi?id=31286
      
      Chris Wilson tried to fix this in 085ce264 by pinning
      tiled framebuffers into mappable space. This
      a) renders the original optimization of not forcing framebuffers
         for pageflipping clients into mappable pointless because all our
         scanout buffers are tiled by default.
      b) doesn't solve the problem for untiled framebuffers.
      
      So kill this. Emperically it's no gain anyway because framebuffers are
      being reused by the ddx and hence there's no chance for them to get
      constanly bounced between mappable and unmappable.
      Signed-off-by: NDaniel Vetter <daniel.vetter@ffwll.ch>
      Signed-off-by: NChris Wilson <chris@chris-wilson.co.uk>
      818f2a3c
  8. 04 11月, 2010 3 次提交
  9. 03 11月, 2010 1 次提交
  10. 02 11月, 2010 6 次提交
  11. 01 11月, 2010 5 次提交
  12. 31 10月, 2010 2 次提交
  13. 30 10月, 2010 6 次提交