1. 02 11月, 2008 1 次提交
    • A
      saner FASYNC handling on file close · 233e70f4
      Al Viro 提交于
      As it is, all instances of ->release() for files that have ->fasync()
      need to remember to evict file from fasync lists; forgetting that
      creates a hole and we actually have a bunch that *does* forget.
      
      So let's keep our lives simple - let __fput() check FASYNC in
      file->f_flags and call ->fasync() there if it's been set.  And lose that
      crap in ->release() instances - leaving it there is still valid, but we
      don't have to bother anymore.
      Signed-off-by: NAl Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      233e70f4
  2. 16 10月, 2008 1 次提交
  3. 25 9月, 2008 1 次提交
  4. 04 9月, 2008 1 次提交
  5. 13 8月, 2008 1 次提交
  6. 07 8月, 2008 2 次提交
    • L
      Revert "pcm_native.c: remove unused label" · 685d87f7
      Linus Torvalds 提交于
      This reverts commit 680db013.  The label
      is actually used, but hidden behind CONFIG_SND_DEBUG and the horrible
      snd_assert() macro.
      
      That macro could probably be improved to be along the lines of
      
      	#define snd_assert(expr, args...) do { if ((void)(expr),0) { args; } } while (0)
      
      or similar to make sure that we always both evaluate 'expr' and parse
      'args', but while gcc should optimize it all away, I'm too lazy to
      really verify that.  So I'll just admit defeat and will continue to live
      with the annoying warning.
      Noted-by: NRobert P. J. Day <rpjday@crashcourse.ca>
      Signed-off-by: Linus "Grr.." Torvalds
      685d87f7
    • L
      pcm_native.c: remove unused label · 680db013
      Linus Torvalds 提交于
      This fixes the warning
      
        sound/core/pcm_native.c: In function 'snd_pcm_fasync':
        sound/core/pcm_native.c:3262: warning: label 'out' defined but not used
      Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>
      680db013
  7. 03 7月, 2008 1 次提交
  8. 06 2月, 2008 1 次提交
  9. 01 2月, 2008 10 次提交
  10. 16 10月, 2007 2 次提交
  11. 20 7月, 2007 1 次提交
  12. 11 5月, 2007 2 次提交
    • F
      [ALSA] pcm_native: lockdep warning when launching jack · 208eee2a
      Frederik Deweerdt 提交于
      When launching 'jackd -d alsa', lockdep issues the following warning:
      [39701.405086] =============================================
      [39701.405093] [ INFO: possible recursive locking detected ]
      [39701.405107] 2.6.21-rc5-mm4 #2
      [39701.405109] ---------------------------------------------
      [39701.405112] jackd/17366 is trying to acquire lock:
      [39701.405114]  (&substream->self_group.lock){....}, at: [<c034d3c0>] snd_pcm_action_group+0x90/0x240
      [39701.405131]
      [39701.405131] but task is already holding lock:
      [39701.405134]  (&substream->self_group.lock){....}, at: [<c034d63f>] snd_pcm_action_lock_irq+0x3f/0xb0
      [39701.405141]
      [39701.405142] other info that might help us debug this:
      [39701.405145] 3 locks held by jackd/17366:
      [39701.405147]  #0:  (snd_pcm_link_rwlock){....}, at: [<c034d627>] snd_pcm_action_lock_irq+0x27/0xb0
      [39701.405155]  #1:  (&substream->group->lock){....}, at: [<c034d638>] snd_pcm_action_lock_irq+0x38/0xb0
      [39701.405163]  #2:  (&substream->self_group.lock){....}, at: [<c034d63f>] snd_pcm_action_lock_irq+0x3f/0xb0
      [39701.405171]
      [39701.405171] stack backtrace:
      [39701.405174]  [<c0103b8a>] show_trace_log_lvl+0x1a/0x30
      [39701.405179]  [<c0104912>] show_trace+0x12/0x20
      [39701.405183]  [<c01049c6>] dump_stack+0x16/0x20
      [39701.405187]  [<c013b980>] __lock_acquire+0xbd0/0x1040
      [39701.405193]  [<c013be60>] lock_acquire+0x70/0x90
      [39701.405197]  [<c0407846>] _spin_lock+0x36/0x50
      [39701.405203]  [<c034d3c0>] snd_pcm_action_group+0x90/0x240
      [39701.405207]  [<c034d653>] snd_pcm_action_lock_irq+0x53/0xb0
      [39701.405211]  [<c035046f>] snd_pcm_common_ioctl1+0x35f/0xfb0
      [39701.405215]  [<c0351544>] snd_pcm_playback_ioctl1+0x34/0x420
      [39701.405219]  [<c03519f3>] snd_pcm_playback_ioctl+0x43/0x50
      [39701.405223]  [<c017ecc8>] do_ioctl+0x28/0x80
      [39701.405229]  [<c017ed77>] vfs_ioctl+0x57/0x290
      [39701.405233]  [<c017efe9>] sys_ioctl+0x39/0x60
      [39701.405237]  [<c0102bf4>] sysenter_past_esp+0x5d/0x99
      [39701.405240]  =======================
      The attached lockdep annotation silences the warning.
      Signed-off-by: NFrederik Deweerdt <frederik.deweerdt@gmail.com>
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      Signed-off-by: NJaroslav Kysela <perex@suse.cz>
      208eee2a
    • T
      [ALSA] Add snd_pcm_group_for_each_entry() for code cleanup · ef991b95
      Takashi Iwai 提交于
      Added a new macro snd_pcm_group_for_each_entry() just for code cleanup.
      Old macros, snd_pcm_group_for_each() and snd_pcm_group_substream_entry(),
      are removed.
      Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      Signed-off-by: NJaroslav Kysela <perex@suse.cz>
      ef991b95
  13. 09 5月, 2007 1 次提交
  14. 13 2月, 2007 1 次提交
  15. 09 12月, 2006 1 次提交
  16. 08 12月, 2006 1 次提交
  17. 28 11月, 2006 1 次提交
  18. 01 10月, 2006 2 次提交
  19. 23 9月, 2006 1 次提交
  20. 23 6月, 2006 5 次提交
  21. 12 4月, 2006 1 次提交
  22. 31 3月, 2006 2 次提交