1. 01 4月, 2009 21 次提交
  2. 31 3月, 2009 2 次提交
    • A
      proc 2/2: remove struct proc_dir_entry::owner · 99b76233
      Alexey Dobriyan 提交于
      Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy
      as correctly noted at bug #12454. Someone can lookup entry with NULL
      ->owner, thus not pinning enything, and release it later resulting
      in module refcount underflow.
      
      We can keep ->owner and supply it at registration time like ->proc_fops
      and ->data.
      
      But this leaves ->owner as easy-manipulative field (just one C assignment)
      and somebody will forget to unpin previous/pin current module when
      switching ->owner. ->proc_fops is declared as "const" which should give
      some thoughts.
      
      ->read_proc/->write_proc were just fixed to not require ->owner for
      protection.
      
      rmmod'ed directories will be empty and return "." and ".." -- no harm.
      And directories with tricky enough readdir and lookup shouldn't be modular.
      We definitely don't want such modular code.
      
      Removing ->owner will also make PDE smaller.
      
      So, let's nuke it.
      
      Kudos to Jeff Layton for reminding about this, let's say, oversight.
      
      http://bugzilla.kernel.org/show_bug.cgi?id=12454Signed-off-by: NAlexey Dobriyan <adobriyan@gmail.com>
      99b76233
    • R
      radeonfb: Use __pci_complete_power_transition() · b8e676d2
      Rafael J. Wysocki 提交于
      Use __pci_complete_power_transition() to finalize the transition into
      D2 after programming the PMCSR of the device directly.
      Signed-off-by: NRafael J. Wysocki <rjw@sisk.pl>
      Acked-by: NJesse Barnes <jbarnes@virtuousgeek.org>
      b8e676d2
  3. 27 3月, 2009 2 次提交
  4. 25 3月, 2009 3 次提交
  5. 23 3月, 2009 1 次提交
  6. 19 3月, 2009 1 次提交
  7. 17 3月, 2009 1 次提交
    • P
      sh: dma: Make PVR2 DMA configurable. · da62e71d
      Paul Mundt 提交于
      With arch/sh/drivers/dma/ always being built, the Dreamcast DMA engines
      are being unconditionally built in, regardless of whether the DMA API is
      enabled or not. This is a regression from previous behaviour, but there
      is not much advantage in building them all in unconditionally regardless.
      Add a new config option to make it optional, and update the only user of
      it to reflect that.
      Signed-off-by: NPaul Mundt <lethal@linux-sh.org>
      da62e71d
  8. 16 3月, 2009 2 次提交
  9. 13 3月, 2009 6 次提交
  10. 11 3月, 2009 1 次提交
    • B
      radeonfb/aty128fb: Disable broken early resume hook for PowerBooks · d801cec7
      Benjamin Herrenschmidt 提交于
      radeonfb and aty128fb have a special hook called by the PowerMac platform
      code very very early on resume from sleep to bring the screen back. This
      is useful for debugging wakup problems, but unfortunately, this also became
      a source of problems of its own.
      
      The hook is called extremely early, with interrupts still off, and the code
      path involved with that code nowadays rely on things like taking mutexes,
      GFP_KERNEL allocations, etc...
      
      In addition, the driver now relies on the PCI core to restore the standard
      config space before calling resume which doesn't happen with this early
      code path.
      
      I'm keeping the code in but commented out along with a fixup call to
      pci_restore_state(). The reason is that I still want to make it easy to
      re-enable temporarily to track wake up problems, and it's possible that
      I can revive it at some stage if we make sleeping things save to call
      in early resume using a system state.
      
      In the meantime, this should fix several reported regressions.
      Signed-off-by: NBenjamin Herrenschmidt <benh@kernel.crashing.org>
      d801cec7