Skip to content

cloud-kernel
cloud-kernel

openanolis / cloud-kernel
接近 2 年 前同步成功

通知 170
Star 36
Fork 7
cloud-kernel
cloud-kernel
切换分支/标签
  1. 25 10月, 2011 1 次提交
  3. 13 10月, 2011 3 次提交
  5. 10 10月, 2011 1 次提交
  7. 09 10月, 2011 1 次提交
  9. 04 10月, 2011 2 次提交
    • D
      ALSA: oss-mixer - use strlcpy() instead strcpy() · f92766bc
      由 Dan Carpenter 提交于 
      This is mostly a static checker fix more than anything else.  We're
copying from a 64 char buffer into a 44 char buffer.

The 64 character buffer is str[] in snd_mixer_oss_build_test_all().
The call tree is:
	snd_mixer_oss_build_test_all()
	-> snd_mixer_oss_build_test()
	   -> snd_mixer_oss_build_test().

We never actually do fill str[] buffer all the way to 64 characters.
The longest string is:
	sprintf(str, "%s Playback Switch", ptr->name);
ptr->name is a 32 character buffer so 32 plus 16 characters for
" Playback Switch" still puts us over the 44 limit from "id.name".

Most likely ptr->name never gets filled to the limit, but we can't
really change the size of that buffer so lets just use strlcpy() here
and be safe.
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      f92766bc
    • S
      ALSA: firewire-speakers: fix locking · a0978e80
      由 Stefan Richter 提交于 
      There is a lock inversion between fwspk->mutex and pcm->open_mutex
reported by lockdep when fwspk_hw_free is called.

Fixed by copying the fix from the same former issue in the isight
sound driver (commit f3f7c183
"ALSA: isight: fix locking").
Signed-off-by: NStefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: NClemens Ladisch <clemens@ladisch.de>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      a0978e80
  11. 29 9月, 2011 1 次提交
  13. 27 9月, 2011 1 次提交
  15. 24 9月, 2011 1 次提交
  17. 23 9月, 2011 4 次提交
  19. 22 9月, 2011 3 次提交
  21. 20 9月, 2011 6 次提交
  23. 19 9月, 2011 1 次提交
  25. 16 9月, 2011 2 次提交
  27. 15 9月, 2011 2 次提交
    • A
      ALSA: pcm - fix race condition in wait_for_avail() · 763437a9
      由 Arjan van de Ven 提交于 
      wait_for_avail() in pcm_lib.c has a race in it (observed in practice by an
Intel validation group).

The function is supposed to return once space in the buffer has become
available, or if some timeout happens.  The entity that creates space (irq
handler of sound driver and some such) will do a wake up on a waitqueue
that this function registers for.

However there are two races in the existing code

1) If space became available between the caller noticing there was no
   space and this function actually sleeping, the wakeup is missed and the
   timeout condition will happen instead

2) If a wakeup happened but not sufficient space became available, the
   code will loop again and wait for more space.  However, if the second
   wake comes in prior to hitting the schedule_timeout_interruptible(), it
   will be missed, and potentially you'll wait out until the timeout
   happens.

The fix consists of using more careful setting of the current state (so
that if a wakeup happens in the main loop window, the schedule_timeout()
falls through) and by checking for available space prior to going into the
schedule_timeout() loop, but after being on the waitqueue and having the
state set to interruptible.

[tiwai: the following changes have been added to Arjan's original patch:
 - merged akpm's fix for waitqueue adding order into a single patch
 - reduction of duplicated code of avail check
]
Signed-off-by: NArjan van de Ven <arjan@linux.intel.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Cc: <stable@kernel.org>
Signed-off-by: NTakashi Iwai <tiwai@suse.de>
      763437a9
    • T
      Merge branch 'fix/asoc' into for-linus · 4038a12e
      由 Takashi Iwai 提交于
      4038a12e
  29. 14 9月, 2011 6 次提交
  31. 13 9月, 2011 1 次提交
  33. 12 9月, 2011 4 次提交