1. 22 11月, 2012 5 次提交
  2. 21 11月, 2012 2 次提交
  3. 20 11月, 2012 13 次提交
  4. 18 11月, 2012 4 次提交
    • S
      qlcnic: fix sparse warnings · 6d973cb1
      Sony Chacko 提交于
      qlcnic_hw.c:1337:17: warning: cast removes address space of expression
      qlcnic_hw.c:1337:17: warning: incorrect type in argument 2 (different address spaces)
      qlcnic_hw.c:1337:17:    expected void volatile [noderef] <asn:2>*addr
      qlcnic_hw.c:1337:17:    got void *<noident>
      qlcnic_hw.c:1337:17: warning: cast removes address space of expression
      qlcnic_hw.c:1337:17: warning: incorrect type in argument 1 (different address spaces)
      qlcnic_hw.c:1337:17:    expected void const volatile [noderef] <asn:2>*addr
      qlcnic_hw.c:1337:17:    got void *<noident>
      
      The above warnings are originating from the macros QLCNIC_RD_DUMP_REG and
      QLCNIC_WR_DUMP_REG.
      The warnings are fixed and macros are replaced with equivalent functions
      in the only file from where it is called.
      
      The following warnings are fixed by making the functions static.
      
      qlcnic_hw.c:543:5: warning: symbol 'qlcnic_set_fw_loopback' was not declared. Should it be static?
      qlcnic_init.c:1853:6: warning: symbol 'qlcnic_process_rcv_diag' was not declared. Should it be static?
      Signed-off-by: NSony Chacko <sony.chacko@qlogic.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      6d973cb1
    • S
      qlcnic: fix compiler warnings · 5ad6ff9d
      Sony Chacko 提交于
      Fix the following warnings:
      
      qlcnic_main.c: In function 'qlcnic_update_cmd_producer':
      qlcnic_main.c:119:51: warning: unused parameter 'adapter' [-Wunused-parameter]
      qlcnic_main.c:119: warning: unused parameter adapter
      qlcnic_init.c: In function qlcnic_process_lro
      qlcnic_init.c:1586: warning: unused parameter sds_ring
      qlcnic_init.c: In function qlcnic_process_rcv_diag
      qlcnic_init.c:1854: warning: unused parameter sds_ring
      qlcnic_init.c: In function qlcnic_fetch_mac
      qlcnic_init.c:1938: warning: unused parameter adapter
      
      warning: 'pci_using_dac' may be used uninitialized in this function [-Wmaybe-uninitialized]
      qlcnic_main.c:1569:10: note: 'pci_using_dac' was declared here
      Signed-off-by: NSony Chacko <sony.chacko@qlogic.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      5ad6ff9d
    • B
      pch_gbe, ptp_pch: Fix the dependency direction between these drivers · 18d359ce
      Ben Hutchings 提交于
      In commit a24006ed ('ptp: Enable clock
      drivers along with associated net/PHY drivers') I wrongly made
      PTP_1588_CLOCK_PCH depend on PCH_GBE.  The dependency is really the
      other way around.  Therefore make PCH_GBE select PTP_1588_CLOCK_PCH
      and remove the 'default y' from the latter.
      Reported-by: NRandy Dunlap <rdunlap@xenotime.net>
      Signed-off-by: NBen Hutchings <bhutchings@solarflare.com>
      Acked-by: NRandy Dunlap <rdunlap@xenotime.net>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      18d359ce
    • R
      vxlan: remove unused variable. · e8e55d95
      Rami Rosen 提交于
      This patch removes addrexceeded member from vxlan_dev struct as it is unused.
      Signed-off-by: NRami Rosen <ramirose@gmail.com>
      Acked-by: NStephen Hemminger <shemminger@vyatta.com>
      Signed-off-by: NDavid S. Miller <davem@davemloft.net>
      e8e55d95
  5. 17 11月, 2012 1 次提交
  6. 16 11月, 2012 10 次提交
  7. 15 11月, 2012 5 次提交
    • H
      s390/3215: fix tty close handling · ae289dc1
      Heiko Carstens 提交于
      The 3215 console always has the RAW3215_FIXED flag set, which causes
      raw3215_shutdown() not to wait for outstanding I/O requests if an attached
      tty gets closed.
      The flag however can be simply removed, so we can guarantee that all requests
      belonging to the tty have been processed when the tty is closed.
      
      However the tasklet that belongs to the 3215 device may be scheduled even if
      there is no tty attached anymore, since we have a race between console and tty
      processing.
      Thefore unconditional tty_wakekup() in raw3215_wakeup() can cause the following
      NULL pointer dereference:
      
      3.465368 Unable to handle kernel pointer dereference at virtual kernel address (null)
      3.465448 Oops: 0004 #1 SMP
      3.465454 Modules linked in:
      3.465459 CPU: 1 Not tainted 3.6.0 #1
      3.465462 Process swapper/1 (pid: 0, task: 000000003ffa4428, ksp: 000000003ffb7ce0)
      3.465466 Krnl PSW : 0404100180000000 0000000000162f86 (__wake_up+0x46/0xb8)
      3.465480            R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:0 CC:1 PM:0 EA:3
               Krnl GPRS: fffffffffffffffe 0000000000000000 0000000000000160 0000000000000001
      3.465492            0000000000000001 0000000000000004 0000000000000004 000000000096b490
      3.465499            0000000000000001 0000000000000100 0000000000000001 0000000000000001
      3.465506            070000003fc87d60 0000000000000160 000000003fc87d68 000000003fc87d00
      3.465526 Krnl Code: 0000000000162f76: e3c0f0a80004      lg      %r12,168(%r15)
                          0000000000162f7c: 58000370          l       %r0,880
                         #0000000000162f80: c007ffffffff00    xilf    %r0,4294967295
                         >0000000000162f86: ba102000          cs      %r1,%r0,0(%r2)
                          0000000000162f8a: 1211              ltr     %r1,%r1
                          0000000000162f8c: a774002f          brc     7,162fea
                          0000000000162f90: b904002d          lgr     %r2,%r13
                          0000000000162f94: b904003a          lgr     %r3,%r10
      3.465597 Call Trace:
      3.465599 (<0400000000000000> 0x400000000000000)
      3.465602  <000000000048c77e> raw3215_wakeup+0x2e/0x40
      3.465607  <0000000000134d66> tasklet_action+0x96/0x168
      3.465612  <000000000013423c> __do_softirq+0xd8/0x21c
      3.465615  <0000000000134678> irq_exit+0xa8/0xac
      3.465617  <000000000046c232> do_IRQ+0x182/0x248
      3.465621  <00000000005c8296> io_return+0x0/0x8
      3.465625  <00000000005c7cac> vtime_stop_cpu+0x4c/0xb8
      3.465629 (<0000000000194e06> tick_nohz_idle_enter+0x4e/0x74)
      3.465633  <0000000000104760> cpu_idle+0x170/0x184
      3.465636  <00000000005b5182> smp_start_secondary+0xd6/0xe0
      3.465641  <00000000005c86be> restart_int_handler+0x56/0x6c
      3.465643  <0000000000000000> 0x0
      3.465645 Last Breaking-Event-Address:
      3.465647  <0000000000403136> tty_wakeup+0x46/0x98
      3.465652
      3.465654 Kernel panic - not syncing: Fatal exception in interrupt
      01: HCPGIR450W CP entered; disabled wait PSW 00020001 80000000 00000000 0010F63C
      
      The easiest solution is simply to check if tty is NULL in the tasklet.
      If it is NULL nothing is to do (no tty attached), otherwise tty_wakeup()
      can be called, since we hold a reference to the tty.
      This is not nice... but it is a small patch and it works.
      Signed-off-by: NHeiko Carstens <heiko.carstens@de.ibm.com>
      Signed-off-by: NMartin Schwidefsky <schwidefsky@de.ibm.com>
      ae289dc1
    • G
      ixgbevf: Add checksum statistics counters to rings · 55fb277c
      Greg Rose 提交于
      Add hardware checksum statistic counters to the ring structures and
      then during packet processing update those counters instead of the
      global counters in the adapter structure.  Only update the adapter
      structure counters when all other statistics are gathered in the
      ixgbevf_update_stats() function.
      Signed-off-by: NGreg Rose <gregory.v.rose@intel.com>
      Tested-by: NSibai Li <sibai.li@intel.com>
      Signed-off-by: NJeff Kirsher <jeffrey.t.kirsher@intel.com>
      55fb277c
    • G
      3938d3c8
    • A
    • G
      dee847f5