This patch indends to make some cleanup and send printf
error messages to stderr. The changes were performed with coccinelle
for failure messages and manual for other cases, such as wrong usage
messages.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Reviewed-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Calculation of the length of an array can be done with the ARRAY_SIZE
macro to make code more abstract and remove the associated
checkpatch.pl warning.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Single statement blocks don’t need braces.
Found with checkpatch.pl.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Acked-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove explicit NULL comparison and write it in its simpler form as
recommended by checkpatch.pl.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Reviewed-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Add support for TXC PA12203001 als and proximity sensor.
Support for raw illuminance and proximity readings.
Signed-off-by: NAdriana Reus <adriana.reus@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

TI's opt3001 light sensor is a simple and yet powerful
little device. The device provides 99% IR rejection,
automatic full-scale, very low power consumption and
measurements from 0.01 to 83k lux.

This patch adds support for that device using the IIO
framework.

See http://www.ti.com/product/opt3001 for more information.
Signed-off-by: NFelipe Balbi <balbi@ti.com>
Signed-off-by: NAndreas Dannenberg <dannenberg@ti.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This cleans up the most ugly workaround in this driver. There are no
functional changes yet in the decoding algorithm, but we improve the
following things:
 * Get rid of spurious warning messages on systems with fast HRTIMER.
 * If the clock is not fast enough for decoding to work, we give
   up immediately.
 * In that case we return EAGAIN instead of EIO, so it's easier to
   discriminate causes of failure.

Returning EAGAIN is somewhat controversial: It's technically correct
as a faster clock might become available. OTOH once all clocks are
enabled this is a permanent error. There is no ECLOCKTOOSLOW error
code.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

We just do the assignments in two steps.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Explain why the driver needs a mutex.
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

* add spaces around binary operators in cases where it reduces readability
* align multiline statements around opening parenthesis
Reported-by: NHartmut Knaack <knaack.h@gmx.de>
	in Message-ID: <55919E72.3010807@gmx.de>
Signed-off-by: NHarald Geyer <harald@ccbib.org>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

The driver currently does not take into account the minimum sample time
as per the Figure 6-8 Chapter 9.1.1 12-bit ADC electrical characteristics.
We set a static amount of cycles instead of considering the sample time
as a given value, which depends on hardware characteristics.

Determine sampling frequencies by first reading the device tree property
node and then calculating the required Long Sample Time Adder (LSTAdder)
value, based on the ADC clock frequency and sample time value obtained
from the device tree. This LSTAdder value is then used for calculating
the sampling frequencies possible.

In case the sample time property is not specified through the device
tree, a safe default value of 1000ns is assumed.
Signed-off-by: NSanchayan Maity <maitysanchayan@gmail.com>
Acked-by: NStefan Agner <stefan@agner.ch>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This adds support for Microchip's 13 bit 1 channel AD converter MCP3301
Signed-off-by: NAndrea Galbusera <gizero@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Construct the scanmask using its descriptive axis names (as used in
iio_chan_spec) instead of a 'magic' value.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJandy Gou <qingsong.gou@ck-telecom.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Signed-off-by: NJandy Gou <qingsong.gou@ck-telecom.com>
Acked-by: NDaniel Baluta <daniel.baluta@intel.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Some macros and a function were missing the acpi_als_ prefix, so add it.
Signed-off-by: NHartmut Knaack <knaack.h@gmx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

In order to provide a channel name to in kernel consumers add the
datasheet names for every usable AD channel. Since the channel names
differ between i.MX23 and i.MX28, we need to separate the channel
specs.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch reorder the header includes alphabetically.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch removes the unnecessary header includes.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch adds the missing include for mutex handling.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

This patch fix some spelling errors in the comments.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

At the beginning the driver supported only i.MX28 SoC, but now the
whole MXS platform. So remove any confusing comments which apply
only to i.MX28.
Signed-off-by: NStefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: NMarek Vasut <marex@denx.de>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove sysfs bytes_per_datum device attribute ABI documentation
since the attribute is not present anymore.
Signed-off-by: NCristina Opriceana <cristina.opriceana@gmail.com>
Signed-off-by: NJonathan Cameron <jic23@kernel.org>

Remove the duplicate code of dgap_remove_one() and dgap_stop().
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

In a later patch we will remove the duplicate codes. But the code also
needs to execute dgap_remove_driver_sysfiles() if it is being called
from dgap_remove_one() but if being called fron the error path of the
dgap_init_module() then the sysfiles should not be removed.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Relocate the function dgap_stop() so that in a later patch we can remove
the duplicate codes between dgap_stop() and dgap_remove_one().
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The code in dgap_stop() is almost a duplicate of the code that will be
executed on pci_unregister_driver(). So the error code was stopping and
unregistering everything twice.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The variable ret was always 0. So remove the variable and always
return 0 from the function.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Stop using DBG_88E which is a custom macro for printing debugging
messages. Instead start using pr_debug and in the process define
pr_fmt.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The default value of status was _FAIL, it was only changed if kzalloc
succeeds and the check for status is immediately following kzalloc. We
can have the failure code in the else part as the failure code will be
executed only if kzalloc fails.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

By checking for the success of kzalloc we were able to remove the goto
label thus making the code more readable.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The check for pstat and pdvobjpriv is not required here as we have
already checked for them before.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

The inline function rtw_set_ips_deny() was only defined but was never
used.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Now since the Big-Endian and Little-Endian based calculations are moved
into a macro we can make fb_read() and fb_write() common for both
Little-Endian and Big-Endian.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Define and use some new macros to work with different situations
based on little-endian and big-endian.
Signed-off-by: NSudip Mukherjee <sudip@vectorindia.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rtw_hal_write_rfreg() is never referenced, so remove it.

It used to be the only place where the write_rfreg callback was
called, so get rid of the function pointer as well.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rtw_hal_set_def_var() is never referenced, so remove it.

It used to be the only place where the SetHalDefVarHandler callback was
called, so get rid of the function pointer as well.

Also remove the callback itself, SetHalDefVar8188EUsb(), which was not
called anywhere else.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

rtw_hal_enable_interrupt() and rtw_hal_disable_interrupt() are never
referenced, so remove them.

They used to be the only place where the enable_interrupt() and
disable_interrupt() callbacks were called, and the function pointer
is never set, so get rid of the function pointer as well.
Signed-off-by: NLuca Ceresoli <luca@lucaceresoli.net>
Cc: Greg Kroah-Hartman <gregkh@linux.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

fixes "Possible unnecessary 'out of memory' message"
Signed-off-by: NCHANG FU CHIAO <zector1030@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>

Variable obd_device_cachep is only used inside the file it is declared,
so it is better set as static
Signed-off-by: NPedro Marzo Perez <marzo.pedro@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@linuxfoundation.org>