The code to clear fifo errors was incorrect and sending garbage
to the external phy. Removed the no longer used inline's funcs.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>
Signed-off-by: NJeff Garzik <jgarzik@pobox.com>

Minor whitespace cleanups.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>
Signed-off-by: NJeff Garzik <jgarzik@pobox.com>

Missing PCI_REV_DESC define.
Signed-off-by: NDavid S. Miller <davem@davemloft.net>

Optimize the receive buffer management code to replenish the
buffers immediately (like tg3).
Signed-off-by: NStephen Hemmminger <shemminger@osdl.org>

Need to handle receive and transmit packet arbiter timeouts.
Transmit arbiter timeouts happens when Gigabit sends to 100Mbit port
on same switch and pause occurs.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

Cleanup messages (for debug) about PHY interrrupts, because when
user can't get driver working that is often the problem.
Use a consistent way of enabling interrupts by port.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

Rewrite the code for handling the Broadcom PHY to something that
works. Remove link polling because Broadcom and Yukon don't need it.
When I wrote initial code, didn't have a genesis chipset based
board to test, so it was a non-working guess.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

Get rid of definitions for chip versions and PHY chips that
this driver does not support.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

Replace inline accessor functions for chip revision and number of ports
with simple structure members.
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

The inlines and macro's needed some cleanup's and fixes:
 * change name of macro SKGEMAC_REG to SK_REG to better reflect usage
   and fix comments
 * ditto for SK_GEXM_REG -> SK_XMAC_REG and SKGEGMA_REG -> SK_GMA_REG

 * change skge_gm_ to just gm_ since it is just a local function and long
   names look ugly.
 * change skge_xm_ to just xm_
 * fix xm_write32 to write as two u16's with correct byte order
 * fix xm_outaddr to correctly use offset
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>

Cleanup whitespace around if() and switch() and end of lines
Signed-off-by: NStephen Hemminger <shemminger@osdl.org>