This patch fixes a misspelling in a comment section.
Signed-off-by: NTobias Klauser <tklauser@nuerscht.ch>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes a misspelling in a comment section.
Signed-off-by: NTobias Klauser <tklauser@nuerscht.ch>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes a double "the" in a comment section.
Signed-off-by: NTobias Klauser <tklauser@nuerscht.ch>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch fixes the some misspellings and a trailing whitespace in
the comments.
Signed-off-by: NTobias Klauser <tklauser@nuerscht.ch>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch kills another macro abuse in the via686a hardware monitoring
driver. Using a macro just to alias an array is quite useless, isn't it?
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Here are some corrections for drivers/i2c/chips/Kconfig.
Signed-off-by: NAlexey Fisher <fishor@gmx.net>
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch removes die_code from adm1021 as nothing within the
driver uses it.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

The via686a hardware monitoring driver has infamous coding style at the
moment. I'd like to clean up the mess before I start working on other
changes to this driver. Is the following patch acceptable? No code
change, only coding style (indentation, alignments, trailing white
space, a few parentheses and a typo).
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch kills a common macro abuse in i2c chip drivers: defining
ALARMS_FROM_REG returning its argument unchanged. Dropping the macro
makes the code somewhat more readable IMHO.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch includes jiffies.h in two i2c drivers.
(jiffies.h is needed for the time_after function.)
Signed-off-by: NDominik Hackl <dominik@hackl.dhs.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This patch adds an info print of detected VRM stolen from Sebastian
Witt's atxp1 sriver.  ADM9240 already has vrm accessor removed.

Write no-op and whitespace fixes removed :)

Couple of comments changed, tested on 2.6.11.9.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This small patch changes two drivers, adm1025 and adm1026, to
report vid as cpu0_vid sysfs name as used by the other drivers.

Added duplicated names and six month warning for old names to
be removed as requested.  Compile tested.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Jarkko Lavinen provided patch to fix: "couldn't set the divisor 128
through fan1_div sysfs entry even though the chip supports it and
setting divisors 1..64 worked. This was due to POWER_TO_REG() only
checking 2's powers 0 till 5 but not 6."

This patch applies that fix to w83627hf and w83781d drivers.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

In my cross-reference checking of sysfs names, the via686a needs
special case treatment as it the only driver expands S_IWUSR to
00200 with gcc -E.  (00200 is the correct value for S_IWUSR).

This is caused by the driver including <linux/delay.h>, it compiles
fine without that header but I am unable to test drive the change.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Call i2c_transfer() from i2c_master_send() and i2c_master_recv() to
avoid the redundant code that was in all three functions.  It also
removes unnecessary debug statements as suggested by Jean Delvare.

This is important for the non-blocking interfaces because they will
have to handle a non-blocking interface in this area.  Having it in
one place greatly simplifies the changes.
Signed-off-by: NCorey Minyard <minyard@acm.org>
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

I2C-MPC: Allow for sharing of the interrupt line

On the MPC8548 devices we have multiple I2C-MPC buses however they are on the
same interrupt line.  Made request_irq pass SA_SHIRQ now so the second bus can
register for the same IRQ.
Signed-off-by: NKumar Gala <kumar.gala@freescale.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

 Here are some spelling corrections for drivers/i2c.

 occured -> occurred
 intialization -> initialization
 Everytime -> Every time
 transfering -> transferring
 relevent -> relevant
 continous -> continuous
 neccessary -> necessary
 explicitely -> explicitly
 Celcius -> Celsius
 differenciate -> differentiate
Signed-off-by: NSteven Cole <elenstev@mesatop.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This simple patch adds support for the SMSC LPC47M15x and LPC47M192
chips to the smsc47m1 hardware monitoring driver. These chips are
compatible with the other ones already supported by the driver, so I see
no reason not to support them, especially when the Linux 2.4 version of
the driver does already.

I also modified the info printks to name the chips by their real name.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

These are the fixes for the bug you spotted in my new w83627ehf driver:
	- Explicit division by 0.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

This is a new hardware monitoring driver, w83627ehf, which supports the
Winbond W83627EHF Super-I/O chip. The driver is not complete, but
already usable. It only implements fan speed and temperature monitoring,
while the chip also supports voltage inputs with VID, PWM output and
temperature sensor selection. I have no more time to work on this, but
anyone with supported hardware could add the missing functionalities
later.

This driver is largely derived from the w83627hf driver.

Thanks to Leon Moonen and Steve Cliffe for tesing the preliminary
versions of my driver and reporting the problems they encountered.

Thanks to Grant Coady for noticing and fixing various corner cases in
the fan management. This third version of the driver hopefully addresses
all the issues the original version had.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Completion of Michiel Rook's port of adm9240 to 2.6 with addition
of auto fan clock divider based on Jean Delvare's algorithm, and
replaces scaling macros with static inlines.
Signed-off-by: NGrant Coady <gcoady@gmail.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Hi Alexey,

> Files that don't use CONFIG_* stuff shouldn't include config.h
> Files that use CONFIG_* stuff should include config.h
>
> It's that simple. ;-)

I agree. This won't change anything though, as all drivers include
either device.h or module.h, which in turn include config.h. But you are
still correct, so I approve your patch.

For completeness, I would propose the following on top of your own
patch:

i2c bus drivers do not need to define DEBUG themselves, as the Kconfig
system takes care of it.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Files that don't use CONFIG_* stuff shouldn't include config.h
Files that use CONFIG_* stuff should include config.h

It's that simple. ;-)
Signed-off-by: NAlexey Dobriyan <adobriyan@mail.ru>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

On Wed, May 04, 2005 at 12:07:11PM +0200, Jean Delvare wrote:
> Additionally, I would welcome an additional patch documenting the fact
> that the ds1337 driver will work fine with the Dallas DS1339 real-time
> clock chip.

Document the fact that ds1337 driver works also with DS1339 real-time
clock chip.
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Chip is searched by bus number rather than its own proprietary id.
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NJames Chapman <jchapman@katalix.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

i2c_transfer returns number of sucessfully transfered messages. Change
error checking to accordingly. (ds1337_set_datetime never returned
sucess)
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NJames Chapman <jchapman@katalix.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Make time format consistent with other RTC drivers.
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NJames Chapman <jchapman@katalix.com>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

dev_{dbg,err} functions should print client's device name. data->id can
be dropped from message, because device is determined by bus it hangs on
(it has fixed address).
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use correct macros to convert between bdc and bin. See linux/bcd.h
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Use i2c_transfer to send message, so we get proper bus locking.
Signed-off-by: NLadislav Michl <ladis@linux-mips.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Adds support for the Attansic ATXP1 I2C device, found on some x86
plattforms to change CPU and other voltages.  Depends on the previous
i2c-vid.h patch.
Signed-off-by: NSebastian Witt <se.witt@gmx.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Adds conversion from VID (mV) to register value. Used by the atxp1 I2C module.
Removed uneeded switch case.
Signed-off-by: NSebastian Witt <se.witt@gmx.net>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

[PATCH] I2C rtc8564.c remove duplicate include

Trivial fix: removes duplicate include line.
Signed-off-by: NClemens Koller <clemens.koller@anagramm.de>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

On top of my previous patch which removes the use of address ranges in
video i2c drivers, this one can save an additional few bytes of memory.
Most of these drivers which do not use I2C_CLIENT_INSMOD initialize the
unused address lists in a less than optimal way. This patch simply
optimizes this, by using a single one-element list instead of 3
different lists with two elements each.

This saves an average 63 bytes on these drivers.
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

diff -ruN linux-2.6.12-rc1-bk5.orig/drivers/media/video/adv7170.c linux-2.6.12-rc1-bk5/drivers/media/video/adv7170.c

Some months ago, you killed the address ranges mechanism from all
sensors i2c chip drivers (both the module parameters and the in-code
address lists). I think it was a very good move, as the ranges can
easily be replaced by individual addresses, and this allowed for
significant cleanups in the i2c core (let alone the impressive size
shrink for all these drivers).

Unfortunately you did not do the same for non-sensors i2c chip drivers.
These need the address ranges even less, so we could get rid of the
ranges here as well for another significant i2c core cleanup. Here comes
a patch which does just that. Since the process is exactly the same as
what you did for the other drivers set already, I did not split this one
in parts.

A documentation update is included.

The change saves 308 bytes in the i2c core, and an average 1382 bytes
for chip drivers which use I2C_CLIENT_INSMOD, 126 bytes for those which
do not.

This change is required if we want to merge the sensors and non-sensors
i2c code (and we want to do this).
Signed-off-by: NJean Delvare <khali@linux-fr.org>
Signed-off-by: NGreg Kroah-Hartman <gregkh@suse.de>

Index: gregkh-2.6/Documentation/i2c/writing-clients
===================================================================

This patch removes some unneeded checks of pointers being NULL before
calling kfree() on them.  kfree() handles NULL pointers just fine, checking
first is pointless.
Signed-off-by: NJesper Juhl <juhl-lkml@dif.dk>
Signed-off-by: NAndrew Morton <akpm@osdl.org>
Signed-off-by: NLinus Torvalds <torvalds@osdl.org>