1. 28 5月, 2018 1 次提交
  2. 03 5月, 2018 4 次提交
  3. 26 4月, 2018 1 次提交
    • F
      ASoC: fsl_ssi: Use u32 variable type when using regmap_read() · 671f8204
      Fabio Estevam 提交于
      Convert the sisr and sisr2 variable types to u32 to avoid the following
      sparse warnings:
      
      sound/soc/fsl/fsl_ssi.c:391:42: warning: incorrect type in argument 3 (different base types)
      sound/soc/fsl/fsl_ssi.c:391:42:    expected unsigned int *val
      sound/soc/fsl/fsl_ssi.c:391:42:    got restricted __be32 *<noident>
      sound/soc/fsl/fsl_ssi.c:393:17: warning: restricted __be32 degrades to integer
      sound/soc/fsl/fsl_ssi.c:393:15: warning: incorrect type in assignment (different base types)
      sound/soc/fsl/fsl_ssi.c:393:15:    expected restricted __be32 [usertype] sisr2
      sound/soc/fsl/fsl_ssi.c:393:15:    got unsigned int
      sound/soc/fsl/fsl_ssi.c:396:50: warning: incorrect type in argument 3 (different base types)
      sound/soc/fsl/fsl_ssi.c:396:50:    expected unsigned int [unsigned] val
      sound/soc/fsl/fsl_ssi.c:396:50:    got restricted __be32 [usertype] sisr2
      sound/soc/fsl/fsl_ssi.c:398:42: warning: incorrect type in argument 2 (different base types)
      sound/soc/fsl/fsl_ssi.c:398:42:    expected unsigned int [unsigned] [usertype] sisr
      sound/soc/fsl/fsl_ssi.c:398:42:    got restricted __be32 [addressable] [usertype] sisr
      
      In other places where regmap_read() is used a u32 variable is passed
      to store the register read value, so do the same here as well.
      
      regmap API already takes care of endianness, so the usage of u32 is safe.
      Signed-off-by: NFabio Estevam <fabio.estevam@nxp.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      671f8204
  4. 16 4月, 2018 1 次提交
  5. 12 4月, 2018 2 次提交
    • N
      ASoC: fsl_ssi: Fix mode setting when changing channel number · fac8a5a5
      Nicolin Chen 提交于
      This is a partial revert (in a cleaner way) of commit ebf08ae3
      ("ASoC: fsl_ssi: Keep ssi->i2s_net updated") to fix a regression
      at test cases when switching between mono and stereo audio.
      
      The problem is that ssi->i2s_net is initialized in set_dai_fmt()
      only, while this set_dai_fmt() is only called during the dai-link
      probe(). The original patch assumed set_dai_fmt() would be called
      during every playback instance, so it failed at the overriding use
      cases.
      
      This patch adds the local variable i2s_net back to let regular use
      cases still follow the mode settings from the set_dai_fmt().
      
      Meanwhile, the original commit of keeping ssi->i2s_net updated was
      to make set_tdm_slot() clean by checking the ssi->i2s_net directly
      instead of reading SCR register. However, the change itself is not
      necessary (or even harmful) because the set_tdm_slot() might fail
      to check the slot number for Normal-Mode-None-Net settings while
      mono audio cases still need 2 slots. So this patch can also fix it.
      And it adds an extra line of comments to declare ssi->i2s_net does
      not reflect the register value but merely the initial setting from
      the set_dai_fmt().
      Reported-by: NMika Penttilä <mika.penttila@nextfour.com>
      Signed-off-by: NNicolin Chen <nicoleotsuka@gmail.com>
      Tested-by: NMika Penttilä <mika.penttila@nextfour.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      fac8a5a5
    • N
      ASoC: fsl_esai: Fix divisor calculation failure at lower ratio · c656941d
      Nicolin Chen 提交于
      When the desired ratio is less than 256, the savesub (tolerance)
      in the calculation would become 0. This will then fail the loop-
      search immediately without reporting any errors.
      
      But if the ratio is smaller enough, there is no need to calculate
      the tolerance because PM divisor alone is enough to get the ratio.
      
      So a simple fix could be just to set PM directly instead of going
      into the loop-search.
      Reported-by: NMarek Vasut <marex@denx.de>
      Signed-off-by: NNicolin Chen <nicoleotsuka@gmail.com>
      Tested-by: NMarek Vasut <marex@denx.de>
      Reviewed-by: NFabio Estevam <fabio.estevam@nxp.com>
      Signed-off-by: NMark Brown <broonie@kernel.org>
      Cc: stable@vger.kernel.org
      c656941d
  6. 26 3月, 2018 1 次提交
  7. 27 2月, 2018 1 次提交
  8. 21 2月, 2018 17 次提交
  9. 12 2月, 2018 9 次提交
  10. 08 1月, 2018 1 次提交
  11. 19 12月, 2017 2 次提交