- separate the namespace

 - remove macros
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- separate the namespace

 - remove macros
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- separate the namespace

 - remove macros

 - move the default vector-allocation-domain to mach-generic

 - fix whitespace damage
Signed-off-by: NIngo Molnar <mingo@elte.hu>

These flags are completely unused. (the in-kernel IRQ balancer has
been removed from the upstream kernel.)
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up these methods - to make it clearer which function is
used in which case.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

This field name was unreasonably long - shorten it.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

The bigsmp and es7000 subarchitectures un-defined APIC_DEST_LOGICAL in
a rather nasty way by re-defining it to zero. That is infinitely
fragile and makes it very hard to see what to code really does in
a given context. The very same constant has different meanings and
values - depending on which subarch is enabled.

Untangle this mess by never undefining the constant, but instead
propagating the right values into the genapic driver templates.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

the ->ESR_DISABLE shouting variant was used to enable the esr_disable
macro wrappers. Those ugly macros are removed now so we can rename
->ESR_DISABLE to ->disable_esr
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

Most subarchitectures want to disable the APIC ESR (Error Status Register),
because they generally have hardware hacks that wrap standard CPUs into
a bigger system and hence the APIC bus is quite non-standard and weirdnesses
(lockups) have been seen with ESR reporting.

Remove the esr_disable macros and put the desired flag into each
subarchitecture's genapic template directly.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

use apic->target_cpus() directly instead of the TARGET_CPUS wrapper.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

Clean up all the target_cpus() namespace overlap that exists
between bigsmp, es7000, mach-default, numaq and summit - by
separating the different functions into different names.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Remove leftover definition.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

They were only used in a single place and obscured the apic_es7000
driver template.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

They were only used in a single place and obscured the apic_bigsmp
driver template.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

They were only used in a single place and obscured the apic_numaq template.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

They were only used in a single place and obscured the apic_summit template.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

They were only used in a single place and obscured the apic_default template.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Remove the wrapper macros IRQ_DEST_MODE and IRQ_DELIVERY_MODE.

The typical 32-bit and the 64-bit build all dereference via the genapic,
so it's pointless to hide that indirection via these ugly macros.

Furthermore, it also obscures subarchitecture details.

So replace it with apic->irq_dest_mode / etc. accesses.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

int_delivery_mode is supposed to mean 'interrupt delivery mode', but
it's quite a misnomer as 'int' we usually think of as an integer type ...

The standard naming for such attributes is 'irq' - so rename the following
fields and macros:

 int_delivery_mode => irq_delivery_mode
 INT_DELIVERY_MODE => IRQ_DELIVERY_MODE
 int_dest_mode     => irq_dest_mode
 INT_DEST_MODE     => IRQ_DEST_MODE
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: cleanup

x86 subarchitectures each defined a "apic_id_registered()" method,
which could be an inline function depending on which subarch we build
for, and which was also the name of a genapic field.

Untangle this namespace spaghetti by giving each of the instances
a separate name.

Also remove wrapper macro obfuscation.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: refactor code

x86 subarchitectures each defined a "acpi_madt_oem_check()" method,
which could be an inline function, or an extern, or a static function,
and which was also the name of a genapic field.

Untangle this namespace spaghetti by setting ->acpi_madt_oem_check()
to NULL on those subarchitectures that have no detection quirks,
and rename the other ones (summit, es7000) that do.

Also change default_acpi_madt_oem_check() to handle NULL entries,
and clean its control flow up as well.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

The APIC_INIT() / APICFUNC / IPIFUNC macros were ugly and obfuscated
the true identity of various APIC driver methods.

Now that they are not used anymore, remove them.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up the APIC driver template:

 - order fields properly
 - use the macro names explicitly (so that they can be renamed later)
 - fill in NULL entries as well
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up the APIC driver template:

 - order fields properly
 - use the macro names explicitly (so that they can be renamed later)
 - fill in NULL entries as well
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up the APIC driver template:

 - order fields properly
 - use the macro names explicitly (so that they can be renamed later)
 - fill in NULL entries as well
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up the APIC driver template:

 - order fields properly
 - use the macro names explicitly (so that they can be renamed later)
 - fill in NULL entries as well
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Clean up the APIC driver template:

 - order fields properly
 - use the macro names explicitly (so that they can be renamed later)
 - fill in NULL entries as well
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

- reorder fields so that they appear in struct genapic field ordering

- add zero-initialized fields too so that it's apparent which functionality
  is default / missing.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Rename genapic-> to apic-> references because in a future chagne we'll
open-code all the indirect calls (instead of obscuring them via macros),
so we want this reference to be as short as possible.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

64-bit x86 uses the IPI callbacks even on UP - so provide them
generally.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Unify genapic.h some more.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Unify remaining bits of genapic_32/64.h.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Move over the (now identical) struct genapic definitions from
genapic_32/64.h to genapic.h.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: pre unification cleanup

Make genapic_32.h similar to genapic_64.h: reorder fields, unify types
and bring in new entries.

No existing functionality is affected.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: pre unification cleanup

Make genapic_64.h similar to genapic_32.h: reorder fields, unify types
and bring in new entries.

No existing functionality is affected.
Signed-off-by: NIngo Molnar <mingo@elte.hu>

Impact: Cleanup

While I was looking through the new and improved bootstrap code - great
work that, thanks! I found the below a slight improvement.

Remove unnecessary ugly #ifdef construct around debug register clear.
Signed-off-by: NPeter Zijlstra <a.p.zijlstra@chello.nl>
Signed-off-by: NH. Peter Anvin <hpa@linux.intel.com>