The new(ish) ft6236 simply re-implements the M09 protocol of the
(much) older edt-ft5x06.c driver.

This commit removes this duplicate driver and adds the i2c ids and
dt compatible string to the edt-ft5x06.c driver to keep compatibility.

This commit also adds the standard touchscreen properties as optional
properties to the edt,ft5x06 binding, these were documented in the
focaltech,ft6236 bindingi, but were missing from the edt,ft5x06 doc.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Add support for inverting / swapping axes using the new
touchscreen_parse_properties() and touchscreen_report_pos()
functionality.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Extend touchscreen_parse_properties() with support for the
touchscreen-inverted-x/y and touchscreen-swapped-x-y properties and
add touchscreen_set_mt_pos() and touchscreen_report_pos() helper
functions for storing coordinates into a input_mt_pos struct, or
directly reporting them, taking these properties into account.

This commit also modifies the existing callers of
touchscreen_parse_properties() to pass in NULL for the new third
argument, keeping the existing behavior.
Signed-off-by: NHans de Goede <hdegoede@redhat.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

A recent patch broke parsing the gain, offset, and threshold parameters
from device tree. Instead of setting the cached values and writing them
to the correct registers during probe, it would write the values from DT
into the register address variables and never write them to the chip
during normal operation.

Fixes: 2e23b7a9 ("Input: edt-ft5x06 - use generic properties API")
Signed-off-by: NPhilipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

In the touchscreen controller ISR, reading the tsc starting from
register 0x2 causes the tsc to infrequently update the detected
finger's x and y coordinate. The irq pin toggles at a fast rate to
indicate touch events are happening. However, the tsc on average
updates the touch point's x and y value every ~100 ms which is much
slower than the advertised rate of 100+ Hz. This leads to multiple reads
within this ~100 ms time window returning the same value.

Example:
X: 10 , Y: 30
X: 10 , Y: 30
X: 10,  Y: 30
..
// After 100 ms
X: 300, Y: 300
X: 300, y: 300
..
// After 100 ms
X: 1743, Y: 621
X: 1743, Y: 621

For some reason if instead of starting to read at register 0x2 you
start reading at register 0x0 this issue isn't seen. This seems like
a quirk only seen in the EDT FT5506 so to fix this issue simply
adjust the code to start reading from 0x0. Technically this isn't wrong
so no regressions should be seen with other touchscreen controllers
supported by this driver.
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

FT5506 is essentially the same as other FT5x06 devices other than
supporting 10 support points.
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Update the code so that the maximum supported points aren't hard coded but
can be changed.

Set the maximum support points based on the data passed along side the
compatible field.
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Calculate the amount of data that needs to be read for the specified max
number of support points. If the maximum number of support points changes
then the amount that is read from the touch screen controller should
reflect this.
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Since reset and wake pin are optional the gpio structure for those
pins may be null. Therefore, they can't be blindly passed to
desc_to_gpio.
Reported-by: NDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of hardcoding IRQ trigger type to IRQF_TRIGGER_FALLING, let's
respect settings specified in device tree. To be compatible with older
DTSes, if trigger type is not set up in DTS we'll set it to default
(falling edge).
Tested-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Instead of only parsing device tree properties let's switch to using
generic properties API so that the driver can also work on other platforms.
Tested-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

We do not have any users of platform data in the tree and all newer
platforms are either DT or ACPI, so let's drop handling of platform data.
Tested-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver does not use irq gpio as gpio, but rather relies on I2C core or
board code to set up client's structure IRQ line, so let's stop trying to
locate the resource and parse it.
Tested-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The current/old gpio framework used doesn't properly listen to
ACTIVE_LOW and ACTIVE_HIGH flags. The newer gpio framework takes into
account these flags when setting gpio values.

Since the values being output were based on voltage and not logic they
change to reflect this difference. Also use gpiod_set_value_cansleep since
wake and reset pins can be provided by bus based io expanders.

Switch from msleep(5) to udelay_range(5000,6000) to avoid check patch
warning.
Signed-off-by: NFranklin S Cooper Jr <fcooper@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

i2c_driver does not need to set an owner because i2c_register_driver()
will set it.
Signed-off-by: NKrzysztof Kozlowski <k.kozlowski@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Let's switch form OF to device properties so that common parsing code could
work not only on device tree but also on ACPI-based platforms.
Reviewed-by: NRoger Quadros <rogerq@ti.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

When applying touchscreen parameters specified in device tree let's make
sure we keep whatever setup was done by the driver and not reset the
missing values to zero.
Reported-by: NPavel Machek <pavel@ucw.cz>
Tested-by: NPavel Machek <pavel@ucw.cz>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

edt-ft5x06 is a touchscreen and thus a direct input device; let's amrk it
as such. This also allows us to drop some initialization code as
input_init_mt_slots() will do that for us.
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

input_register_device already sets the EV_SYN event since all devices can
generate them.

Remove the redundant affectation.
Signed-off-by: NMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Currently the driver relies on some obscure and undocumented register to set
the maximum axis value.

The reported value is way too high to be meaningful, which confuses some
userspace tools like QT's evdevtouch plugin which try to scale the reported
events to the maximum values.

Use the values from the DT to set meaningful values.
Signed-off-by: NMaxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Fixed a coding style error, macros with complex values should be
enclosed in parentheses.
Signed-off-by: NAsaf Vertz <asaf.vertz@tandemg.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use __maybe_unused instead of ifdef guards around suspend/resume
functions, in order to increase build coverage and fix build warnings.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The kernel used to contain two functions for length-delimited,
case-insensitive string comparison, strnicmp with correct semantics and
a slightly buggy strncasecmp.  The latter is the POSIX name, so strnicmp
was renamed to strncasecmp, and strnicmp made into a wrapper for the new
strncasecmp to avoid breaking existing users.

To allow the compat wrapper strnicmp to be removed at some point in the
future, and to avoid the extra indirection cost, do
s/strnicmp/strncasecmp/g.
Signed-off-by: NRasmus Villemoes <linux@rasmusvillemoes.dk>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Signed-off-by: NAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: NLinus Torvalds <torvalds@linux-foundation.org>

Somehow we ended up with a duplicate line in edt_ft5x06_register_write()
Signed-off-by: NMaks Naumov <maksqwe1@ukr.net>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Fix checkpatch warning:
"WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required"
Signed-off-by: NFabian Frederick <fabf@skynet.be>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The driver sends 3 bytes instead of 2 when accessing a register on the M09
firmware, so writing to gain seems to overflow into the offset register.
Signed-off-by: NRobert Woerle <robert@linuxdevelopment.de>
Acked-By: NSimon Budig <simon.budig@kernelconcepts.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The if condition was accidentally deleted here so we return every time
instead of returning on error.

Fixes: fd335ab0 ('Input: edt-ft5x06 - add support for M09 firmware version')
Signed-off-by: NDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: NJingoo Han <jg1.han@samsung.com>
Acked-By: NLothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

There is a new firmware version for the EDT-FT5x06 chip.
Add support for detecting the firmware version and handle the
differences appropriately.
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The chip may report invalid coordinates on touchdown events, so don't
report the initial touchdown event.
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

The FT5x06 datasheet specifies a minimum reset width of 5ms and a
delay between deassertion of reset and start of reporting of 300ms.
Adjust the delays to conform to the datasheet.

With the original delays I sometimes experienced communication
timeouts when initializing the controller.
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

- remove redundant parens
- remove redundant type casts
- fix mixed tab/space indentation
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Simplify the error path and remove() function by using devm_*
functions for requesting gpios and irq and allocating the input
device.
Signed-off-by: NLothar Waßmann <LW@KARO-electronics.de>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

Use the wrapper function for retrieving the platform data instead
of accessing dev->platform_data directly. This is a cosmetic change
to make the code simpler and enhance the readability.
Signed-off-by: NJingoo Han <jg1.han@samsung.com>
Acked-by: NFugang Duan <B38611@freescale.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

kfree on a null pointer is a no-op. Hence null check is not
necessary.
Signed-off-by: NSachin Kamat <sachin.kamat@linaro.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit is no
longer needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NMark Brown <broonie@opensource.wolfsonmicro.com>
Acked-by: NJavier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

CONFIG_HOTPLUG is going away as an option so __devexit_p is no longer
needed.
Signed-off-by: NBill Pemberton <wfp5p@virginia.edu>
Acked-by: NRussell King <rmk+kernel@arm.linux.org.uk>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.

dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: NWei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: NDmitry Torokhov <dmitry.torokhov@gmail.com>

copy_to_user() returns the number of bytes remaining, but we want a
negative error code here.
Signed-off-by: NAxel Lin <axel.lin@gmail.com>
Signed-off-by: NDmitry Torokhov <dtor@mail.ru>