1. 30 5月, 2018 1 次提交
    • A
      cpupower : Fix header name to read idle state name · f9652d5c
      Abhishek Goel 提交于
      The names of the idle states in the output of cpupower monitor command are
      truncated to 4 characters. On POWER9, this creates ambiguity as the states
      are named "stop0", "stop1", etc.
      
      root:~# cpupower monitor
                    |Idle_Stats
      PKG |CORE|CPU | snoo | stop | stop | stop | stop | stop | stop
         0|   0|   0|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  1.90
         0|   0|   1|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
         0|   0|   2|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
         0|   0|   3|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
      
      This patch modifies the output to print the state name that results in a
      legible output. The names will be printed with atmost 1 padding in left.
      
      root:~# cpupower monitor
                    | Idle_Stats
       PKG|CORE| CPU|snooze|stop0L| stop0|stop1L| stop1|stop2L| stop2
         0|   0|   0|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.72
         0|   0|   1|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
         0|   0|   2|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
         0|   0|   3|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00|  0.00
      
      This patch does not affect the output for intel.
      Output for intel before applying the patch:
      
      root:~# cpupower monitor
          |Idle_Stats
      CPU | POLL | C1-S | C1E- | C3-S | C6-S | C7s- | C8-S | C9-S | C10-
         0|  0.00|  0.14|  0.39|  0.35|  7.41|  0.00| 17.67|  1.01| 70.03
         2|  0.00|  0.19|  0.47|  0.10|  6.50|  0.00| 29.66|  2.17| 58.07
         1|  0.00|  0.11|  0.50|  1.50|  9.11|  0.18| 18.19|  0.40| 66.63
         3|  0.00|  0.67|  0.42|  0.03|  5.84|  0.00| 12.58|  0.77| 77.14
      
      Output for intel after applying the patch:
      
      root:~# cpupower monitor
          | Idle_Stats
       CPU| POLL | C1-S | C1E- | C3-S | C6-S | C7s- | C8-S | C9-S | C10-
         0|  0.03|  0.33|  1.01|  0.27|  3.03|  0.00| 19.18|  0.00| 71.24
         2|  0.00|  1.58|  0.58|  0.42|  8.55|  0.09| 21.11|  0.99| 63.32
         1|  0.00|  1.26|  0.88|  0.43|  9.00|  0.02|  7.78|  4.65| 71.91
         3|  0.00|  0.30|  0.42|  0.06| 13.62|  0.21| 30.29|  0.00| 52.45
      Signed-off-by: NAbhishek Goel <huntbag@linux.vnet.ibm.com>
      Signed-off-by: NShuah Khan (Samsung OSG) <shuah@kernel.org>
      f9652d5c
  2. 02 11月, 2015 1 次提交
    • J
      cpupower: cpupower monitor reports uninitialized values for offline cpus · 20102ac5
      Jacob Tanenbaum 提交于
      [root@hp-dl980g7-02 linux]# cpupower monitor
      ...
      5472|   0|   1|******|******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
      10567|   0| 159|******|******|******|******||  0.00|  0.00|  0.00|  0.00|  0.00 *is offline
      1661206560|859272560| 150|******|******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
      1661206560|943093104| 140|******|******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
      
      because of this cpupower also holds the incorrect value for the number
      of physical packages in the machine
      
      Changed cpupower to initialize the values of an offline cpu's socket and
      core to -1, warn the user that one or more cpus is/are
      offline and not print statistics for offline cpus.
      
      This fix hides offlined cores where topology cannot be accessed.
      With a recent kernel patch suggested from Prarit Bhargava it may be possible
      that soft offlined cores' topology can still be parsed.
      This patch would then show which cores in which package/socket are offline,
      when sane toplogoy information is available.
      Signed-off-by: NJacob Tanenbaum <jtanenba@redhat.com>
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      20102ac5
  3. 28 11月, 2012 2 次提交
    • T
      cpupower: Provide -c param for cpupower monitor to schedule process on all cores · c8cfc3c6
      Thomas Renninger 提交于
      If an MSR based monitor is run in parallel this is not needed. This is the
      default case on all/most Intel machines.
      
      But when only sysfs info is read via cpupower monitor -m Idle_Stats (typically
      the case for non root users) or when other monitors are PCI based (AMD),
      Idle_Stats, read from sysfs can be totally bogus:
      
      cpupower monitor -m Idle_Stats
      PKG |CORE|CPU | POLL | C1-N | C3-N | C6-N
         0|   0|   0|  0.00|  0.00|  0.24| 99.81
         0|   0|  32|  0.00|  0.00|  0.00| 100.7
      ...
         0|  17|  20|  0.00|  0.00|  0.00| 173.1
         0|  17|  52|  0.00|  0.00|  0.07| 173.0
         0|  18|  68|  0.00|  0.00|  0.00|  0.00
         0|  18|  76|  0.00|  0.00|  0.00|  0.00
      ...
      
      With the -c option all cores are woken up and the kernel
      did update cpuidle statistics before reading out sysfs.
      This causes some overhead. Therefore avoid if possible, use
      if needed:
      
      cpupower monitor -c -m Idle_Stats
      PKG |CORE|CPU | POLL | C1-N | C3-N | C6-N
         0|   0|   0|  0.00|  0.00|  0.00| 100.2
         0|   0|  32|  0.00|  0.00|  0.00| 100.2
      ...
         0|   8|   8|  0.00|  0.00|  0.00| 99.82
         0|   8|  40|  0.00|  0.00|  0.00| 99.81
         0|   9|  24|  0.00|  0.00|  0.00| 100.3
         0|   9|  56|  0.00|  0.00|  0.00| 100.2
         0|  16|   4|  0.00|  0.00|  0.00| 99.75
         0|  16|  36|  0.00|  0.00|  0.00| 99.38
      ...
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      c8cfc3c6
    • P
      cpupower tools: Fix minor warnings · fb8eaeb7
      Palmer Cox 提交于
      Fix minor warnings reported with GCC 4.6:
      * The sysfs_write_file function is unused - remove it.
      * The pr_mon_len in the print_header function is unsed - remove it.
      Signed-off-by: NPalmer Cox <p@lmercox.com>
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NRafael J. Wysocki <rafael.j.wysocki@intel.com>
      fb8eaeb7
  4. 19 8月, 2011 1 次提交
  5. 16 8月, 2011 2 次提交
    • T
      cpupower: Make monitor command -c/--cpu aware · 9ee31f61
      Thomas Renninger 提交于
      This allows for example:
      cpupower -c 2-4,6 monitor -m Mperf
                    |Mperf
      PKG |CORE|CPU | C0   | Cx   | Freq
         0|   8|   4|  2.42| 97.58|  1353
         0|  16|   2| 14.38| 85.62|  1928
         0|  24|   6|  1.76| 98.24|  1442
         1|  16|   3| 15.53| 84.47|  1650
      
      CPUs always get resorted for package, core then cpu id if it could get read out
      (or however you name these topology levels...).
      Still this is a nice way to keep the overview if a test binary is bound to
      a specific CPU or if one wants to show all CPUs inside a package or similar.
      
      Still missing: Do not measure not available cores to reduce the overhead
      and achieve better results.
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      9ee31f61
    • T
      cpupower: Better detect offlined CPUs · 7c74d2bc
      Thomas Renninger 提交于
      Before, checking for offlined CPUs was done dirty and
      it was checked whether topology parsing returned -1 values.
      But this is a valid case on a Xen (and possibly other) kernels.
      
      Do proper online/offline checking, also take CONFIG_HOTPLUG_CPU
      option into account (no /sys/devices/../cpuX/online file).
      Signed-off-by: NThomas Renninger <trenn@suse.de>
      Signed-off-by: NDominik Brodowski <linux@dominikbrodowski.net>
      7c74d2bc
  6. 30 7月, 2011 2 次提交