This driver now uses regmap APIs, so it needs to select REGMAP_I2C.
Signed-off-by: NAxel Lin <axel.lin@ingics.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Currently the label says "Core" but lists the thread numbers. This
ends up looking like this:
    # cat /sys/class/hwmon/hwmon0/temp[1-4]_label
    Core 0-7
    Core 8-15
    Core 16-23
    Core 24-31

This is misleading as it looks like it's cores 0-7 when it's actually
threads 0-7.

This changes the print to just give the core number, so the output now
looks like this:
    # cat /sys/class/hwmon/hwmon0/temp[1-4]_label
    Core 0
    Core 8
    Core 16
    Core 24
Signed-off-by: NMichael Neuling <mikey@neuling.org>
Acked-by: NCédric Le Goater <clg@kaod.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

adt7470_remove will wait for the update thread to complete before
returning. This had a worst-case time of up to the user-configurable
auto_update_interval.

Replace msleep_interruptible with set_current_state and schedule_timeout
so that kthread_stop will interrupt the sleep.
Signed-off-by: NJoshua Scott <joshua.scott@alliedtelesis.co.nz>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add write support for the alarm_mask. A base of 0 is provided so that
either hex or decimal can be used. The hex format when reading alarm_mask
is unchanged.
Signed-off-by: NJoshua Scott <joshua.scott@alliedtelesis.co.nz>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The newly added hwmon driver fails to build in an allmodconfig
kernel:

      ERROR: "memblock_is_memory" [drivers/hwmon/xgene-hwmon.ko] undefined!

According to comments in the code, the mailbox is a shared memory region,
not a set of MMIO registers, so we should use memremap() for mapping it
instead of ioremap or acpi_os_ioremap, and pointer dereferences instead
of readl/writel.

The driver already uses plain kernel pointers, so it's a bit unusual
to work with functions that operate on __iomem pointers, and this
fixes that part too.

I'm using READ_ONCE/WRITE_ONCE here to keep the existing behavior
regarding the ordering of the accesses from the CPU, but note that
there are no barriers (also unchanged from before).

I'm also keeping the endianness behavior, though I'm unsure whether
the message data was supposed to be in LE32 format in the first
place, it's possible this was meant to be interpreted as a byte
stream instead.
Signed-off-by: NArnd Bergmann <arnd@arndb.de>
Acked-by: NHoan Tran <hotran@apm.com>
Tested-by: NHoan Tran <hotran@apm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.

Other changes:

- Convert to use regmap, and drop local caching. This avoids reading
  registers unnecessarily, and uses regmap for caching of non-volatile
  registers.
- Add support for temp2_max, temp2_max_alarm, temp2_max_hyst, and
  temp2_offset.
- Order include files alphabetically
- Drop FSF address
- Check errors from register read and write functions and report
  to userspace.
- Accept negative hysteresis values. While unlikely, a maximum limit
  _can_ be set to a value smaller than 31 degrees C, which makes negative
  hysteresis values possible.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Reduce driver complexity and size by converting it to
the new hwmon API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Simplify code and reduce code size by using the new hwmon
registration API.
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The system crashes during probing xgene-hwmon driver when temperature
alarm interrupt occurs before.
It's because
 - xgene_hwmon_probe() requests mailbox channel which also enables
   the mailbox interrupt.
 - As temperature alarm interrupt is pending, ISR runs and crashes when
   accesses into invalid resourse as unmapped PCC shared memory.

This patch fixes this issue by saving this alarm message and scheduling a
bottom handler after xgene_hwmon_probe() finish.
Signed-off-by: NHoan Tran <hotran@apm.com>
Reported-by: NItaru Kitayama <itaru.kitayama@riken.jp>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

iio_channel_get_all returns -ENODEV when it cannot find either phandles and
properties in the Device Tree or channels whose consumer_dev_name matches
iio_hwmon in iio_map_list. The iio_map_list is filled in by iio drivers
which might be probed after iio_hwmon.

It is better to defer the probe of iio_hwmon if such error is returned by
iio_channel_get_all in order to let a chance to iio drivers to expose
channels in iio_map_list.
Signed-off-by: NQuentin Schulz <quentin.schulz@free-electrons.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add devicetree property for early initialization of the fan controller
to prevent overheating, for example when resetting the board while the
fan was completely turned off.
Signed-off-by: NMike Looijmans <mike.looijmans@topic.nl>
Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The fan can be stopped by writing "3" to pwm1_enable in sysfs.

Add devicetree property for early initialization of the fan controller
to prevent overheating, for example when resetting the board while the
fan was completely turned off.

Also improve error reporting, I2C failures were ignored while writing
new values.
Signed-off-by: NMike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Parse devicetree parameters for voltage and prescaler setting. This allows
using multiple max6550 devices with varying settings, and also makes it
possible to instantiate and configure the device using devicetree.
Signed-off-by: NMike Looijmans <mike.looijmans@topic.nl>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

This adds the devicetree binding documentation for the max6650 fan
controller.
Signed-off-by: NMike Looijmans <mike.looijmans@topic.nl>
Acked-by: NRob Herring <robh@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Remove the index comments at the end of it87_attributes_in. They
serve no purpose (as there is no reference to them in
it87_in_is_visible) and some of them were obviously wrong.
Signed-off-by: NJean Delvare <jdelvare@suse.de>
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The UCD90160 Power Supply Sequencer reuses the existing register layout,
so just an id addition was required.
Signed-off-by: NMatthew Weber <matthew.weber@rockwellcollins.com>
Signed-off-by: NRonak Desai <ronak.desai@rockwellcollins.com>
[groeck: Updated description, ordered alphabetically, added documentation]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The field "owner" is set by the core.
Thus delete an unneeded initialisation.

Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: NMarkus Elfring <elfring@users.sourceforge.net>
Acked-by: NSudeep Holla <sudeep.holla@arm.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Signed-off-by: NThilo Cestonaro <thilo@cestona.ro>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

This patch adds hardware temperature and power reading support for
APM X-Gene SoC using the mailbox communication interface.
Signed-off-by: NHoan Tran <hotran@apm.com>
Reviewed-by: NGuenter Roeck <linux@roeck-us.net>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

If both hwmon and thermal_sys are built as modules, and
CONFIG_THERMAL_HWMON is enabled, the following cyclic module dependency
is reported.

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: hwmon -> thermal_sys -> hwmon

Fixes: e4bce763adb2 ("hwmon: (core) New hwmon registration API")
Reported-by: NVignesh R <vigneshr@ti.com>
Cc: Keerthy J <j-keerthy@ti.com>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

The ADT7470 supports a variety of PWM frequencies. This patch allows the
frequency to be configured and viewed through the sysfs entry pwm1_freq.
Signed-off-by: NJoshua Scott <joshua.scott@alliedtelesis.co.nz>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Allow to specify the resistance of the attached shunt via DT by
adding the shunt-resistor property. Fall-back to the previous
default (1 mOhm) if unset.
Signed-off-by: NDaniel Golle <daniel@makrotopia.org>
[groeck: Fixed 'line over 80 columns' checkpatch warning]
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Signed-off-by: NDaniel Golle <daniel@makrotopia.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Since commit 698a7c24 ("hwmon: (nct6775) Support two SuperIO chips
in the same system"), the driver supports two Super-IO chips. This has
the undesirable side effect that force_id always detects a second chip
at address 0xfff8, even if no chip exists at that address.

nct6775: Found NCT6793D or compatible chip at 0x4e:0xfff8

If no chip at all is found at a given SIO address, it does not make sense
to instantiate it. Limit force_id to only work if some chip is found,
that is if the chip ID returns a value other than 0xffff.
Reviewed-by: NJean Delvare <jdelvare@suse.de>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Add basic pwm attribute support (no auto attributes) to new API.
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Describe the new registration API function as well as the data
structures it requires.
Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Up to now, each hwmon driver has to implement its own sysfs attributes.
This requires a lot of template code, and distracts from the driver's core
function to read and write chip registers.

To be able to reduce driver complexity, move sensor attribute handling
and thermal zone registration into hwmon core. By using the new API,
driver code and data size is typically reduced by 20-70%, depending
on driver complexity and the number of sysfs attributes supported.

With this patch, the new API only supports thermal sensors. Support for
other sensor types will be added with subsequent patches.
Acked-by: NPunit Agrawal <punit.agrawal@arm.com>
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>

Ordering include files alphabetically makes it easier to add new ones.
Stop including linux/spinlock.h and linux/kdev_t.h since both are not
needed.
Reviewed-by: NJonathan Cameron <jic23@kernel.org>
Signed-off-by: NGuenter Roeck <linux@roeck-us.net>