1. 30 10月, 2013 1 次提交
  2. 01 10月, 2013 1 次提交
    • J
      ARM: edma: Fix clearing of unused list for DT DMA resources · 6cdaca48
      Joel Fernandes 提交于
      HWMOD removal for MMC is breaking edma_start as the events are being manually
      triggered due to unused channel list not being clear.
      
      The above issue is fixed by reading the "dmas" property from the DT node if it
      exists and clearing the bits in the unused channel list if the dma controller
      used by any device is EDMA. For this purpose we use the of_* helpers to parse
      the arguments in the dmas phandle list.
      
      Also introduced is a minor clean up of a checkpatch error in old code.
      Reviewed-by: NSekhar Nori <nsekhar@ti.com>
      Reported-by: NBalaji T K <balajitk@ti.com>
      Cc: Sekhar Nori <nsekhar@ti.com>
      Cc: Tony Lindgren <tony@atomide.com>
      Cc: Olof Johansson <olof@lixom.net>
      Cc: Nishanth Menon <nm@ti.com>
      Cc: Pantel Antoniou <panto@antoniou-consulting.com>
      Cc: Jason Kridner <jkridner@beagleboard.org>
      Cc: Koen Kooi <koen@dominion.thruhere.net>
      Signed-off-by: NJoel Fernandes <joelf@ti.com>
      Signed-off-by: NOlof Johansson <olof@lixom.net>
      6cdaca48
  3. 04 9月, 2013 1 次提交
  4. 16 7月, 2013 1 次提交
  5. 24 6月, 2013 2 次提交
  6. 18 6月, 2013 3 次提交
  7. 12 3月, 2013 1 次提交
  8. 09 5月, 2012 2 次提交
    • A
      arm: davinci: use for_each_set_bit_from · 98e3b339
      Akinobu Mita 提交于
      Use for_each_set_bit_from to iterate over all the set bit in a memory
      region.
      Signed-off-by: NAkinobu Mita <akinobu.mita@gmail.com>
      Acked-by: NSekhar Nori <nsekhar@ti.com>
      Cc: Sekhar Nori <nsekhar@ti.com>
      Cc: Christian Riesch <christian.riesch@omicron.at>
      Cc: Kevin Hilman <khilman@ti.com>
      Cc: davinci-linux-open-source@linux.davincidsp.com
      Cc: Russell King <linux@arm.linux.org.uk>
      Cc: linux-arm-kernel@lists.infradead.org
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      98e3b339
    • S
      ARM: davinci: optimize the DMA ISR · bcd59b0f
      Sebastian Andrzej Siewior 提交于
      The ISR does quiete a lot of hw access which could be avoided. First it
      checks for a pending interrupt by reading alteast one register. Then it
      checks for the "activated" slots by reading another register. This is
      more or a less a must.
      Now, once it found an active slot it does the same two reads again.
      After that it "knows" that there must be a pending transfer however it
      cross checks with the other register. There are 32 bit in an interger
      which are polled instead of considering only the set bits and ignoring
      those which are zero. This performs atleast 32 reads which could be
      avoided. In case of a first match it does another read.
      This patch reorganizes the access by re-using the register which have
      been read and then uses ffs() to find the matching slot instead looping
      over it. By doing this we get rid of the last (32 + 2 + hits) reads.
      
      It is possible however that by really busy bank0 we never get to handle
      bank1. If this is a problem, we could try to handle bank1 after we are
      done with bank0 to check if there are any outstanding transfers.
      
      To put some numbers on this, this is from spi transfer via spidev. The
      first column is the number of total transfers, the time stamp is taken
      before and after the ioctl():
      
      |10000, min: 542us      avg: 591us
      |20000, min: 542us      avg: 592us
      |30000, min: 542us      avg: 592us
      |40000, min: 542us      avg: 585us
      |50000, min: 542us      avg: 593us
      
      The same test case with the patch applied
      |10000, min: 444us      avg: 493us
      |20000, min: 444us      avg: 491us
      |30000, min: 444us      avg: 489us
      |40000, min: 444us      avg: 491us
      |50000, min: 444us      avg: 492us
      
      that is almost 100us that just went away.
      Signed-off-by: NSebastian Andrzej Siewior <bigeasy@linutronix.de>
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      bcd59b0f
  9. 03 2月, 2012 1 次提交
  10. 17 9月, 2011 2 次提交
    • T
      ARM: davinci: edma: use kzalloc() · 902532db
      Thomas Meyer 提交于
       Use kzalloc rather than kmalloc followed by memset with 0
      
       This considers some simple cases that are common and easy to validate
       Note in particular that there are no ...s in the rule, so all of the
       matched code has to be contiguous
      
       The semantic patch that makes this output is available
       in scripts/coccinelle/api/alloc/kzalloc-simple.cocci.
      
       More information about semantic patching is available at
       http://coccinelle.lip6.fr/Signed-off-by: NThomas Meyer <thomas@m3y3r.de>
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      902532db
    • I
      ARM: davinci: Explicitly set channel controllers' default queues · f23fe857
      Ido Yariv 提交于
      Davinci platforms may define a default queue for each channel
      controller. If one is not defined, the default queue is set to EVENTQ_1.
      However, there's no way to distinguish between an unset default queue to
      one that is set to EVENTQ_0, as EVENTQ_0 = 0.
      
      Explicitly specify the default queue for all channel controllers on all
      Davinci platforms to EVENTQ_1, and don't overwrite it in the EDMA probe
      function.
      
      One exception is the DA850 board, for which EVENTQ_1 is not a valid
      option for its second channel controller. Use EVENTQ_0 instead for that
      channel controller.
      Signed-off-by: NIdo Yariv <ido@wizery.com>
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      f23fe857
  11. 24 9月, 2010 1 次提交
  12. 06 8月, 2010 2 次提交
    • R
      davinci: support for EDMA resource sharing · 90bd4e6d
      Rajashekhara, Sudhakar 提交于
      Current EDMA driver is not taking care of EDMA channels/slots
      which are allocated from other processor, say DSP. If a
      channel/slot is allocated from DSP, the existing EDMA driver
      can still allocate the same resource on ARM.
      
      This patch enables the user to pass the channel/slots reserved
      for DSP as platform data. EDMA driver scans this list during
      probe and prepares a bitmap of channel/slots which can be used
      on ARM side.
      
      Trying to reserve channels by doing a 'pre-allocate' using
      edma_alloc_{slot|channel}() API does not work because
      
      1) The reservation should be done in probe() to avoid race
         with other ARM side driver trying to use EDMA
      
      2) The alloc channel API sets up the access through shadow region
         0 which will be incorrect for DSP usage. It also sets up the
         channel <-> queue number mapping which is not required as DSP
         will likely do its own mapping anyway.
      
      3) (minor) There is no API to allocate channels in bulk.
      Signed-off-by: NSudhakar Rajashekhara <sudhakar.raj@ti.com>
      Cc: David Brownell <david-b@pacbell.net>
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      90bd4e6d
    • S
      davinci: edma: provide ability to detect insufficient CC info data · bc3ac9f3
      Sekhar Nori 提交于
      This patch modifies the EDMA driver to expect the channel
      controller (CC) infomation passed on by the platform as a fixed
      size (EDMA_MAX_CC) array of pointers to structures.
      
      Doing so helps catch errors of the sort where the resource
      structure has information for more channel controllers than
      the number channel controller info structures defined.
      
      Such insufficient platform data would lead to illegal memory
      accesses.
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      bc3ac9f3
  13. 14 5月, 2010 2 次提交
  14. 07 5月, 2010 3 次提交
    • S
      davinci: edma: fix coding style issue related to usage of braces · 243bc654
      Sekhar Nori 提交于
      In the edma driver, there are couple of instances where braces
      are used for a single statement 'if' construct.
      
      There are other instances where 'else' part of the if-else construct
      does not use braces even if the 'if' part is a multi-line statement.
      
      This patch fixes both.
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      243bc654
    • S
      davinci: edma: use a more intuitive name for edma_info · 3f68b98a
      Sekhar Nori 提交于
      'edma_info' structure inside the edma driver represents
      a single instance of edma channel controller. Call it
      'edma_cc' instead. This also avoids readers confusing
      it with an instance of edma_soc_info structre which
      carries the platform data for a single channel controller
      instance.
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      3f68b98a
    • A
      davinci: edma: clear interrupt status for interrupt enabled channels only · a7e05065
      Anuj Aggarwal 提交于
      Currently, the ISR in the EDMA driver clears the pending interrupt for all
      channels without regard to whether that channel has a registered callback
      or not.
      
      This causes problems for devices like DM355/DM365 where the multimedia
      accelerator uses EDMA by polling on the interrupt pending bits of some of the
      EDMA channels. Since these channels are actually allocated through the Linux
      EDMA driver (by an out-of-kernel module), the same shadow region is used by
      Linux and accelerator. There a race between the Linux ISR and the polling code
      running on the accelerator on the IPR (interrupt pending register).
      
      This patch fixes the issue by making the ISR clear the interrupts only for
      those channels which have interrupt enabled. The channels which are allocated
      for the purpose of being polled on by the accelerator will not have a callback
      function provided and so will not have IER (interrupt enable register) bits set.
      
      Tested on DM365 and OMAP-L137/L138 with audio and MMC/SD (as EDMA users).
      Signed-off-by: NAnuj Aggarwal <anuj.aggarwal@ti.com>
      Signed-off-by: NSekhar Nori <nsekhar@ti.com>
      CC: Archith John Bency <archith@ti.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      a7e05065
  15. 06 4月, 2010 1 次提交
    • B
      davinci: edma: clear events in edma_start() · bb17ef10
      Brian Niebuhr 提交于
      This patch fixes an issue where a DMA channel can erroneously process an
      event generated by a previous transfer.  A failure case is where DMA is
      being used for SPI transmit and receive channels on OMAP L138.  In this
      case there is a single bit that controls all event generation from the
      SPI peripheral.  Therefore it is possible that between when edma_stop()
      has been called for the transmit channel on a previous transfer and
      edma_start() is called for the transmit channel on a subsequent transfer,
      that a transmit event has been generated.
      
      The fix is to clear events in edma_start().  This prevents false events
      from being processed when events are enabled for that channel.
      Signed-off-by: NBrian Niebuhr <bniebuhr@efjohnson.com>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      bb17ef10
  16. 30 3月, 2010 1 次提交
    • T
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking... · 5a0e3ad6
      Tejun Heo 提交于
      include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
      
      percpu.h is included by sched.h and module.h and thus ends up being
      included when building most .c files.  percpu.h includes slab.h which
      in turn includes gfp.h making everything defined by the two files
      universally available and complicating inclusion dependencies.
      
      percpu.h -> slab.h dependency is about to be removed.  Prepare for
      this change by updating users of gfp and slab facilities include those
      headers directly instead of assuming availability.  As this conversion
      needs to touch large number of source files, the following script is
      used as the basis of conversion.
      
        http://userweb.kernel.org/~tj/misc/slabh-sweep.py
      
      The script does the followings.
      
      * Scan files for gfp and slab usages and update includes such that
        only the necessary includes are there.  ie. if only gfp is used,
        gfp.h, if slab is used, slab.h.
      
      * When the script inserts a new include, it looks at the include
        blocks and try to put the new include such that its order conforms
        to its surrounding.  It's put in the include block which contains
        core kernel includes, in the same order that the rest are ordered -
        alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
        doesn't seem to be any matching order.
      
      * If the script can't find a place to put a new include (mostly
        because the file doesn't have fitting include block), it prints out
        an error message indicating which .h file needs to be added to the
        file.
      
      The conversion was done in the following steps.
      
      1. The initial automatic conversion of all .c files updated slightly
         over 4000 files, deleting around 700 includes and adding ~480 gfp.h
         and ~3000 slab.h inclusions.  The script emitted errors for ~400
         files.
      
      2. Each error was manually checked.  Some didn't need the inclusion,
         some needed manual addition while adding it to implementation .h or
         embedding .c file was more appropriate for others.  This step added
         inclusions to around 150 files.
      
      3. The script was run again and the output was compared to the edits
         from #2 to make sure no file was left behind.
      
      4. Several build tests were done and a couple of problems were fixed.
         e.g. lib/decompress_*.c used malloc/free() wrappers around slab
         APIs requiring slab.h to be added manually.
      
      5. The script was run on all .h files but without automatically
         editing them as sprinkling gfp.h and slab.h inclusions around .h
         files could easily lead to inclusion dependency hell.  Most gfp.h
         inclusion directives were ignored as stuff from gfp.h was usually
         wildly available and often used in preprocessor macros.  Each
         slab.h inclusion directive was examined and added manually as
         necessary.
      
      6. percpu.h was updated not to include slab.h.
      
      7. Build test were done on the following configurations and failures
         were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
         distributed build env didn't work with gcov compiles) and a few
         more options had to be turned off depending on archs to make things
         build (like ipr on powerpc/64 which failed due to missing writeq).
      
         * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
         * powerpc and powerpc64 SMP allmodconfig
         * sparc and sparc64 SMP allmodconfig
         * ia64 SMP allmodconfig
         * s390 SMP allmodconfig
         * alpha SMP allmodconfig
         * um on x86_64 SMP allmodconfig
      
      8. percpu.h modifications were reverted so that it could be applied as
         a separate patch and serve as bisection point.
      
      Given the fact that I had only a couple of failures from tests on step
      6, I'm fairly confident about the coverage of this conversion patch.
      If there is a breakage, it's likely to be something in one of the arch
      headers which should be easily discoverable easily on most builds of
      the specific arch.
      Signed-off-by: NTejun Heo <tj@kernel.org>
      Guess-its-ok-by: NChristoph Lameter <cl@linux-foundation.org>
      Cc: Ingo Molnar <mingo@redhat.com>
      Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
      5a0e3ad6
  17. 05 2月, 2010 4 次提交
  18. 26 11月, 2009 5 次提交
  19. 26 8月, 2009 3 次提交
  20. 28 4月, 2009 1 次提交
    • K
      davinci: add EDMA driver · a4768d22
      Kevin Hilman 提交于
      Original code for 2.6.10 and 2.6.28 series done by Texas Instruments
      and MontaVista, but major updates and rework done by Troy Kisky and
      David Brownell.
      
      Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
      Cc: Sudhakar Rajashekhara <sudhakar.raj@ti.com>
      Cc: Troy Kisky <troy.kisky@boundarydevices.com>
      Cc: David Brownell <dbrownell@users.sourceforge.net>
      Signed-off-by: NKevin Hilman <khilman@deeprootsystems.com>
      a4768d22