1. 28 10月, 2010 7 次提交
    • M
      ARM: 6466/1: implement flush_icache_all for the rest of the CPUs · c8c90860
      Mika Westerberg 提交于
      Commit 81d11955 ("ARM: 6405/1: Handle __flush_icache_all for
      CONFIG_SMP_ON_UP") added a new function to struct cpu_cache_fns:
      flush_icache_all(). It also implemented this for v6 and v7 but not
      for v5 and backwards. Without the function pointer in place, we
      will be calling wrong cache functions.
      
      For example with ep93xx we get following:
      
          Unable to handle kernel paging request at virtual address ee070f38
          pgd = c0004000
          [ee070f38] *pgd=00000000
          Internal error: Oops: 80000005 [#1] PREEMPT
          last sysfs file:
          Modules linked in:
          CPU: 0    Not tainted  (2.6.36+ #1)
          PC is at 0xee070f38
          LR is at __dma_alloc+0x11c/0x2d0
          pc : [<ee070f38>]    lr : [<c0032c8c>]    psr: 60000013
          sp : c581bde0  ip : 00000000  fp : c0472000
          r10: c0472000  r9 : 000000d0  r8 : 00020000
          r7 : 0001ffff  r6 : 00000000  r5 : c0472400  r4 : c5980000
          r3 : c03ab7e0  r2 : 00000000  r1 : c59a0000  r0 : c5980000
          Flags: nZCv  IRQs on  FIQs on  Mode SVC_32  ISA ARM  Segment kernel
          Control: c000717f  Table: c0004000  DAC: 00000017
          Process swapper (pid: 1, stack limit = 0xc581a270)
          [<c0032c8c>] (__dma_alloc+0x11c/0x2d0)
          [<c0032e5c>] (dma_alloc_writecombine+0x1c/0x24)
          [<c0204148>] (ep93xx_pcm_preallocate_dma_buffer+0x44/0x60)
          [<c02041c0>] (ep93xx_pcm_new+0x5c/0x88)
          [<c01ff188>] (snd_soc_instantiate_cards+0x8a8/0xbc0)
          [<c01ff59c>] (soc_probe+0xfc/0x134)
          [<c01adafc>] (platform_drv_probe+0x18/0x1c)
          [<c01acca4>] (driver_probe_device+0xb0/0x16c)
          [<c01ac284>] (bus_for_each_drv+0x48/0x84)
          [<c01ace90>] (device_attach+0x50/0x68)
          [<c01ac0f8>] (bus_probe_device+0x24/0x44)
          [<c01aad7c>] (device_add+0x2fc/0x44c)
          [<c01adfa8>] (platform_device_add+0x104/0x15c)
          [<c0015eb8>] (simone_init+0x60/0x94)
          [<c0021410>] (do_one_initcall+0xd0/0x1a4)
      
      __dma_alloc() calls (inlined) __dma_alloc_buffer() which ends up
      calling dmac_flush_range(). Now since the entries in the
      arm920_cache_fns are shifted by one, we jump into address 0xee070f38
      which is actually next instruction after the arm920_cache_fns
      structure.
      
      So implement flush_icache_all() for the rest of the supported CPUs
      using a generic 'invalidate I cache' instruction.
      Signed-off-by: NMika Westerberg <mika.westerberg@iki.fi>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      c8c90860
    • M
      ARM: 6464/2: fix spinlock recursion in adjust_pte() · 4e54d93d
      Mika Westerberg 提交于
      When running following code in a machine which has VIVT caches and
      USE_SPLIT_PTLOCKS is not defined:
      
        fd = open("/etc/passwd", O_RDONLY);
        addr = mmap(NULL, 4096, PROT_READ, MAP_SHARED, fd, 0);
        addr2 = mmap(NULL, 4096, PROT_READ, MAP_SHARED, fd, 0);
      
        v = *((int *)addr);
      
      we will hang in spinlock recursion in the page fault handler:
      
        BUG: spinlock recursion on CPU#0, mmap_test/717
        lock: c5e295d8, .magic: dead4ead, .owner: mmap_test/717,
                        .owner_cpu: 0
        [<c0026604>] (unwind_backtrace+0x0/0xec)
        [<c014ee48>] (do_raw_spin_lock+0x40/0x140)
        [<c0027f68>] (update_mmu_cache+0x208/0x250)
        [<c0079db4>] (__do_fault+0x320/0x3ec)
        [<c007af7c>] (handle_mm_fault+0x2f0/0x6d8)
        [<c0027834>] (do_page_fault+0xdc/0x1cc)
        [<c00202d0>] (do_DataAbort+0x34/0x94)
      
      This comes from the fact that when USE_SPLIT_PTLOCKS is not defined,
      the only lock protecting the page tables is mm->page_table_lock
      which is already locked before update_mmu_cache() is called.
      Signed-off-by: NMika Westerberg <mika.westerberg@iki.fi>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      4e54d93d
    • R
      ARM: fix memblock breakage · 4e929d2b
      Russell King 提交于
      Will says:
      | Commit e63075a3 removed the explicit MEMBLOCK_REAL_LIMIT #define
      | and introduced the requirement that arch code calls
      | memblock_set_current_limit to ensure that the __va macro can
      | be used on physical addresses returned from memblock_alloc.
      
      Unfortunately, ARM was missed out of this change.  Fix this.
      Reported-by: NWill Deacon <will.deacon@arm.com>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      4e929d2b
    • T
      ARM: 6465/1: Fix data abort accessing proc_info from __lookup_processor_type · 88d927e9
      Tony Lindgren 提交于
      Commit 5085f3ff added better support for
      CONFIG_HOTPLUG_CPU by keeping proc_info around. However, depending on
      the Kconfig options selected, this can make the booting fail mysteriously
      early on.
      
      Turns out a data abort can happen in __lookup_processor in ldmia r5 {r3, r4}.
      When it happens the address loaded to r5 is not aligned. Fix the problem by
      aligning proc_info.
      Reported-by: NAnand Gadiyar <gadiyar@ti.com>
      Tested-by: NAnand Gadiyar <gadiyar@ti.com>
      Signed-off-by: NTony Lindgren <tony@atomide.com>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      88d927e9
    • U
      ARM: 6460/1: ixp2000: fix type of ixp2000_timer_interrupt · d463f363
      Uwe Kleine-König 提交于
      This fixes a build warning existing since at least 2.6.30:
      
      	arch/arm/mach-ixp2000/core.c:217: warning: initialization from incompatible pointer type
      Signed-off-by: NUwe Kleine-König <u.kleine-koenig@pengutronix.de>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      d463f363
    • M
      ARM: 6449/1: Fix for compiler warning of uninitialized variable. · 521e9549
      Marcelo Roberto Jimenez 提交于
      ARM: mach-sa1100: Fix for compiler warning of uninitialized variable.
      
      This is a fix for the compiler warning: 'new_ppcr' may be used
      uninitialized in this function.
      Signed-off-by: NMarcelo Roberto Jimenez <mroberto@cpti.cetuc.puc-rio.br>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      521e9549
    • L
      ARM: 6445/1: fixup TCM memory types · f444fce3
      Linus Walleij 提交于
      After Santosh's fixup of the generic MT_MEMORY and
      MT_MEMORY_NONCACHED I add this fix to the TCM memory types.
      The main change is that the ITCM memory is L_PTE_WRITE and
      DOMAIN_KERNEL which works just fine. The changed to the DTCM
      is just cosmetic to fit with surrounding code.
      
      Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
      Cc: Rickard Andersson <rickard.andersson@stericsson.com>
      Signed-off-by: NLinus Walleij <linus.walleij@stericsson.com>
      Signed-off-by: NRussell King <rmk+kernel@arm.linux.org.uk>
      f444fce3
  2. 27 10月, 2010 33 次提交